scsi: ufs: remove ufshcd_hold asynchronously
Subsystems (2)
PATCH 1/1 scsi: ufs: remove ufshcd_hold asynchronously
If ufshcd_hold() returns EAGAIN during queuecommand, scsi will get an error and resubmit the request along with other commands. This can increase the chance of reording write IOs, even it's sequential.
Signed-off-by Jaegeuk Kim <[email protected]>
--- drivers/ufs/core/ufs-sysfs.c | 2 +- drivers/ufs/core/ufshcd-crypto.c | 2 +- drivers/ufs/core/ufshcd-priv.h | 2 +- drivers/ufs/core/ufshcd.c | 63 +++++++++++--------------------- include/ufs/ufshcd.h | 2 +- 5 files changed, 26 insertions(+), 45 deletions(-)
drivers/ufs/core/ufs-sysfs.c +1 -1
@@ -168,7 +168,7 @@ static ssize_t auto_hibern8_show(struct device *dev, }pm_runtime_get_sync (hba->dev); -ufshcd_hold (hba, false); +ufshcd_hold (hba); ahit =ufshcd_readl (hba,REG_AUTO_HIBERNATE_IDLE_TIMER );ufshcd_release (hba);pm_runtime_put_sync (hba->dev);
drivers/ufs/core/ufshcd-crypto.c +1 -1
@@ -24,7 +24,7 @@ static int ufshcd_program_key(struct ufs_hba *hba,u32 slot_offset = hba->crypto_cfg_register + slot *sizeof (*cfg);int err =0 ; -ufshcd_hold (hba, false); +ufshcd_hold (hba);if (hba->vops && hba->vops->program_key) { err = hba->vops->program_key (hba, cfg, slot);
drivers/ufs/core/ufshcd-priv.h +1 -1
@@ -84,7 +84,7 @@ unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,int ufshcd_read_string_desc (struct ufs_hba *hba,u8 desc_index,u8 **buf,bool ascii); -int ufshcd_hold (struct ufs_hba *hba,bool async); +void ufshcd_hold (struct ufs_hba *hba);void ufshcd_release (struct ufs_hba *hba);int ufshcd_send_uic_cmd (struct ufs_hba *hba,struct uic_command *uic_cmd);
drivers/ufs/core/ufshcd.c +22 -41
211 lines not on this page · raw message
include/ufs/ufshcd.h +1 -1
@@ -1364,7 +1364,7 @@ void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,int ufshcd_read_string_desc (struct ufs_hba *hba,u8 desc_index,u8 **buf,bool ascii); -int ufshcd_hold (struct ufs_hba *hba,bool async); +void ufshcd_hold (struct ufs_hba *hba);void ufshcd_release (struct ufs_hba *hba);void ufshcd_clkgate_delay_set (struct device *dev,unsigned long value);
Signature · 1 line
2.40.0.634.g4ca3ef3211-goog