Skip to contentSkip to conversation

Remove CBAR from A55/A76 and add A78

PATCH In review Jisheng Zhang 1 participant 4 messages Apr 15, 2023 – Apr 17, 2023

lore
Share & tools
lore
#0 lore raw

cover Remove CBAR from A55/A76 and add A78

patch1 removes CBAR from A55 and A76
patch2 adds A78 CPU

Jisheng Zhang (2):
target/arm: Remove ARM_FEATURE_CBAR_RO from A55 and A76 target/arm: Add Cortex-A78 CPU

 docs/system/arm/virt.rst |  1 +
 hw/arm/virt.c            |  1 +
 target/arm/cpu64.c       | 71 ++++++++++++++++++++++++++++++++++++++--
 3 files changed, 71 insertions(+), 2 deletions(-)
Signature · 1 line
2.40.0
#2 lore raw

PATCH 2/2 target/arm: Add Cortex-A78 CPU

Enable the Cortex-A78 for virt to use a CPU type on the virt board that models a specific real hardware CPU, rather than have to use the QEMU-specific "max" CPU type.

---
 docs/system/arm/virt.rst |  1 +
 hw/arm/virt.c            |  1 +
 target/arm/cpu64.c       | 69 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 71 insertions(+)
docs/system/arm/virt.rst +1 -0
index 1cab33f02e..98cb53d977 100644
@@ -58,6 +58,7 @@ Supported guest CPU types:
 - ``cortex-a57`` (64-bit)
 - ``cortex-a72`` (64-bit)
 - ``cortex-a76`` (64-bit)
+- ``cortex-a78`` (64-bit)
 - ``a64fx`` (64-bit)
 - ``host`` (with KVM only)
 - ``neoverse-n1`` (64-bit)
hw/arm/virt.c +1 -0
index ac626b3bef..4e00b58bdb 100644
@@ -212,6 +212,7 @@ static const char *valid_cpus[] = {
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
     ARM_CPU_TYPE_NAME("cortex-a76"),
+    ARM_CPU_TYPE_NAME("cortex-a78"),
     ARM_CPU_TYPE_NAME("a64fx"),
     ARM_CPU_TYPE_NAME("neoverse-n1"),
     ARM_CPU_TYPE_NAME("host"),
target/arm/cpu64.c +69 -0

81 lines not on this page · raw message

Signature · 1 line
2.40.0
#1 lore raw

PATCH 1/2 target/arm: Remove ARM_FEATURE_CBAR_RO from A55 and A76

In reply to Jisheng Zhang

Cortex-A55 and Cortex-A76 doesn't have CBAR, so remove CBAR feature from them.

---
 target/arm/cpu64.c | 2 --
 1 file changed, 2 deletions(-)
target/arm/cpu64.c +0 -2
index 0fb07cc7b6..85dc9d57ff 100644
@@ -796,7 +796,6 @@ static void aarch64_a55_initfn(Object *obj)
     set_feature(&cpu->env, ARM_FEATURE_NEON);
     set_feature(&cpu->env, ARM_FEATURE_GENERIC_TIMER);
     set_feature(&cpu->env, ARM_FEATURE_AARCH64);
-    set_feature(&cpu->env, ARM_FEATURE_CBAR_RO);
     set_feature(&cpu->env, ARM_FEATURE_EL2);
     set_feature(&cpu->env, ARM_FEATURE_EL3);
     set_feature(&cpu->env, ARM_FEATURE_PMU);
@@ -919,7 +918,6 @@ static void aarch64_a76_initfn(Object *obj)
     set_feature(&cpu->env, ARM_FEATURE_NEON);
     set_feature(&cpu->env, ARM_FEATURE_GENERIC_TIMER);
     set_feature(&cpu->env, ARM_FEATURE_AARCH64);
-    set_feature(&cpu->env, ARM_FEATURE_CBAR_RO);
     set_feature(&cpu->env, ARM_FEATURE_EL2);
     set_feature(&cpu->env, ARM_FEATURE_EL3);
     set_feature(&cpu->env, ARM_FEATURE_PMU);
Signature · 1 line
2.40.0
#3 lore raw
In reply to Jisheng Zhang
Quoted 2 lines · Jisheng Zhang

patch1 removes CBAR from A55 and A76
patch2 adds A78 CPU

For various reasons, I'd like to recall these two patches.

Quoted 14 lines

Jisheng Zhang (2):
target/arm: Remove ARM_FEATURE_CBAR_RO from A55 and A76 target/arm: Add Cortex-A78 CPU

 docs/system/arm/virt.rst |  1 +
 hw/arm/virt.c            |  1 +
 target/arm/cpu64.c       | 71 ++++++++++++++++++++++++++++++++++++++--
 3 files changed, 71 insertions(+), 2 deletions(-)
Signature · 1 line
2.40.0