Skip to contentSkip to conversation

i2c: ocores: add missing unwind goto in `ocores_i2c_probe`

PATCH New Wang Zhang 1 participant 1 message Apr 16, 2023

Subsystems (2)
lore
Share & tools
lore

Wang Zhang

author
#0 lore raw

PATCH 1/1 i2c: ocores: add missing unwind goto in `ocores_i2c_probe`

The error handling code after the err_clk label should be executed to release any resources that were allocated for the clock if a negative error code returned.

Fix this by assigning irq to ret and changing the direct return to err_clk.

---
 drivers/i2c/busses/i2c-ocores.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-ocores.c +4 -2
index a0af027db04c..95efad5a5a28 100644
@@ -697,8 +697,10 @@ static int ocores_i2c_probe(struct platform_device *pdev)
 	if (irq == -ENXIO) {
 		ocores_algorithm.master_xfer = ocores_xfer_polling;
 	} else {
-		if (irq < 0)
-			return irq;
+		if (irq < 0) {
+			ret = irq;
+			goto err_clk;
+		}
 	}
 
 	if (ocores_algorithm.master_xfer != ocores_xfer_polling) {
Signature · 1 line
2.34.1