clk: imx: imx6sx: Remove CLK_SET_RATE_PARENT from the LDB clocks
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/1 clk: imx: imx6sx: Remove CLK_SET_RATE_PARENT from the LDB clocks
From: Fabio Estevam <[email protected]>
On the i.MX6SX, it is common to use the LDB and LCDIF with the same parent clock, such as the IMX6SX_CLK_PLL5_VIDEO_DIV, for example.
Due to the CLK_SET_RATE_PARENT flag, the LDB clock would try to set the clock parent rate, which can mess with the required clock rate calculated from the eLCDIF driver.
To prevent this problem, remove the CLK_SET_RATE_PARENT flag from the LDB clocks, so that a correct clock relationship can be achieved.
--- drivers/clk/imx/clk-imx6sx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/clk/imx/clk-imx6sx.c +4 -4
@@ -302,10 +302,10 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) hws[IMX6SX_CLK_CKO2_SEL ] =imx_clk_hw_mux ("cko2_sel" , base +0x60 ,16 ,5 , cko2_sels,ARRAY_SIZE (cko2_sels)); hws[IMX6SX_CLK_CKO ] =imx_clk_hw_mux ("cko" , base +0x60 ,8 ,1 , cko_sels,ARRAY_SIZE (cko_sels)); - hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels),CLK_SET_RATE_PARENT ); + hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels)); + hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels)); + hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels)); + hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels)); hws[IMX6SX_CLK_LCDIF1_PRE_SEL ] =imx_clk_hw_mux_flags ("lcdif1_pre_sel" , base +0x38 ,15 ,3 , lcdif1_pre_sels,ARRAY_SIZE (lcdif1_pre_sels),CLK_SET_RATE_PARENT ); hws[IMX6SX_CLK_LCDIF1_SEL ] =imx_clk_hw_mux_flags ("lcdif1_sel" , base +0x38 ,9 ,3 , lcdif1_sels,ARRAY_SIZE (lcdif1_sels),CLK_SET_RATE_PARENT );
Signature · 1 line
2.34.1
+Ying
Quoted 36 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX, it is common to use the LDB and LCDIF with the same parent clock, such as the
IMX6SX_CLK_PLL5_VIDEO_DIV, for example.Due to the
CLK_SET_RATE_PARENTflag, the LDB clock would try to set the clock parent rate, which can mess with the required clock rate calculated from the eLCDIF driver.To prevent this problem, remove the
CLK_SET_RATE_PARENTflag from the LDB clocks, so that a correct clock relationship can be achieved.Signed-off-by Fabio Estevam <[email protected]>--- drivers/clk/imx/clk-imx6sx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/clk/imx/clk-imx6sx.c +4
-4@@ -302,10 +302,10 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) hws[IMX6SX_CLK_CKO2_SEL ] =imx_clk_hw_mux ("cko2_sel" , base +0x60 ,16 ,5 , cko2_sels,ARRAY_SIZE (cko2_sels)); hws[IMX6SX_CLK_CKO ] =imx_clk_hw_mux ("cko" , base +0x60 ,8 ,1 , cko_sels,ARRAY_SIZE (cko_sels)); - hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels),CLK_SET_RATE_PARENT ); + hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels)); + hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels)); + hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels)); + hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels)); hws[IMX6SX_CLK_LCDIF1_PRE_SEL ] =imx_clk_hw_mux_flags ("lcdif1_pre_sel" , base +0x38 ,15 ,3 , lcdif1_pre_sels,ARRAY_SIZE (lcdif1_pre_sels),CLK_SET_RATE_PARENT ); hws[IMX6SX_CLK_LCDIF1_SEL ] =imx_clk_hw_mux_flags ("lcdif1_sel" , base +0x38 ,9 ,3 , lcdif1_sels,ARRAY_SIZE (lcdif1_sels),CLK_SET_RATE_PARENT );
Fabio Estevam
reviewerQuoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX, it is common to use the LDB and LCDIF with the same parent clock, such as the
IMX6SX_CLK_PLL5_VIDEO_DIV, for example.
Quoted 8 lines
Due to the
CLK_SET_RATE_PARENTflag, the LDB clock would try to set the clock parent rate, which can mess with the required clock rate calculated from the eLCDIF driver.To prevent this problem, remove the
CLK_SET_RATE_PARENTflag from the LDB clocks, so that a correct clock relationship can be achieved.Signed-off-by Fabio Estevam <[email protected]>
A gentle ping.
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX, it is common to use the LDB and LCDIF with the same parent clock, such as the
IMX6SX_CLK_PLL5_VIDEO_DIV, for example.
Quoted 8 lines
Due to the
CLK_SET_RATE_PARENTflag, the LDB clock would try to set the clock parent rate, which can mess with the required clock rate calculated from the eLCDIF driver.To prevent this problem, remove the
CLK_SET_RATE_PARENTflag from the LDB clocks, so that a correct clock relationship can be achieved.Signed-off-by Fabio Estevam <[email protected]>
Looks good to me.
This has missed my inbox as I filter on linux-imx email, which you forgot to CC. Please do that next time.
Quoted 26 lines
--- drivers/clk/imx/clk-imx6sx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/clk/imx/clk-imx6sx.c +4
-4@@ -302,10 +302,10 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) hws[IMX6SX_CLK_CKO2_SEL ] =imx_clk_hw_mux ("cko2_sel" , base +0x60 ,16 ,5 , cko2_sels,ARRAY_SIZE (cko2_sels)); hws[IMX6SX_CLK_CKO ] =imx_clk_hw_mux ("cko" , base +0x60 ,8 ,1 , cko_sels,ARRAY_SIZE (cko_sels)); - hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux_flags ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels),CLK_SET_RATE_PARENT ); - hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux_flags ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels),CLK_SET_RATE_PARENT ); + hws[IMX6SX_CLK_LDB_DI1_DIV_SEL ] =imx_clk_hw_mux ("ldb_di1_div_sel" , base +0x20 ,11 ,1 , ldb_di1_div_sels,ARRAY_SIZE (ldb_di1_div_sels)); + hws[IMX6SX_CLK_LDB_DI0_DIV_SEL ] =imx_clk_hw_mux ("ldb_di0_div_sel" , base +0x20 ,10 ,1 , ldb_di0_div_sels,ARRAY_SIZE (ldb_di0_div_sels)); + hws[IMX6SX_CLK_LDB_DI1_SEL ] =imx_clk_hw_mux ("ldb_di1_sel" , base +0x2c ,12 ,3 , ldb_di1_sels,ARRAY_SIZE (ldb_di1_sels)); + hws[IMX6SX_CLK_LDB_DI0_SEL ] =imx_clk_hw_mux ("ldb_di0_sel" , base +0x2c ,9 ,3 , ldb_di0_sels,ARRAY_SIZE (ldb_di0_sels)); hws[IMX6SX_CLK_LCDIF1_PRE_SEL ] =imx_clk_hw_mux_flags ("lcdif1_pre_sel" , base +0x38 ,15 ,3 , lcdif1_pre_sels,ARRAY_SIZE (lcdif1_pre_sels),CLK_SET_RATE_PARENT ); hws[IMX6SX_CLK_LCDIF1_SEL ] =imx_clk_hw_mux_flags ("lcdif1_sel" , base +0x38 ,9 ,3 , lcdif1_sels,ARRAY_SIZE (lcdif1_sels),CLK_SET_RATE_PARENT );Signature · 1 line
2.34.1
Abel Vesa
AppliedQuoted 8 lines · Fabio Estevam
On the i.MX6SX, it is common to use the LDB and LCDIF with the same parent clock, such as the
IMX6SX_CLK_PLL5_VIDEO_DIV, for example.Due to the
CLK_SET_RATE_PARENTflag, the LDB clock would try to set the clock parent rate, which can mess with the required clock rate calculated from the eLCDIF driver.[...]
Applied, thanks!
[1/1] clk: imx: imx6sx: Remove CLK_SET_RATE_PARENT from the LDB clocks
commit: 370da75066e32bef008ca17290f4aa644500100c
Best regards,
Signature · 1 line
Abel Vesa <[email protected]>