Skip to contentSkip to conversation

common/rc: skip ceph when atime is required

PATCH In review [email protected] 2 participants 3 messages Apr 17, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/rc: skip ceph when atime is required

From: Xiubo Li <[email protected]>

Ceph won't maintain the atime, so just skip the tests when the atime is required.

URL: https://tracker.ceph.com/issues/53844

---
 common/rc | 3 +++
 1 file changed, 3 insertions(+)
common/rc +3 -0
index 90749343..3238842e 100644
@@ -3999,6 +3999,9 @@ _require_atime()
 	nfs|cifs|virtiofs)
 		_notrun "atime related mount options have no effect on $FSTYP"
 		;;
+	ceph)
+                _notrun "atime not maintained by $FSTYP"
+		;;
 	esac
 
 }
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · On Mon, Apr 17, 2023 at 10:41:34AM +0800, [email protected] wrote:

From: Xiubo Li <[email protected]>

Ceph won't maintain the atime, so just skip the tests when the atime is required.

URL: https://tracker.ceph.com/issues/53844

---
 common/rc | 3 +++
 1 file changed, 3 insertions(+)
common/rc +0 -0
index 90749343..3238842e 100644

common/rc _require_atime() · line 4003

Quoted 5 lines
common/rc +2 -0
@@ -3999,6 +3999,9 @@ _require_atime()
 	nfs|cifs|virtiofs)
 		_notrun "atime related mount options have no effect on $FSTYP"
 		;;
+	ceph)
+                _notrun "atime not maintained by $FSTYP"

Make sense to me. I'll change this line a bit when I merge it, to keep the line aligned (with above).

Thanks,
Zorro

Quoted 7 lines
common/rc +1 -0
+		;;
 	esac
 
 }
Signature · 1 line
2.39.1
author
#2 lore raw
Quoted 25 lines · Zorro Lang
Quoted 16 lines · On Mon, Apr 17, 2023 at 10:41:34AM +0800, [email protected] wrote:

From: Xiubo Li <[email protected]>

Ceph won't maintain the atime, so just skip the tests when the atime is required.

URL: https://tracker.ceph.com/issues/53844

---
  common/rc | 3 +++
  1 file changed, 3 insertions(+)
common/rc +0 -0
index 90749343..3238842e 100644

common/rc _require_atime() · line 4003

Quoted 5 lines
common/rc +2 -0
@@ -3999,6 +3999,9 @@ _require_atime()
  	nfs|cifs|virtiofs)
  		_notrun "atime related mount options have no effect on $FSTYP"
  		;;
+	ceph)
+                _notrun "atime not maintained by $FSTYP"

Make sense to me. I'll change this line a bit when I merge it, to keep the line aligned (with above).

Quoted 1 line

Sure, thanks Zorro.

- Xiubo

Quoted 10 lines

Thanks,
Zorro

Quoted 7 lines
common/rc +1 -0
+		;;
  	esac
 
  }
Signature · 1 line
2.39.1