Skip to contentSkip to conversation

Fix addition on an uninitialized variable 'run'

PATCH In review Colin Ian King 2 participants 2 messages Apr 17, 2023 – Apr 24, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix addition on an uninitialized variable 'run'

The variable run is not initialized however it is being accumulated by the return value from the call to ikm_run_monitor. Fix this by replacing the += with an assignment since this is the first point where run is being assigned.

Fixes 4bc4b131d44c ("rv: Add rv tool")
---
 tools/verification/rv/src/rv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/verification/rv/src/rv.c +1 -1
index e601cd9c411e..da647ad4e733 100644
@@ -111,7 +111,7 @@ static void rv_mon(int argc, char **argv)
 	 * Call all possible monitor implementations, looking
 	 * for the [monitor].
 	 */
-	run += ikm_run_monitor(monitor_name, argc-1, &argv[1]);
+	run = ikm_run_monitor(monitor_name, argc-1, &argv[1]);
 
 	if (!run)
 		err_msg("rv: monitor %s does not exist\n", monitor_name);
Signature · 1 line
2.30.2
#1 lore raw
Quoted 1 line · Colin Ian King

The variable run is not initialized

Oops, that is a problem, it should be initialized as 0.

however it is being accumulated

Quoted 16 lines

by the return value from the call to ikm_run_monitor. Fix this by replacing the += with an assignment since this is the first point where run is being assigned.

Fixes 4bc4b131d44c ("rv: Add rv tool")
---
 tools/verification/rv/src/rv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/verification/rv/src/rv.c +0 -0
index e601cd9c411e..da647ad4e733 100644

tools/verification/rv/src/rv.c static void rv_mon(int argc, char **argv) · line 114

Quoted 5 lines
tools/verification/rv/src/rv.c +1 -1
@@ -111,7 +111,7 @@ static void rv_mon(int argc, char **argv)
 	 * Call all possible monitor implementations, looking
 	 * for the [monitor].
 	 */
-	run += ikm_run_monitor(monitor_name, argc-1, &argv[1]);
+	run = ikm_run_monitor(monitor_name, argc-1, &argv[1]);

So, in the future, there will be more monitors types, and so we will check other functions to see if they find the monitor by name. Thus, the += is correct, what is not correct the run not being initialized.

Mind sending a patch initializing the run = 0?

Thanks!
-- Daniel

Quoted 2 lines
tools/verification/rv/src/rv.c +0 -0
 	if (!run)
 		err_msg("rv: monitor %s does not exist\n", monitor_name);