ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470
PATCH 1/1 ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470
From: Hans de Goede <[email protected]>
The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using acpi_video for backlight control. But this is not functional on this model.
Add a DMI quirk to use the native backlight interface which works.
--- drivers/acpi/video_detect.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/acpi/video_detect.c +9 -0
@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"), }, }, + { +/* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */ + .callback = video_detect_force_native, +/* Lenovo Ideapad Z470 */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"), + }, + }, {/* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */ .callback = video_detect_force_native,
Signature · 1 line
2.40.0
Rafael J. Wysocki
maintainerQuoted 7 lines · Jiri Slaby (SUSE)
From: Hans de Goede <[email protected]>
The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
acpi_videofor backlight control. But this is not functional on this model.
Quoted 6 lines
Add a DMI quirk to use the native backlight interface which works.
Signed-off-by Jiri Slaby (SUSE) <[email protected]>Cc Hans de Goede <[email protected]>Cc Rafael J. Wysocki <[email protected]>
Hans, can you please give your S-o-b for this one?
Quoted 27 lines
--- drivers/acpi/video_detect.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/acpi/video_detect.c +9
-1@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"), }, }, + { +/* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */ + .callback = video_detect_force_native, +/* Lenovo Ideapad Z470 */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"), + }, + }, {/* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */ .callback = video_detect_force_native, --2.40.0
Hans de Goede
Reviewed-byHi,
Quoted 8 lines · Rafael J. Wysocki
Quoted 7 lines · Jiri Slaby (SUSE)
From: Hans de Goede <[email protected]>
The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
acpi_videofor backlight control. But this is not functional on this model.
Quoted 8 lines
Quoted 6 lines
Add a DMI quirk to use the native backlight interface which works.
Signed-off-by Jiri Slaby (SUSE) <[email protected]>Cc Hans de Goede <[email protected]>Cc Rafael J. Wysocki <[email protected]>Hans, can you please give your S-o-b for this one?
Hmm, I do not believe that I wrote this patch (also see the suse bugzilla link in the comment it adds) ?
I guess it started as a copy of my "ACPI: video: Add backlight=native DMI quirk for Acer Aspire 3830TG" patch and that is why I was kept as the author ?
Anyways I'm fine with me being the author, or with Jiri being the author. Pick a tag depending on the answer:
Regards,
Hans
Quoted 29 lines
Quoted 28 lines
--- drivers/acpi/video_detect.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/acpi/video_detect.c +9
-1@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"), }, }, + { +/* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */ + .callback = video_detect_force_native, +/* Lenovo Ideapad Z470 */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"), + }, + }, {/* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */ .callback = video_detect_force_native, --2.40.0
Quoted 23 lines · Hans de Goede
Hi,
Quoted 8 lines · Rafael J. Wysocki
Quoted 7 lines · Jiri Slaby (SUSE)
From: Hans de Goede <[email protected]>
The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
acpi_videofor backlight control. But this is not functional on this model.Quoted 8 lines
Quoted 6 lines
Add a DMI quirk to use the native backlight interface which works.
Signed-off-by Jiri Slaby (SUSE) <[email protected]>Cc Hans de Goede <[email protected]>Cc Rafael J. Wysocki <[email protected]>Hans, can you please give your S-o-b for this one?
Hmm, I do not believe that I wrote this patch (also see the suse bugzilla link in the comment it adds) ?
Quoted 6 lines
I guess it started as a copy of my "ACPI: video: Add backlight=native DMI quirk for Acer Aspire 3830TG" patch and that is why I was kept as the author ?
Anyways I'm fine with me being the author, or with Jiri being the author. Pick a tag depending on the answer:
Huh, sorry. I forgot to --reset-author. Let me fix this mess up.
Thanks.
Quoted 42 lines
Signed-off-by Hans de Goede <[email protected]>Reviewed-by Hans de Goede <[email protected]>Regards,
Hans
Quoted 29 lines
Quoted 28 lines
--- drivers/acpi/video_detect.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/acpi/video_detect.c +9
-1@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"), }, }, + { +/* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */ + .callback = video_detect_force_native, +/* Lenovo Ideapad Z470 */ + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"), + }, + }, {/* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */ .callback = video_detect_force_native, --2.40.0
Signature · 1 line
js