Skip to contentSkip to conversation

drm/nouveau: dispnv50: fix missing-prototypes warning

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 17, 2023 – May 22, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau: dispnv50: fix missing-prototypes warning

From: Arnd Bergmann <[email protected]>

nv50_display_create() is declared in another header, along with a couple of declarations that are now outdated:

drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create'

Fixes ba801ef068c1 ("drm/nouveau/kms: display destroy/init/fini hooks can be static")
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 +
 drivers/gpu/drm/nouveau/nv50_display.h  | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -0
index 5bb777ff1313..9b6824f6b9e4 100644
@@ -64,6 +64,7 @@
 #include "nouveau_connector.h"
 #include "nouveau_encoder.h"
 #include "nouveau_fence.h"
+#include "nv50_display.h"
 
 #include <subdev/bios/dp.h>
 
drivers/gpu/drm/nouveau/nv50_display.h +1 -3
index fbd3b15583bc..60f77766766e 100644
@@ -31,7 +31,5 @@
 #include "nouveau_reg.h"
 
 int  nv50_display_create(struct drm_device *);
-void nv50_display_destroy(struct drm_device *);
-int  nv50_display_init(struct drm_device *);
-void nv50_display_fini(struct drm_device *);
+
 #endif /* __NV50_DISPLAY_H__ */
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw

will merge soon

Quoted 43 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

nv50_display_create() is declared in another header, along with a couple of declarations that are now outdated:

drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create'

Fixes ba801ef068c1 ("drm/nouveau/kms: display destroy/init/fini hooks can be static")
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 +
 drivers/gpu/drm/nouveau/nv50_display.h  | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -0
index 5bb777ff1313..9b6824f6b9e4 100644
@@ -64,6 +64,7 @@
 #include "nouveau_connector.h"
 #include "nouveau_encoder.h"
 #include "nouveau_fence.h"
+#include "nv50_display.h"
 
 #include <subdev/bios/dp.h>
 
drivers/gpu/drm/nouveau/nv50_display.h +1 -4
index fbd3b15583bc..60f77766766e 100644
@@ -31,7 +31,5 @@
 #include "nouveau_reg.h"
 
 int  nv50_display_create(struct drm_device *);
-void nv50_display_destroy(struct drm_device *);
-int  nv50_display_init(struct drm_device *);
-void nv50_display_fini(struct drm_device *);
+
 #endif /* __NV50_DISPLAY_H__ */
--

2.39.2