tests/kms_display_modes: Add negative test for extended display
PATCH 1/1 tests/kms_display_modes: Add negative test for extended display
Added negative test to validte ENOSPC when two 2k-4k or 4k-4k moniters connected through MST.
This test added to prvode bandwidth issue in MST config.
Example:
When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth. So, iterate through connected outputs & modes and find a combination of modes those fit into the link BW.
v2: Rebased on tip.
v3: -Code cleanup and updated description.
-Free path_blob before call return. (Kamil)
v4: Updated code formatting and function description. (Jeevan)
--- tests/kms_display_modes.c | 161 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 161 insertions(+)
tests/kms_display_modes.c +161 -0
@@ -26,14 +26,107 @@#include "igt.h" +#define HDISPLAY_2K 2560 +#define VDISPLAY_2K 1440 + +#define HDISPLAY_4K 3840 +#define VDISPLAY_4K 2160 +IGT_TEST_DESCRIPTION ("Test Display Modes" );typedef struct {int drm_fd;igt_display_t display; +drmModeModeInfo mode_mst[2 ]; +igt_output_t *mst_output[2 ];int n_pipes; }data_t ; +/*Get higher mode supported by panel*/ +static drmModeModeInfo *get_highres_mode (igt_output_t *output) +{ +drmModeConnector *connector = output->config.connector; +drmModeModeInfo *highest_mode =NULL ; + +igt_sort_connector_modes (connector, sort_drm_modes_by_res_dsc); + highest_mode = &connector->modes[0 ]; + +return highest_mode; +} + +/*Get the 4k or less then 4k mode of connected panel*/ +static drmModeModeInfo *get_mode (igt_output_t *output) +{ +int j; +drmModeModeInfo *required_mode =NULL ; +drmModeConnector *connector = output->config.connector; + +igt_sort_connector_modes (connector, sort_drm_modes_by_res_dsc); +for (j =0 ; j < connector->count_modes; j++) { +if (connector->modes[j].vdisplay <=VDISPLAY_4K && + connector->modes[j].hdisplay <=HDISPLAY_4K ) { + required_mode = &connector->modes[j]; +break ; + } + } + +return required_mode; +} + +static int parse_path_blob (char *blob_data) +{ +int connector_id; +char *encoder; + + encoder =strtok (blob_data,":" ); +igt_assert_f (!strcmp (encoder,"mst" ),"PATH connector property expected to have 'mst'\n" ); + + connector_id =atoi (strtok (NULL ,"-" )); + +return connector_id; +} + +static bool output_is_dp_mst (data_t *data,igt_output_t *output,int i) +{ +drmModePropertyBlobPtr path_blob =NULL ; +uint64_t path_blob_id; +drmModeConnector *connector = output->config.connector; +struct kmstest_connector_config config; +const char *encoder; +int connector_id; +static int prev_connector_id; + +kmstest_get_connector_config (data->drm_fd, output->config.connector->connector_id, +-1 , &config); + encoder =kmstest_encoder_type_str (config.encoder->encoder_type); + +if (strcmp (encoder,"DP MST" )) +return false; + +igt_assert (kmstest_get_property (data->drm_fd, connector->connector_id, +DRM_MODE_OBJECT_CONNECTOR ,"PATH" ,NULL , + &path_blob_id,NULL )); + +igt_assert (path_blob =drmModeGetPropertyBlob (data->drm_fd, path_blob_id)); + + connector_id =parse_path_blob ((char *) path_blob->data); + +drmModeFreePropertyBlob (path_blob); + +/* +* Discarding outputs of other DP MST topology. +* Testing only on outputs on the topology we got previously +*/ +if (i ==0 ) { + prev_connector_id = connector_id; + }else { +if (connector_id != prev_connector_id) +return false; + } + +return true; +} +static void run_extendedmode_basic (data_t *data,enum pipe pipe1,igt_output_t *output1,enum pipe pipe2,igt_output_t *output2)
@@ -173,8 +266,46 @@ static void run_extendedmode_test(data_t *data) { } } +static void run_extendedmode_negative (data_t *data,int pipe1,int pipe2) +{ +struct igt_fb fbs[2 ]; +igt_display_t *display = &data->display; +igt_plane_t *plane[2 ]; +int ret; + +igt_display_reset (display); + +igt_output_set_pipe (data->mst_output[0 ], pipe1); +igt_output_set_pipe (data->mst_output[1 ], pipe2); + +igt_create_color_fb (data->drm_fd, data->mode_mst[0 ].hdisplay, data->mode_mst[0 ].vdisplay, +DRM_FORMAT_XRGB8888 ,DRM_FORMAT_MOD_LINEAR ,1 ,0 ,0 , &fbs[0 ]); +igt_create_color_fb (data->drm_fd, data->mode_mst[1 ].hdisplay, data->mode_mst[1 ].vdisplay, +DRM_FORMAT_XRGB8888 ,DRM_FORMAT_MOD_LINEAR ,0 ,0 ,1 , &fbs[1 ]); + + plane[0 ] =igt_pipe_get_plane_type (&display->pipes[pipe1],DRM_PLANE_TYPE_PRIMARY ); + plane[1 ] =igt_pipe_get_plane_type (&display->pipes[pipe2],DRM_PLANE_TYPE_PRIMARY ); + +igt_plane_set_fb (plane[0 ], &fbs[0 ]); +igt_fb_set_size (&fbs[0 ], plane[0 ], data->mode_mst[0 ].hdisplay, data->mode_mst[0 ].vdisplay); +igt_plane_set_size (plane[0 ], data->mode_mst[0 ].hdisplay, data->mode_mst[0 ].vdisplay); + +igt_plane_set_fb (plane[1 ], &fbs[1 ]); +igt_fb_set_size (&fbs[1 ], plane[1 ], data->mode_mst[1 ].hdisplay, data->mode_mst[1 ].vdisplay); +igt_plane_set_size (plane[1 ], data->mode_mst[1 ].hdisplay, data->mode_mst[1 ].vdisplay); + +igt_output_override_mode (data->mst_output[0 ], &data->mode_mst[0 ]); +igt_output_override_mode (data->mst_output[1 ], &data->mode_mst[1 ]); + + ret =igt_display_try_commit2 (display,COMMIT_ATOMIC ); +igt_assert (ret !=0 && errno ==ENOSPC ); +} + igt_main { +int dp_mst_outputs =0 , count =0 ; +enum pipe pipe1, pipe2; +igt_output_t *output;data_t data; igt_fixture {
@@ -182,12 +313,42 @@ igt_mainkmstest_set_vt_graphics_mode ();igt_display_require (&data.display, data.drm_fd);igt_display_require_output (&data.display); + +for_each_connected_output (&data.display, output) { + data.mst_output[count++] = output; +if (output_is_dp_mst (&data, output, dp_mst_outputs)) + dp_mst_outputs++; + } }igt_describe ("Test for validating display extended mode with a pair of connected displays" ); igt_subtest_with_dynamic("extended-mode-basic")run_extendedmode_test (&data); +igt_describe ("Negative test for validating display extended mode with a pair of connected " +"2k-4k or 4k-4k displays" ); + igt_subtest_with_dynamic("mst-extended-mode-negative") { +igt_require_f (dp_mst_outputs >1 ,"MST not found more then one\n" ); + +memcpy (&data.mode_mst[0 ],get_mode (data.mst_output[0 ]),sizeof (drmModeModeInfo)); +memcpy (&data.mode_mst[1 ],get_highres_mode (data.mst_output[1 ]), +sizeof (drmModeModeInfo)); + +igt_require_f ((data.mode_mst[1 ].hdisplay >=HDISPLAY_4K && + data.mode_mst[1 ].vdisplay >=VDISPLAY_4K ),"4k panel not found\n" ); + +for_each_pipe (&data.display, pipe1) { +for_each_pipe (&data.display, pipe2) { +if (pipe1 == pipe2) +continue ; + +igt_dynamic_f ("pipe-%s-%s" ,kmstest_pipe_name (pipe1), + kmstest_pipe_name(pipe2)) +run_extendedmode_negative (&data, pipe1, pipe2); + } + } + } + igt_fixture {igt_display_fini (&data.display); }
Signature · 1 line
2.25.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_display_modes: Add negative test for extended display (rev5)
== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Add negative test for extended display (rev5)
URL : https://patchwork.freedesktop.org/series/115522/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13025 -> IGTPW_8813
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
Participating hosts (37 -> 36)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8813 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][1] ([i915#6687] / [i915#7978])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-dg2-11: [PASS][2] -> [FAIL][3] ([i915#8308])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/bat-dg2-11/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-dg2-11/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [PASS][4] -> [DMESG-FAIL][5] ([i915#5334])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][6] -> [ABORT][7] ([i915#7913])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/bat-rpls-2/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-adlp-9: [PASS][8] -> [INCOMPLETE][9] ([i915#4983] / [i915#7677] / [i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/bat-adlp-9/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-adlp-9/igt@i915_selftest@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-jsl-1: NOTRUN -> [SKIP][10] ([i915#7828])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-jsl-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][11] ([i915#5334]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][13] ([i915#7699]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/bat-dg2-11/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-dg2-11/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][15] ([i915#4983]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/bat-rpls-1/igt@i915_selftest@[email protected]
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7258 -> IGTPW_8813
CI-20190529: 20190529
CI_DRM_13025: aedb908bbfc13d3d66f2715709f26f02283aef5a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8813: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
IGT_7258: ad2eb276eda849b7a7985229009a816c7608186c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_display_modes@mst-extended-mode-negative
-igt@xe_gpgpu_fill@basic
-igt@xe_intel_bb@add-remove-objects
-igt@xe_intel_bb@bb-with-allocator
-igt@xe_intel_bb@blit-reloc
-igt@xe_intel_bb@blit-simple
-igt@xe_intel_bb@create-in-region
-igt@xe_intel_bb@delta-check
-igt@xe_intel_bb@destroy-bb
-igt@xe_intel_bb@full-batch
-igt@xe_intel_bb@intel-bb-blit-none
-igt@xe_intel_bb@intel-bb-blit-x
-igt@xe_intel_bb@intel-bb-blit-y
-igt@xe_intel_bb@lot-of-buffers
-igt@xe_intel_bb@offset-control
-igt@xe_intel_bb@purge-bb
-igt@xe_intel_bb@render
-igt@xe_intel_bb@reset-bb
-igt@xe_intel_bb@simple-bb
-igt@xe_intel_bb@simple-bb-ctx
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_display_modes: Add negative test for extended display (rev5)
In reply to Mohammed Thasleem== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Add negative test for extended display (rev5)
URL : https://patchwork.freedesktop.org/series/115522/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13025_full -> IGTPW_8813_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8813_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_8813_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8813_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-snb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-snb1/igt@[email protected]
* {igt@kms_display_modes@mst-extended-mode-negative} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-rkl-2/igt@[email protected]
- {shard-dg1}: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-dg1-16/igt@[email protected]
- {shard-tglu}: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-tglu-9/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@perf_pmu@busy-hang@vcs0:
- {shard-dg1}: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-dg1-16/igt@perf_pmu@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_13025_full and IGTPW_8813_full:
### New IGT tests (1) ###
* igt@kms_display_modes@mst-extended-mode-negative:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8813_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl4/igt@gem_exec_fair@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* {igt@kms_display_modes@mst-extended-mode-negative} (NEW):
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-glk2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#79]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-glk5/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-glk4/igt@kms_flip@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271]) +38 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-snb2/igt@kms_plane_scaling@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][18] ([i915#6268]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-tglu-10/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-tglu-6/igt@[email protected]
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][20] ([i915#5784]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-dg1-15/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-dg1-15/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-apl: [FAIL][22] ([i915#2846]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl7/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl6/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][24] ([i915#2842]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-glk8/igt@gem_exec_fair@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-glk1/igt@gem_exec_fair@[email protected]
- shard-apl: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl6/igt@gem_exec_fair@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl}: [FAIL][28] ([i915#2842]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-rkl-3/igt@gem_exec_fair@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-rkl-4/igt@gem_exec_fair@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-dg1}: [SKIP][30] ([i915#1397]) -> [PASS][31] +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-dg1-14/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-dg1-16/igt@[email protected]
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][32] ([i915#6537]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl2/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-dp-1:
- shard-apl: [FAIL][34] ([i915#2521]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-apl7/igt@kms_async_flips@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-apl6/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [FAIL][36] ([i915#3743]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-rkl-4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][38] ([i915#2346]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-glk9/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-glk8/igt@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- {shard-tglu}: [SKIP][40] ([i915#433]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-tglu-7/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-tglu-6/igt@[email protected]
* igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-2:
- {shard-rkl}: [FAIL][42] ([i915#8292]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13025/shard-rkl-1/igt@kms_plane_scaling@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/shard-rkl-4/igt@kms_plane_scaling@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7258 -> IGTPW_8813
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13025: aedb908bbfc13d3d66f2715709f26f02283aef5a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8813: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
IGT_7258: ad2eb276eda849b7a7985229009a816c7608186c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8813/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_display_modes: Add negative test for extended display (rev6)
In reply to Mohammed Thasleem== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Add negative test for extended display (rev6)
URL : https://patchwork.freedesktop.org/series/115522/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13026 -> IGTPW_8817
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
Participating hosts (38 -> 37)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): bat-rpls-2 fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8817 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: [PASS][1] -> [ABORT][2] ([i915#6687] / [i915#7978])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][5] -> [INCOMPLETE][6] ([i915#7609] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271]) +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/fi-kbl-soraka/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][9] ([i915#6367] / [i915#6997]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/bat-rpls-1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7259 -> IGTPW_8817
CI-20190529: 20190529
CI_DRM_13026: 45bed7de41ad8bd909a82382a8fc4cb65e04ad56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8817: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
IGT_7259: 3d3a7f1c041d3f8d84d7457abf96adef0ea071cb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_display_modes@mst-extended-mode-negative
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_display_modes: Add negative test for extended display (rev6)
In reply to Mohammed Thasleem== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Add negative test for extended display (rev6)
URL : https://patchwork.freedesktop.org/series/115522/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13026_full -> IGTPW_8817_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8817_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_display_modes@mst-extended-mode-negative} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-4/igt@[email protected]
- {shard-dg1}: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-dg1-14/igt@[email protected]
- {shard-tglu}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-tglu-2/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_vblank@pipe-g-query-busy:
- {shard-tglu}: NOTRUN -> [SKIP][4] +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-tglu-10/igt@[email protected]
* igt@kms_vblank@pipe-h-ts-continuation-dpms-suspend:
- {shard-dg1}: NOTRUN -> [SKIP][5] +53 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-dg1-15/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_13026_full and IGTPW_8817_full:
### New IGT tests (1) ###
* igt@kms_display_modes@mst-extended-mode-negative:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8817_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-glk8/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][8] -> [ABORT][9] ([i915#5566])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-apl3/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-apl2/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: NOTRUN -> [FAIL][10] ([i915#4767])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-glk6/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-valid-mode:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271]) +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-valid-mode.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +34 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-snb4/igt@kms_plane_scaling@[email protected]
* igt@kms_vblank@pipe-g-query-forked:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271]) +9 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-glk9/igt@[email protected]
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-tglu}: [ABORT][14] ([i915#8211]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-tglu-9/igt@gem_barrier_race@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-tglu-7/igt@gem_barrier_race@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-rkl-4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-3/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-apl1/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl}: [FAIL][20] ([i915#2842]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-rkl-1/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- {shard-dg1}: [ABORT][22] ([i915#7975]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-dg1-14/igt@gem_exec_suspend@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-dg1-15/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][24] ([i915#5493]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-dg1-15/igt@gem_lmem_swapping@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-dg1-14/igt@gem_lmem_swapping@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][26] ([fdo#109271]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-apl7/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-apl6/igt@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-rkl}: [SKIP][28] ([i915#1397]) -> [PASS][29] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-rkl-7/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-4/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][30] ([i915#1397]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-dg1-14/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-dg1-18/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][32] ([i915#2346]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-glk1/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-glk6/igt@[email protected]
- shard-apl: [FAIL][34] ([i915#2346]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-apl1/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-apl1/igt@[email protected]
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][36] ([i915#8011]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-6/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][38] ([i915#79]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-glk2/igt@kms_flip@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-glk5/igt@kms_flip@[email protected]
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][40] ([i915#4349]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13026/shard-rkl-3/igt@perf_pmu@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/shard-rkl-7/igt@perf_pmu@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7259 -> IGTPW_8817
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13026: 45bed7de41ad8bd909a82382a8fc4cb65e04ad56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8817: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
IGT_7259: 3d3a7f1c041d3f8d84d7457abf96adef0ea071cb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8817/index.html
Quoted 21 lines
-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Mohammed Thasleem
Sent: Tuesday, April 18, 2023 2:31 PM
To: [email protected]
Subject: [igt-dev] [PATCH i-g-t] tests/kms_display_modes: Add negative test for extended displayAdded negative test to validte ENOSPC when two 2k-4k or 4k-4k moniters connected through MST.
This test added to prvode bandwidth issue in MST config.Example:
When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth. So, iterate through connected outputs & modes and find a combination of modes those fit into the link BW.
Quoted 6 lines
v2: Rebased on tip.
v3: -Code cleanup and updated description.
-Freepath_blobbefore call return. (Kamil)
v4: Updated code formatting and function description. (Jeevan)Signed-off-by Mohammed Thasleem <[email protected]>
LGTM
Quoted 230 lines
--- tests/kms_display_modes.c | 161 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 161 insertions(+)tests/kms_display_modes.c index renamed from tests/kms_display_modes.c +0
-0
d69c7b931..e9b2b22bf100644tests/kms_display_modes.c +105
-1@@ -26,14 +26,107 @@#include "igt.h" +#define HDISPLAY_2K 2560 +#define VDISPLAY_2K 1440 + +#define HDISPLAY_4K 3840 +#define VDISPLAY_4K 2160 +IGT_TEST_DESCRIPTION ("Test Display Modes" );typedef struct {int drm_fd;igt_display_t display; +drmModeModeInfo mode_mst[2 ]; +igt_output_t *mst_output[2 ];int n_pipes; }data_t ; +/*Get higher mode supported by panel*/ +static drmModeModeInfo *get_highres_mode (igt_output_t *output) { +drmModeConnector *connector = output->config.connector; +drmModeModeInfo *highest_mode =NULL ; + +igt_sort_connector_modes (connector, sort_drm_modes_by_res_dsc); + highest_mode = &connector->modes[0 ]; + +return highest_mode; +} + +/*Get the 4k or less then 4k mode of connected panel*/ static +drmModeModeInfo *get_mode (igt_output_t *output) { +int j; +drmModeModeInfo *required_mode =NULL ; +drmModeConnector *connector = output->config.connector; + +igt_sort_connector_modes (connector, sort_drm_modes_by_res_dsc); +for (j =0 ; j < connector->count_modes; j++) { +if (connector->modes[j].vdisplay <=VDISPLAY_4K && + connector->modes[j].hdisplay <=HDISPLAY_4K ) { + required_mode = &connector->modes[j]; +break ; + } + } + +return required_mode; +} + +static int parse_path_blob (char *blob_data) { +int connector_id; +char *encoder; + + encoder =strtok (blob_data,":" ); + igt_assert_f(!strcmp(encoder, "mst"), "PATH connector property +expected to have 'mst'\n"); + + connector_id = atoi(strtok(NULL, "-")); + +return connector_id; +} + +static bool output_is_dp_mst (data_t *data,igt_output_t *output,int i) +{ +drmModePropertyBlobPtr path_blob =NULL ; +uint64_t path_blob_id; +drmModeConnector *connector = output->config.connector; +struct kmstest_connector_config config; +const char *encoder; +int connector_id; +static int prev_connector_id; + +kmstest_get_connector_config (data->drm_fd, output- >config.connector->connector_id, +-1 , &config); + encoder =kmstest_encoder_type_str (config.encoder->encoder_type); + +if (strcmp (encoder,"DP MST" )) +return false; + +igt_assert (kmstest_get_property (data->drm_fd, connector- >connector_id, +DRM_MODE_OBJECT_CONNECTOR ,"PATH" ,NULL , + &path_blob_id,NULL )); + +igt_assert (path_blob =drmModeGetPropertyBlob (data->drm_fd, +path_blob_id)); + + connector_id =parse_path_blob ((char *) path_blob->data); + +drmModeFreePropertyBlob (path_blob); + +/* +* Discarding outputs of other DP MST topology. +* Testing only on outputs on the topology we got previously +*/ +if (i ==0 ) { + prev_connector_id = connector_id; + }else { +if (connector_id != prev_connector_id) +return false; + } + +return true; +} + static void run_extendedmode_basic(data_t *data, enum pipe pipe1, igt_output_t *output1, enum pipe pipe2, igt_output_t *output2) @@ -173,8 +266,46 @@ static void run_extendedmode_test(data_t *data) { } } +static void run_extendedmode_negative (data_t *data,int pipe1,int +pipe2) { +struct igt_fb fbs[2 ]; +igt_display_t *display = &data->display; +igt_plane_t *plane[2 ]; +int ret; + +igt_display_reset (display); + +igt_output_set_pipe (data->mst_output[0 ], pipe1); +igt_output_set_pipe (data->mst_output[1 ], pipe2); + + igt_create_color_fb(data->drm_fd, data->mode_mst[0].hdisplay, data-Quoted 1 line
mode_mst[0].vdisplay,
tests/kms_display_modes.c +1
-0+ DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fbs[0]);tests/kms_display_modes.c +1
-0+ igt_create_color_fb(data->drm_fd, data->mode_mst[1].hdisplay, data-Quoted 1 line
mode_mst[1].vdisplay,
tests/kms_display_modes.c +1
-0+ DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR, 0, 0, 1, &fbs[1]);tests/kms_display_modes.c +2
-0+ + plane[0] = igt_pipe_get_plane_type(&display->pipes[pipe1],
DRM_PLANE_TYPE_PRIMARY);tests/kms_display_modes.c +5
-0+ plane[1 ] =igt_pipe_get_plane_type (&display->pipes[pipe2], +DRM_PLANE_TYPE_PRIMARY ); + +igt_plane_set_fb (plane[0 ], &fbs[0 ]); + igt_fb_set_size(&fbs[0], plane[0], data->mode_mst[0].hdisplay, data-Quoted 1 line
mode_mst[0].vdisplay);
tests/kms_display_modes.c +5
-0+igt_plane_set_size (plane[0 ], data->mode_mst[0 ].hdisplay, +data->mode_mst[0 ].vdisplay); + +igt_plane_set_fb (plane[1 ], &fbs[1 ]); + igt_fb_set_size(&fbs[1], plane[1], data->mode_mst[1].hdisplay, data-Quoted 1 line
mode_mst[1].vdisplay);
tests/kms_display_modes.c +4
-0+igt_plane_set_size (plane[1 ], data->mode_mst[1 ].hdisplay, +data->mode_mst[1 ].vdisplay); + + igt_output_override_mode(data->mst_output[0], &data-Quoted 1 line
mode_mst[0]);
tests/kms_display_modes.c +1
-0+ igt_output_override_mode(data->mst_output[1], &data-Quoted 1 line
mode_mst[1]);
tests/kms_display_modes.c +14
-0+ + ret =igt_display_try_commit2 (display,COMMIT_ATOMIC ); +igt_assert (ret !=0 && errno ==ENOSPC ); } + igt_main { +int dp_mst_outputs =0 , count =0 ; +enum pipe pipe1, pipe2; +igt_output_t *output;data_t data; igt_fixture {@@ -182,12 +313,42 @@ igt_mainkmstest_set_vt_graphics_mode ();igt_display_require (&data.display, data.drm_fd);igt_display_require_output (&data.display); + +for_each_connected_output (&data.display, output) { + data.mst_output[count++] = output; +if (output_is_dp_mst (&data, output, dp_mst_outputs)) + dp_mst_outputs++; + } } igt_describe("Test for validating display extended mode with a pair of connected displays"); igt_subtest_with_dynamic("extended-mode-basic" ) run_extendedmode_test(&data); + igt_describe("Negative test for validating display extended mode with apair of connected "
tests/kms_display_modes.c +3
-0+ "2k-4k or 4k-4k displays"); + igt_subtest_with_dynamic("mst-extended-mode-negative") { + igt_require_f(dp_mst_outputs > 1, "MST not found more thenone\n");
tests/kms_display_modes.c +2
-0+ + memcpy(&data.mode_mst[0], get_mode(data.mst_output[0]),sizeof(drmModeModeInfo));
tests/kms_display_modes.c +1
-0+ memcpy(&data.mode_mst[1],
get_highres_mode(data.mst_output[1]),tests/kms_display_modes.c +4
-0+ sizeof(drmModeModeInfo)); + + igt_require_f((data.mode_mst[1].hdisplay >= HDISPLAY_4K && + data.mode_mst[1].vdisplay >= VDISPLAY_4K), "4kpanel not
tests/kms_display_modes.c +8
-0+found\n"); + +for_each_pipe (&data.display, pipe1) { +for_each_pipe (&data.display, pipe2) { +if (pipe1 == pipe2) +continue ; + + igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe1),tests/kms_display_modes.c +2
-0+ kmstest_pipe_name(pipe2)) + run_extendedmode_negative(&data,pipe1, pipe2);
tests/kms_display_modes.c +4
-1+ } + } + } + igt_fixture {igt_display_fini (&data.display); } --2.25.1