Skip to contentSkip to conversation

dt-bindings: hwmon: Add binding for max6639

PATCH Superseded Naresh Solanki 2 participants 6 messages Apr 18, 2023 – Apr 19, 2023

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: hwmon: Add binding for max6639

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

---
 .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +55 -0
new file mode 100644
index 000000000000..20b28cd36555
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639 Dual fan controller
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      max6639@10 {
+        compatible = "maxim,max6639";
+        reg = <0x10>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+      };
+    };
+...

base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac

Signature · 1 line
2.39.1
#1 lore raw

PATCH 2/2 hwmon: (max6639) Add compatible string

Use maxim,max6639 as compatible string for the driver.

---
 drivers/hwmon/max6639.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/hwmon/max6639.c +6 -0
index 9b895402c80d..ada410bfb7b6 100644
@@ -618,11 +618,17 @@ MODULE_DEVICE_TABLE(i2c, max6639_id);
 
 static DEFINE_SIMPLE_DEV_PM_OPS(max6639_pm_ops, max6639_suspend, max6639_resume);
 
+static const struct of_device_id max6639_of_match[] = {
+	{ .compatible = "maxim,max6639", },
+	{ },
+};
+
 static struct i2c_driver max6639_driver = {
 	.class = I2C_CLASS_HWMON,
 	.driver = {
 		   .name = "max6639",
 		   .pm = pm_sleep_ptr(&max6639_pm_ops),
+		   .of_match_table = max6639_of_match,
 		   },
 	.probe_new = max6639_probe,
 	.id_table = max6639_id,
Signature · 1 line
2.39.1
#2 lore raw
In reply to Naresh Solanki
Quoted 2 lines · Naresh Solanki

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings.

Quoted 13 lines
---
 .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +0 -0
new file mode 100644
index 000000000000..20b28cd36555

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 4

Quoted 4 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +4 -0
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+

Drop blank line

This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed.

Best regards,
Krzysztof

#3 lore raw

Hi Krysztof,

Quoted 6 lines · Krzysztof Kozlowski
Quoted 2 lines · Naresh Solanki

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings.

Ack

Quoted 8 lines
Quoted 8 lines
---
  .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
  1 file changed, 55 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 12 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 4

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +4 -0
new file mode 100644
index 000000000000..20b28cd36555
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+

Drop blank line

Ack

Quoted 5 lines

This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed.

This patch is to add basic dt support only hence no additional properties.

Quoted 4 lines

Best regards,
Krzysztof

Regards,
Naresh

#4 lore raw
Quoted 30 lines · Naresh Solanki

Hi Krysztof,

Quoted 6 lines · Krzysztof Kozlowski
Quoted 2 lines · Naresh Solanki

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings.

Ack

Quoted 8 lines
Quoted 8 lines
---
  .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
  1 file changed, 55 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 12 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 4

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +4 -0
new file mode 100644
index 000000000000..20b28cd36555
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+

Drop blank line

Quoted 7 lines

Ack

Quoted 5 lines

This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed.

This patch is to add basic dt support only hence no additional properties.

How does that answer my questions?

Best regards,
Krzysztof

#5 lore raw

Hi

Quoted 33 lines · Krzysztof Kozlowski
Quoted 32 lines · Naresh Solanki

Hi Krysztof,

Quoted 6 lines · Krzysztof Kozlowski
Quoted 2 lines · Naresh Solanki

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings.

Ack

Quoted 8 lines
Quoted 8 lines
---
   .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
   1 file changed, 55 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 12 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 4

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +4 -0
new file mode 100644
index 000000000000..20b28cd36555
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+

Drop blank line

Ack

Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed.

This patch is to add basic dt support only hence no additional properties.

How does that answer my questions?

This patch is intended to add dt support for the max6639 driver, and I did not take it from previous patches. As this is a basic dt binding, it has fewer properties compared to the old one.

I have used v8 as a reference for this patch, and I will review it again to make sure I have not missed anything. Will ensure to fix them in the next patch.

Although I cannot go back to the previous patch, I will address and fix any issues in this patchset.

Quoted 4 lines

Best regards,
Krzysztof

Regards,
Naresh