Skip to contentSkip to conversation

A fix for StarFive JH7110 clock drivers

PATCH Applied Hal Feng 3 participants 5 messages Apr 18, 2023 – May 3, 2023

Subsystems (2)
lore
Share & tools
lore

Hal Feng

author
#0 lore raw

v2 cover A fix for StarFive JH7110 clock drivers

This series fix some issues of StarFive JH7110 sys and aon clock drivers.

The first patch fix two issues [1] [2] reported by kernel test robot.

The second patch is accepted in v1 so drop it in v2.

[1] https://lore.kernel.org/oe-kbuild-all/[email protected]/
[2] https://lore.kernel.org/oe-kbuild-all/[email protected]/

Changes since v1:
- Drop patch 2 since it is accepted.
- Change select RESET_STARFIVE_JH7110 if ARCH_STARFIVE to select RESET_STARFIVE_JH7110 if RESET_CONTROLLER.
- Change the commit message accordingly.

---
History:
v1: https://lore.kernel.org/all/[email protected]/

Hal Feng (1):
clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a
specified case

 drivers/clk/starfive/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.38.1
author
#1 lore raw

PATCH v2 1/1 clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case

When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS and CLK_STARFIVE_JH7110_AON.

Add a condition if RESET_CONTROLLER to fix it. Also, delete redundant selected options of CLK_STARFIVE_JH7110_AON because these options are already selected by the dependency.

Fixes edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
Fixes b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")
---
 drivers/clk/starfive/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/clk/starfive/Kconfig +1 -4
index 71c1148ee5f6..5d2333106f13 100644
@@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS
 	depends on ARCH_STARFIVE || COMPILE_TEST
 	select AUXILIARY_BUS
 	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
+	select RESET_STARFIVE_JH7110 if RESET_CONTROLLER
 	default ARCH_STARFIVE
 	help
 	  Say yes here to support the system clock controller on the
@@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS
 config CLK_STARFIVE_JH7110_AON
 	tristate "StarFive JH7110 always-on clock support"
 	depends on CLK_STARFIVE_JH7110_SYS
-	select AUXILIARY_BUS
-	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
 	default m if ARCH_STARFIVE
 	help
 	  Say yes here to support the always-on clock controller on the
Signature · 1 line
2.38.1
author
#2 lore raw

Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case

Quoted 11 lines · Hal Feng

When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS and CLK_STARFIVE_JH7110_AON.

Add a condition if RESET_CONTROLLER to fix it. Also, delete redundant selected options of CLK_STARFIVE_JH7110_AON because these options are already selected by the dependency.

Fixes edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
Fixes b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")

Hi, Stephen,

Could this patch be merged into v6.4? Thanks.

Best regards,
Hal

Quoted 27 lines
---
 drivers/clk/starfive/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/clk/starfive/Kconfig +1 -4
index 71c1148ee5f6..5d2333106f13 100644
@@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS
 	depends on ARCH_STARFIVE || COMPILE_TEST
 	select AUXILIARY_BUS
 	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
+	select RESET_STARFIVE_JH7110 if RESET_CONTROLLER
 	default ARCH_STARFIVE
 	help
 	  Say yes here to support the system clock controller on the
@@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS
 config CLK_STARFIVE_JH7110_AON
 	tristate "StarFive JH7110 always-on clock support"
 	depends on CLK_STARFIVE_JH7110_SYS
-	select AUXILIARY_BUS
-	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
 	default m if ARCH_STARFIVE
 	help
 	  Say yes here to support the always-on clock controller on the
Reviewed-by
#3 lore raw

Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case

Quoted 9 lines · Hal Feng
Quoted 8 lines · Hal Feng

When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS and CLK_STARFIVE_JH7110_AON.

Add a condition if RESET_CONTROLLER to fix it. Also, delete redundant selected options of CLK_STARFIVE_JH7110_AON because these options are already selected by the dependency.

Quoted 7 lines
Quoted 3 lines
Fixes edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
Fixes b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")

Hi, Stephen,

Could this patch be merged into v6.4? Thanks.

Whoops, I thought I had replied to this a week ago. In case it helps,

Thanks,
Conor.

Quoted 32 lines

Best regards,
Hal

Quoted 27 lines
---
 drivers/clk/starfive/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/clk/starfive/Kconfig +1 -4
index 71c1148ee5f6..5d2333106f13 100644
@@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS
 	depends on ARCH_STARFIVE || COMPILE_TEST
 	select AUXILIARY_BUS
 	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
+	select RESET_STARFIVE_JH7110 if RESET_CONTROLLER
 	default ARCH_STARFIVE
 	help
 	  Say yes here to support the system clock controller on the
@@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS
 config CLK_STARFIVE_JH7110_AON
 	tristate "StarFive JH7110 always-on clock support"
 	depends on CLK_STARFIVE_JH7110_SYS
-	select AUXILIARY_BUS
-	select CLK_STARFIVE_JH71X0
-	select RESET_STARFIVE_JH7110
 	default m if ARCH_STARFIVE
 	help
 	  Say yes here to support the always-on clock controller on the
maintainer Applied
#4 lore raw

Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case

In reply to Hal Feng

Quoting Hal Feng (2023-04-18 05:37:56)

Quoted 4 lines

When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS and CLK_STARFIVE_JH7110_AON.

Quoted 8 lines

Add a condition if RESET_CONTROLLER to fix it. Also, delete redundant selected options of CLK_STARFIVE_JH7110_AON because these options are already selected by the dependency.

Fixes edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
Fixes b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")

---

Applied to clk-next