Skip to contentSkip to conversation

tests: do not include t_client.sh in dist

PATCH In review Frank Lichtenheld 2 participants 2 messages Apr 18, 2023 – May 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests: do not include t_client.sh in dist

It is generated from t_client.sh.in by configure, so no need to ship it. Due to the dependency on the configuration it also might break reproducibility of the dist tarball.

---
 tests/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/Makefile.am +3 -1
index a46f2573..80673d56 100644
@@ -25,8 +25,10 @@ TESTS_ENVIRONMENT = top_srcdir="$(top_srcdir)"
 TESTS = $(test_scripts)
 
 dist_noinst_SCRIPTS = \
-	$(test_scripts) \
+	t_cltsrv.sh \
 	t_cltsrv-down.sh \
+	t_lpback.sh \
+	t_net.sh \
 	update_t_client_ips.sh
 
 dist_noinst_DATA = \
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw

t_client.sh is built according to configure findings for @SHELL etc., so no good packing it.

Verified that the tarball before/after only differs in "t_client.sh", that "distcheck" still passes, and that "make check" on the resulting tarball builds & runs a t_client.sh as expected.

Your patch has been applied to the master and release/2.6 branch.

commit d75a2dfc3e11daa1650f838517b610e6632d0445 (master) commit 477e7f5e91bfc66214c8d5466b24a424e2b401f4 (release/2.6)

Author: Frank Lichtenheld
Date:   Tue Apr 18 15:49:41 2023 +0200
     tests: do not include t_client.sh in dist

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg26596.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering