Skip to contentSkip to conversation

f2fs: allocate node blocks for atomic write block replacement

PATCH In review Daeho Jeong 2 participants 2 messages Apr 18, 2023 – Apr 21, 2023 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: allocate node blocks for atomic write block replacement

From: Daeho Jeong <[email protected]>

When a node block is missing for atomic write block replacement, we need to allocate it in advance of the replacement.

---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/segment.c +1 -1
index c35476b3c075..0e1e29800934 100644
@@ -217,7 +217,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index,
 
 retry:
 	set_new_dnode(&dn, inode, NULL, NULL, 0);
-	err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE_RA);
+	err = f2fs_get_dnode_of_data(&dn, index, ALLOC_NODE);
 	if (err) {
 		if (err == -ENOMEM) {
 			f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
Signature · 8 lines
2.40.0.634.g4ca3ef3211-goog



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
maintainer
#1 lore raw
Quoted 4 lines · Daeho Jeong

From: Daeho Jeong <[email protected]>

When a node block is missing for atomic write block replacement, we need to allocate it in advance of the replacement.

Miss a fixes line?

Otherwise it looks good to me.

Thanks,

Quoted 19 lines
---
  fs/f2fs/segment.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/segment.c +1 -1
index c35476b3c075..0e1e29800934 100644
@@ -217,7 +217,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index,
 
  retry:
  	set_new_dnode(&dn, inode, NULL, NULL, 0);
-	err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE_RA);
+	err = f2fs_get_dnode_of_data(&dn, index, ALLOC_NODE);
  	if (err) {
  		if (err == -ENOMEM) {
  			f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);