drm/radeon: Fix integer overflow in radeon_cs_parser_init
Subsystems (3)
PATCH v2 1/2 drm/radeon: Fix integer overflow in radeon_cs_parser_init
The type of size is unsigned, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later
Signed-off-by hackyzh002 <[email protected]>
--- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_cs.c +1 -1
@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data) {struct drm_radeon_cs *cs = data;uint64_t *chunk_array_ptr; -unsigned size, i; +u64 size, i;u32 ring =RADEON_CS_RING_GFX ;s32 priority =0 ;
Signature · 1 line
2.34.1
Christian König
maintainerAm 19.04.23 um 10:57 schrieb hackyzh002:
Quoted 14 lines
The type of size is unsigned, if size is
0x40000000, there will be an integer overflow, size will be zero after size *=sizeof(uint32_t), will cause uninitialized memory to be referenced laterSigned-off-by hackyzh002 <[email protected]>--- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/radeon_cs.c +0
-0
drivers/gpu/drm/radeon/radeon_cs.c int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data) · line 273
Quoted 5 lines
drivers/gpu/drm/radeon/radeon_cs.c +1
-1@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data) {struct drm_radeon_cs *cs = data;uint64_t *chunk_array_ptr; -unsigned size, i; +u64 size, i;
Ok, once more: Please only change the type of the "size" variable" and not the type of "i".
Otherwise the patch looks good to me,
Christian.
Quoted 3 lines
drivers/gpu/drm/radeon/radeon_cs.c +0
-0u32 ring =RADEON_CS_RING_GFX ;s32 priority =0 ;