Skip to contentSkip to conversation

ASoC: nau8825: fix delay time range check

PATCH In review Arnd Bergmann 3 participants 3 messages Apr 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: nau8825: fix delay time range check

From: Arnd Bergmann <[email protected]>

clang points out that the recently added range check is nonsensical:

sound/soc/codecs/nau8825.c:2826:31: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare]

        if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500)
            ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

The DT binding document confirms that the intention is to warn if it's outside of the 125..500 range, so do that instead.

Fixes fc0b096c9291 ("ASoC: nau8825: Add delay control for input path")
---
 sound/soc/codecs/nau8825.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/nau8825.c +1 -1
index c4389f5fe603..f4eb999761a4 100644
@@ -2823,7 +2823,7 @@ static int nau8825_read_device_properties(struct device *dev,
 	ret = device_property_read_u32(dev, "nuvoton,adc-delay-ms", &nau8825->adc_delay);
 	if (ret)
 		nau8825->adc_delay = 125;
-	if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500)
+	if (nau8825->adc_delay < 125 || nau8825->adc_delay > 500)
 		dev_warn(dev, "Please set the suitable delay time!\n");
 
 	nau8825->mclk = devm_clk_get(dev, "mclk");
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 3 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

clang points out that the recently added range check is nonsensical:

Someone already sent a patch for tihs.

#2 lore raw
Quoted 6 lines · Mark Brown
Quoted 3 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

clang points out that the recently added range check is nonsensical:

Someone already sent a patch for tihs.

FTR: https://lore.kernel.org/r/[email protected]

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |