Skip to contentSkip to conversation

drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

PATCH Applied hackyzh002 2 participants 5 messages Apr 19, 2023 – Apr 28, 2023

Subsystems (3)
lore
Share & tools
lore

hackyzh002

author
#0 lore raw

PATCH v3 2/2 drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

The type of size is unsigned int, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -1
index 08eced097..89bcacc65 100644
@@ -192,7 +192,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
 	uint64_t *chunk_array_user;
 	uint64_t *chunk_array;
 	uint32_t uf_offset = 0;
-	unsigned int size;
+	size_t size;
 	int ret;
 	int i;
 
Signature · 1 line
2.34.1
#1 lore raw

hello
What is the current status of this patch, has it been applied?

Quoted 26 lines · hackyzh002 <[email protected]> 于2023年4月19日周三 20:23写道:

The type of size is unsigned int, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -2
index 08eced097..89bcacc65 100644
@@ -192,7 +192,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
        uint64_t *chunk_array_user;
        uint64_t *chunk_array;
        uint32_t uf_offset = 0;
-       unsigned int size;
+       size_t size;
        int ret;
        int i;
 
--

2.34.1

#2 lore raw

As per my prior reply, it has been applied.

Thanks,

Alex

Quoted 32 lines · On Thu, Apr 27, 2023 at 8:39 AM whitehat002 whitehat002 <[email protected]>…

hello
What is the current status of this patch, has it been applied?

Quoted 26 lines · hackyzh002 <[email protected]> 于2023年4月19日周三 20:23写道:

The type of size is unsigned int, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -2
index 08eced097..89bcacc65 100644
@@ -192,7 +192,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
        uint64_t *chunk_array_user;
        uint64_t *chunk_array;
        uint32_t uf_offset = 0;
-       unsigned int size;
+       size_t size;
        int ret;
        int i;
 
--

2.34.1

#3 lore raw

Alex,I have a question, why I don't see it on the
https://patchwork.freedesktop.org/

Quoted 41 lines · Alex Deucher <[email protected]> 于2023年4月27日周四 20:40写道:

As per my prior reply, it has been applied.

Thanks,

Alex

Quoted 32 lines · On Thu, Apr 27, 2023 at 8:39 AM whitehat002 whitehat002 <[email protected]>…

hello
What is the current status of this patch, has it been applied?

Quoted 26 lines · hackyzh002 <[email protected]> 于2023年4月19日周三 20:23写道:

The type of size is unsigned int, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -2
index 08eced097..89bcacc65 100644
@@ -192,7 +192,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
        uint64_t *chunk_array_user;
        uint64_t *chunk_array;
        uint32_t uf_offset = 0;
-       unsigned int size;
+       size_t size;
        int ret;
        int i;
 
--

2.34.1

#4 lore raw

these?
https://patchwork.freedesktop.org/series/116699/
https://patchwork.freedesktop.org/series/116695/

Quoted 46 lines · On Thu, Apr 27, 2023 at 8:45 PM whitehat002 whitehat002 <[email protected]>…

Alex,I have a question, why I don't see it on the
https://patchwork.freedesktop.org/

Quoted 41 lines · Alex Deucher <[email protected]> 于2023年4月27日周四 20:40写道:

As per my prior reply, it has been applied.

Thanks,

Alex

Quoted 32 lines · On Thu, Apr 27, 2023 at 8:39 AM whitehat002 whitehat002 <[email protected]>…

hello
What is the current status of this patch, has it been applied?

Quoted 26 lines · hackyzh002 <[email protected]> 于2023年4月19日周三 20:23写道:

The type of size is unsigned int, if size is 0x40000000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -2
index 08eced097..89bcacc65 100644
@@ -192,7 +192,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
        uint64_t *chunk_array_user;
        uint64_t *chunk_array;
        uint32_t uf_offset = 0;
-       unsigned int size;
+       size_t size;
        int ret;
        int i;
 
--

2.34.1