tty: serial: simplify qcom_geni_serial_send_chunk_fifo()
Subsystems (2)
Jiri Slaby (SUSE)
maintainerPATCH 1/1 tty: serial: simplify qcom_geni_serial_send_chunk_fifo()
* use memcpy() instead of the loop (removes c variable)
* use remaining parameter directly (removes chunk variable)
The code is simpler and easier to follow.
Signed-off-by Jiri Slaby (SUSE) <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Konrad Dybcio <[email protected]>
--- drivers/tty/serial/qcom_geni_serial.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/tty/serial/qcom_geni_serial.c +4 -6
@@ -854,21 +854,19 @@ static void qcom_geni_serial_stop_tx(struct uart_port *uport) }static void qcom_geni_serial_send_chunk_fifo (struct uart_port *uport, -unsigned int chunk) +unsigned int remaining) {struct qcom_geni_serial_port *port =to_dev_port (uport);struct circ_buf *xmit = &uport->state->xmit; -unsigned int tx_bytes, c, remaining = chunk; +unsigned int tx_bytes;u8 buf[BYTES_PER_FIFO_WORD ];while (remaining) {memset (buf,0 ,sizeof (buf)); tx_bytes =min (remaining,BYTES_PER_FIFO_WORD ); -for (c =0 ; c < tx_bytes ; c++) { - buf[c] = xmit->buf[xmit->tail]; -uart_xmit_advance (uport,1 ); - } +memcpy (buf, &xmit->buf[xmit->tail], tx_bytes); +uart_xmit_advance (uport, tx_bytes);iowrite32_rep (uport->membase + SE_GENI_TX_FIFOn, buf,1 );
Signature · 1 line
2.40.0