Skip to contentSkip to conversation

configs: rockchip: rock-3a: make usb host work

PATCH Superseded FUKAUMI Naoki 3 participants 14 messages Apr 20, 2023 – Apr 21, 2023 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 configs: rockchip: rock-3a: make usb host work

add support for USB host function on ROCK 3A

---
 configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configs/rock-3a-rk3568_defconfig +12 -0
index e753832183..d24563a504 100644
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550_MEM32=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y
 # CONFIG_BINMAN_FDT is not set
 CONFIG_ERRNO_STR=y
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/3 configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator

enable commands for i2c/pmic/regulator and relevant configs. also drop configs for unused regulators.

---
 configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
 configs/rock-3a-rk3568_defconfig      | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)
configs/radxa-cm3-io-rk3566_defconfig +6 -2
index 2100cf2cb2..9b99181714 100644
@@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_ATF=y
 CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIVE=y
@@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
 CONFIG_PHY_ROCKCHIP_INNO_USB2=y
 CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
-CONFIG_REGULATOR_PWM=y
-CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_SPL_RAM=y
 CONFIG_BAUDRATE=1500000
configs/rock-3a-rk3568_defconfig +2 -1
index d24563a504..c03aa2a4c1 100644
@@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIVE=y
@@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_SPL_PMIC_RK8XX=y
-CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_SPL_RAM=y
Signature · 1 line
2.39.2
#3 lore raw

PATCH 3/3 arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

In reply to FUKAUMI Naoki

enable regulators for usb host function

---
 arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
 arch/arm/dts/rk3568-rock-3a-u-boot.dtsi      | 8 ++++++++
 2 files changed, 12 insertions(+)
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi +4 -0
index 4e79173833..d183e93575 100644
@@ -16,3 +16,7 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb30 {
+	regulator-boot-on;
+};
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi +8 -0
index 9ef1e84770..b7b18e131a 100644
@@ -26,3 +26,11 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb_host {
+	regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+	regulator-boot-on;
+};
Signature · 1 line
2.39.2
Reviewed-by on v1 1/3
#6 lore raw
In reply to FUKAUMI Naoki
Quoted 3 lines · FUKAUMI Naoki

add support for USB host function on ROCK 3A

Thanks,
- Kever

Quoted 40 lines
---
  configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
  1 file changed, 12 insertions(+)
configs/rock-3a-rk3568_defconfig +12 -0
index e753832183..d24563a504 100644
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
  # CONFIG_SPL_DOS_PARTITION is not set
  CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
  CONFIG_MMC_SDHCI_ROCKCHIP=y
  CONFIG_ETH_DESIGNWARE=y
  CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
  CONFIG_DM_PMIC=y
  CONFIG_PMIC_RK8XX=y
  CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_SYS_NS16550_MEM32=y
  CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y
  # CONFIG_BINMAN_FDT is not set
  CONFIG_ERRNO_STR=y
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator

In reply to FUKAUMI Naoki
Quoted 4 lines · FUKAUMI Naoki

enable commands for i2c/pmic/regulator and relevant configs. also drop configs for unused regulators.

Thanks,
- Kever

Quoted 55 lines
---
  configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
  configs/rock-3a-rk3568_defconfig      | 3 ++-
  2 files changed, 8 insertions(+), 3 deletions(-)
configs/radxa-cm3-io-rk3566_defconfig +6 -2
index 2100cf2cb2..9b99181714 100644
@@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
  CONFIG_SPL_STACK_R=y
  CONFIG_SPL_ATF=y
  CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
  # CONFIG_SPL_DOS_PARTITION is not set
  CONFIG_SPL_OF_CONTROL=y
  CONFIG_OF_LIVE=y
@@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
  CONFIG_GMAC_ROCKCHIP=y
  CONFIG_PHY_ROCKCHIP_INNO_USB2=y
  CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
-CONFIG_REGULATOR_PWM=y
-CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
  CONFIG_PWM_ROCKCHIP=y
  CONFIG_SPL_RAM=y
  CONFIG_BAUDRATE=1500000
configs/rock-3a-rk3568_defconfig +2 -1
index d24563a504..c03aa2a4c1 100644
@@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
  # CONFIG_SPL_DOS_PARTITION is not set
  CONFIG_SPL_OF_CONTROL=y
  CONFIG_OF_LIVE=y
@@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
  CONFIG_DM_PMIC=y
  CONFIG_PMIC_RK8XX=y
  CONFIG_SPL_PMIC_RK8XX=y
-CONFIG_REGULATOR_PWM=y
  CONFIG_REGULATOR_RK8XX=y
  CONFIG_PWM_ROCKCHIP=y
  CONFIG_SPL_RAM=y
Reviewed-by on v1 3/3
#4 lore raw

Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

In reply to FUKAUMI Naoki
Quoted 3 lines · FUKAUMI Naoki

enable regulators for usb host function

Thanks,
- Kever

Quoted 33 lines
---
  arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
  arch/arm/dts/rk3568-rock-3a-u-boot.dtsi      | 8 ++++++++
  2 files changed, 12 insertions(+)
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi +4 -0
index 4e79173833..d183e93575 100644
@@ -16,3 +16,7 @@
  	bootph-all;
  	status = "okay";
  };
+
+&vcc5v0_usb30 {
+	regulator-boot-on;
+};
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi +8 -0
index 9ef1e84770..b7b18e131a 100644
@@ -26,3 +26,11 @@
  	bootph-all;
  	status = "okay";
  };
+
+&vcc5v0_usb_host {
+	regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+	regulator-boot-on;
+};
#7 lore raw
In reply to FUKAUMI Naoki
Quoted 31 lines · FUKAUMI Naoki

add support for USB host function on ROCK 3A

---
 configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configs/rock-3a-rk3568_defconfig +3 -0
index e753832183..d24563a504 100644
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550_MEM32=y

configs/rock-3a-rk3568_defconfig CONFIG_BAUDRATE=1500000 · line 83

Quoted 10 lines
configs/rock-3a-rk3568_defconfig +9 -0
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y

The generic dwc3 driver is not used by rk35xx and does not need to be enabled.

Regards,
Jonas

Quoted 2 lines
configs/rock-3a-rk3568_defconfig +0 -0
 # CONFIG_BINMAN_FDT is not set
 CONFIG_ERRNO_STR=y
#5 lore raw

Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

In reply to FUKAUMI Naoki
Quoted 1 line · FUKAUMI Naoki

enable regulators for usb host function

This is not needed once [1] and related pending patches lands.

Will adjust my pending usb+spinor series at [2], on top of your series before sending it :-)

[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
[2] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3568-usb-spi-v1

Regards,
Jonas

Quoted 35 lines
---
 arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
 arch/arm/dts/rk3568-rock-3a-u-boot.dtsi      | 8 ++++++++
 2 files changed, 12 insertions(+)
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi +4 -0
index 4e79173833..d183e93575 100644
@@ -16,3 +16,7 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb30 {
+	regulator-boot-on;
+};
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi +8 -0
index 9ef1e84770..b7b18e131a 100644
@@ -26,3 +26,11 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb_host {
+	regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+	regulator-boot-on;
+};
#8 lore raw

PATCH v2 1/4 configs: rockchip: rock-3a: make usb host work

In reply to FUKAUMI Naoki

add support for USB host function on ROCK 3A

---
v2:
- drop CONFIG_USB_DWC3_GENERIC

 configs/rock-3a-rk3568_defconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
configs/rock-3a-rk3568_defconfig +11 -0
index e753832183..16a8b6092c 100644
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,13 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550_MEM32=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
 # CONFIG_BINMAN_FDT is not set
 CONFIG_ERRNO_STR=y
Signature · 1 line
2.39.2
#9 lore raw

PATCH v2 2/4 configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator

enable commands for i2c/pmic/regulator and relevant configs. also drop configs for unused regulators.

---
v2:
- collect R-b

 configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
 configs/rock-3a-rk3568_defconfig      | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)
configs/radxa-cm3-io-rk3566_defconfig +6 -2
index 2100cf2cb2..9b99181714 100644
@@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_ATF=y
 CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIVE=y
@@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
 CONFIG_PHY_ROCKCHIP_INNO_USB2=y
 CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
-CONFIG_REGULATOR_PWM=y
-CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_SPL_RAM=y
 CONFIG_BAUDRATE=1500000
configs/rock-3a-rk3568_defconfig +2 -1
index 16a8b6092c..92562026a7 100644
@@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
 # CONFIG_SPL_DOS_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIVE=y
@@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_SPL_PMIC_RK8XX=y
-CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_SPL_RAM=y
Signature · 1 line
2.39.2
#10 lore raw

PATCH v2 3/4 arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

In reply to FUKAUMI Naoki

enable regulators for usb host function

---
v2:
- collect R-b

 arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
 arch/arm/dts/rk3568-rock-3a-u-boot.dtsi      | 8 ++++++++
 2 files changed, 12 insertions(+)
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi +4 -0
index 4e79173833..d183e93575 100644
@@ -16,3 +16,7 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb30 {
+	regulator-boot-on;
+};
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi +8 -0
index 9ef1e84770..b7b18e131a 100644
@@ -26,3 +26,11 @@
 	bootph-all;
 	status = "okay";
 };
+
+&vcc5v0_usb_host {
+	regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+	regulator-boot-on;
+};
Signature · 1 line
2.39.2
#11 lore raw

PATCH v2 4/4 configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC

In reply to FUKAUMI Naoki

it's not used by rk35xx

---
v2:
- new patch

 configs/radxa-cm3-io-rk3566_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/radxa-cm3-io-rk3566_defconfig +0 -1
index 9b99181714..1df9cab79d 100644
@@ -77,5 +77,4 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
-CONFIG_USB_DWC3_GENERIC=y
 CONFIG_ERRNO_STR=y
Signature · 1 line
2.39.2
Reviewed-by on v2 1/4
#13 lore raw
In reply to FUKAUMI Naoki
Quoted 3 lines · FUKAUMI Naoki

add support for USB host function on ROCK 3A

Thanks,
- Kever

Quoted 42 lines

---
v2:
- drop CONFIG_USB_DWC3_GENERIC

  configs/rock-3a-rk3568_defconfig | 11 +++++++++++
  1 file changed, 11 insertions(+)
configs/rock-3a-rk3568_defconfig +11 -0
index e753832183..16a8b6092c 100644
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
  # CONFIG_SPL_DOS_PARTITION is not set
  CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
  CONFIG_MMC_SDHCI_ROCKCHIP=y
  CONFIG_ETH_DESIGNWARE=y
  CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
  CONFIG_DM_PMIC=y
  CONFIG_PMIC_RK8XX=y
  CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,13 @@ CONFIG_BAUDRATE=1500000
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_SYS_NS16550_MEM32=y
  CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
  # CONFIG_BINMAN_FDT is not set
  CONFIG_ERRNO_STR=y
Reviewed-by on v2 4/4
#12 lore raw

Re: [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC

In reply to FUKAUMI Naoki
Quoted 3 lines · FUKAUMI Naoki

it's not used by rk35xx

Thanks,
- Kever

Quoted 17 lines

---
v2:
- new patch

  configs/radxa-cm3-io-rk3566_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/radxa-cm3-io-rk3566_defconfig +0 -1
index 9b99181714..1df9cab79d 100644
@@ -77,5 +77,4 @@ CONFIG_USB_XHCI_DWC3=y
  CONFIG_USB_EHCI_HCD=y
  CONFIG_USB_EHCI_GENERIC=y
  CONFIG_USB_DWC3=y
-CONFIG_USB_DWC3_GENERIC=y
  CONFIG_ERRNO_STR=y