Skip to contentSkip to conversation

arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator

PATCH In review FUKAUMI Naoki 2 participants 3 messages Apr 20, 2023 – Apr 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator

"gpios" should be "gpio"

Fixes 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
---
 arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +1 -1
index 63c4bd873188..bde43c4a5bb1 100644
@@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
 	vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
-		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pcie_enable_h>;
 		regulator-name = "vcc3v3_pcie";
Signature · 7 lines
2.39.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer
#1 lore raw

Hi,

Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:

Quoted 1 line

"gpios" should be "gpio"

I don't see this.

The fixed-regulator binding does specify both "gpios" and "gpio" as valid. And the code also tries both [0].

So this change really isn't necessary.

Heiko

[0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86

Quoted 12 lines
Fixes 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
---
 arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +0 -0
index 63c4bd873188..bde43c4a5bb1 100644

arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator { · line 95

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +1 -1
@@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
 	vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
-		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pcie_enable_h>;
 		regulator-name = "vcc3v3_pcie";

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#2 lore raw

hi,

Quoted 11 lines · Heiko Stuebner

Hi,

Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:

Quoted 1 line

"gpios" should be "gpio"

I don't see this.

The fixed-regulator binding does specify both "gpios" and "gpio" as valid. And the code also tries both [0].

So this change really isn't necessary.

I see. it seems I referred old document... sorry for bothering you.

--
FUKAUMI Naoki

Quoted 10 lines

Heiko

[0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86

Quoted 6 lines
Fixes 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
---
  arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 19 lines
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +0 -0
index 63c4bd873188..bde43c4a5bb1 100644

arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator { · line 95

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +1 -1
@@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
  	vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
  		compatible = "regulator-fixed";
  		enable-active-high;
-		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
  		pinctrl-names = "default";
  		pinctrl-0 = <&pcie_enable_h>;
  		regulator-name = "vcc3v3_pcie";

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip