drm/ast: Fix ARM compatibility
Subsystems (3)
PATCH v3 1/1 drm/ast: Fix ARM compatibility
ARM architecture only has 'memory', so all devices are accessed by MMIO if possible.
Signed-off-by Jammy Huang <[email protected]>
Reviewed-by Thomas Zimmermann <[email protected]>
---
v2 changes:
- Use MMIO after AST2500 which enable MMIO by default.
v3 changes:
- Correct comments
--- drivers/gpu/drm/ast/ast_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/ast/ast_main.c +5 -4
@@ -425,11 +425,12 @@ struct ast_private *ast_device_create(const struct drm_driver *drv,return ERR_PTR (-EIO );/* -* If we don't have IO space at all, use MMIO now and -* assume the chip has MMIO enabled by default (rev 0x20 -* and higher). +* After AST2500, MMIO is enabled by default, and it should be adopted +* to be compatible with Arm. */ -if (!(pci_resource_flags (pdev,2 ) &IORESOURCE_IO )) { +if (pdev->revision >=0x40 ) { + ast->ioregs = ast->regs +AST_IO_MM_OFFSET ; + }else if (!(pci_resource_flags (pdev,2 ) &IORESOURCE_IO )) {drm_info (dev,"platform has no IO space, trying MMIO\n" ); ast->ioregs = ast->regs +AST_IO_MM_OFFSET ; }
base-commit: e62252bc55b6d4eddc6c2bdbf95a448180d6a08d
Signature · 1 line
2.25.1
Hi
Am 21.04.23 um 02:33 schrieb Jammy Huang:
Quoted 2 lines
ARM architecture only has 'memory', so all devices are accessed by MMIO if possible.
Merged into drm-misc-fixes. Thanks for the patch.
Best regards
Thomas
Quoted 35 lines
Signed-off-by Jammy Huang <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>---
v2 changes:
- Use MMIO after AST2500 which enable MMIO by default.
v3 changes:
- Correct comments--- drivers/gpu/drm/ast/ast_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)drivers/gpu/drm/ast/ast_main.c +5
-4@@ -425,11 +425,12 @@ struct ast_private *ast_device_create(const struct drm_driver *drv,return ERR_PTR (-EIO );/* -* If we don't have IO space at all, use MMIO now and -* assume the chip has MMIO enabled by default (rev 0x20 -* and higher). +* After AST2500, MMIO is enabled by default, and it should be adopted +* to be compatible with Arm. */ -if (!(pci_resource_flags (pdev,2 ) &IORESOURCE_IO )) { +if (pdev->revision >=0x40 ) { + ast->ioregs = ast->regs +AST_IO_MM_OFFSET ; + }else if (!(pci_resource_flags (pdev,2 ) &IORESOURCE_IO )) {drm_info (dev,"platform has no IO space, trying MMIO\n" ); ast->ioregs = ast->regs +AST_IO_MM_OFFSET ; }base-commit:
e62252bc55b6d4eddc6c2bdbf95a448180d6a08d
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)