Skip to contentSkip to conversation

migrate_pages_batch-fix-statistics-for-longterm-pin-retry.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Apr 21, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: migrate_pages_batch: fix statistics for longterm pin retry
has been removed from the -mm tree. Its filename was
migrate_pages_batch-fix-statistics-for-longterm-pin-retry.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Huang Ying <[email protected]>
Subject: migrate_pages_batch: fix statistics for longterm pin retry
Date: Mon, 17 Apr 2023 07:59:29 +0800

In commit fd4a7ac32918 ("mm: migrate: try again if THP split is failed due to page refcnt"), if the THP splitting fails due to page reference count, we will retry to improve migration successful rate. But the failed splitting is counted as migration failure and migration retry, which will cause duplicated failure counting. So, in this patch, this is fixed via undoing the failure counting if we decide to retry. The patch is tested via failure injection.

Fixes fd4a7ac32918 ("mm: migrate: try again if THP split is failed due to page refcnt")
Cc Alistair Popple <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Yang Shi <[email protected]>
Cc Zi Yan <[email protected]>

---

 mm/migrate.c |    3 +++
 1 file changed, 3 insertions(+)
mm/migrate.c renamed from mm/migrate.c~migrate_pages_batch-fix-statistics-for-longterm-pin-retry +3 -0
@@ -1710,6 +1710,9 @@ static int migrate_pages_batch(struct li
 							large_retry++;
 							thp_retry += is_thp;
 							nr_retry_pages += nr_pages;
+							/* Undo duplicated failure counting. */
+							nr_large_failed--;
+							stats->nr_thp_failed -= is_thp;
 							break;
 						}
 					}

_

Patches currently in -mm which might be from [email protected] are

mmunmap-avoid-flushing-tlb-in-batch-if-pte-is-inaccessible.patch