Skip to contentSkip to conversation

mm-shrinkers-fix-debugfs-file-permissions.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Apr 21, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: shrinkers: fix debugfs file permissions
has been removed from the -mm tree. Its filename was
mm-shrinkers-fix-debugfs-file-permissions.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: John Keeping <[email protected]>
Subject: mm: shrinkers: fix debugfs file permissions
Date: Tue, 18 Apr 2023 11:19:05 +0100

The permissions for the files here are swapped as "count" is read-only and "scan" is write-only. While this doesn't really matter as these permissions don't stop the files being opened for reading/writing as appropriate, they are shown by "ls -l" and are confusing.

---

 mm/shrinker_debug.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/shrinker_debug.c renamed from mm/shrinker_debug.c~mm-shrinkers-fix-debugfs-file-permissions +2 -2
@@ -189,9 +189,9 @@ int shrinker_debugfs_add(struct shrinker
 	}
 	shrinker->debugfs_entry = entry;
 
-	debugfs_create_file("count", 0220, entry, shrinker,
+	debugfs_create_file("count", 0440, entry, shrinker,
 			    &shrinker_debugfs_count_fops);
-	debugfs_create_file("scan", 0440, entry, shrinker,
+	debugfs_create_file("scan", 0220, entry, shrinker,
 			    &shrinker_debugfs_scan_fops);
 	return 0;
 }

_

Patches currently in -mm which might be from [email protected] are