Skip to contentSkip to conversation

rhashtable-test: Make use of rhashtable_walk_peek

PATCH In review Cai Huoqing 2 participants 2 messages Apr 25, 2023 – May 3, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rhashtable-test: Make use of rhashtable_walk_peek

Add an example usage of rhashtable_walk_peek to test_bucket_stats.

---
 lib/test_rhashtable.c | 8 ++++++++
 1 file changed, 8 insertions(+)
lib/test_rhashtable.c +8 -0
index c20f6cb4bf55..b1c3316b9bde 100644
@@ -177,6 +177,7 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
 	unsigned int total = 0, chain_len = 0;
 	struct rhashtable_iter hti;
 	struct rhash_head *pos;
+	struct test_obj *obj;
 
 	rhashtable_walk_enter(ht, &hti);
 	rhashtable_walk_start(&hti);
@@ -192,6 +193,13 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
 			break;
 		}
 
+		/* Here's an example usage of rhashtable_walk_peek */
+		obj = rhashtable_walk_peek(&hti);
+		if (!obj) {
+			pr_warn("Test failed: rhashtable_walk_peek() error\n");
+			break;
+		}
+
 		total++;
 	}
 
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 6 lines · Cai Huoqing

Add an example usage of rhashtable_walk_peek to test_bucket_stats.

---
 lib/test_rhashtable.c | 8 ++++++++
 1 file changed, 8 insertions(+)

This is supposed to be testing rhashtable code, it's not meant to be an example of how to use the API.

lib/test_rhashtable.c static void test_bucket_stats(struct rhashtable *ht, unsigned int entries) · line 202

Quoted 11 lines
lib/test_rhashtable.c +7 -0
@@ -192,6 +193,13 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
 			break;
 		}
 
+		/* Here's an example usage of rhashtable_walk_peek */
+		obj = rhashtable_walk_peek(&hti);
+		if (!obj) {
+			pr_warn("Test failed: rhashtable_walk_peek() error\n");
+			break;
+		}
+

What is this meant to test?

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt