Skip to contentSkip to conversation

package/libcurl: remove OpenSSL LD_LIBRARY_PATH override

PATCH In review Tom Wambold 2 participants 2 messages Apr 26, 2023 – May 1, 2023

lore
Share & tools
lore

Tom Wambold

author
#0 lore raw

PATCH 1/1 package/libcurl: remove OpenSSL LD_LIBRARY_PATH override

I believe this is no longer necessary since commit 2d4c215 [0] in curl (released in curl 7.60.0). This appears to cause problems when building on Arch Linux at least, as noted in bug 15181 [1]. Just removing this entirely resolves this.

This effectively reverts a51ce319492 and 71b1d397266.

[0]: https://github.com/curl/curl/commit/2d4c2152c9eb3dbdf943de46ed8fc11285f1b90b
[1]: https://bugs.buildroot.org/show_bug.cgi?id=15181

Signed-off-by Tom Wambold <[email protected]>
---
 package/libcurl/libcurl.mk | 5 -----
 1 file changed, 5 deletions(-)
package/libcurl/libcurl.mk +0 -5
index 1a1594a45e..dd715c1bb6 100644
@@ -56,11 +56,6 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBCURL_OPENSSL),y)
 LIBCURL_DEPENDENCIES += openssl
-# configure adds the cross openssl dir to LD_LIBRARY_PATH which screws up
-# native stuff during the rest of configure when target == host.
-# Fix it by setting LD_LIBRARY_PATH to something sensible so those libs
-# are found first.
-LIBCURL_CONF_ENV += LD_LIBRARY_PATH=$(if $(LD_LIBRARY_PATH),$(LD_LIBRARY_PATH):)/lib:/usr/lib
 LIBCURL_CONF_OPTS += --with-openssl=$(STAGING_DIR)/usr \
 	--with-ca-path=/etc/ssl/certs
 else
Signature · 6 lines
2.40.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Tom, All,

On 2023-04-26 12:39 -0400, Tom Wambold spake thusly:

Quoted 11 lines

I believe this is no longer necessary since commit 2d4c215 [0] in curl (released in curl 7.60.0). This appears to cause problems when building on Arch Linux at least, as noted in bug 15181 [1]. Just removing this entirely resolves this.

This effectively reverts a51ce319492 and 71b1d397266.

[0]: https://github.com/curl/curl/commit/2d4c2152c9eb3dbdf943de46ed8fc11285f1b90b
[1]: https://bugs.buildroot.org/show_bug.cgi?id=15181

Signed-off-by Tom Wambold <[email protected]>

Thanks for this patch. James sent the same a few days before you, and basically both commit logs were roughly equivalent. So I applied James' patch instead of yours.

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 package/libcurl/libcurl.mk | 5 -----
 1 file changed, 5 deletions(-)
package/libcurl/libcurl.mk +0 -5
index 1a1594a45e..dd715c1bb6 100644
@@ -56,11 +56,6 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBCURL_OPENSSL),y)
 LIBCURL_DEPENDENCIES += openssl
-# configure adds the cross openssl dir to LD_LIBRARY_PATH which screws up
-# native stuff during the rest of configure when target == host.
-# Fix it by setting LD_LIBRARY_PATH to something sensible so those libs
-# are found first.
-LIBCURL_CONF_ENV += LD_LIBRARY_PATH=$(if $(LD_LIBRARY_PATH),$(LD_LIBRARY_PATH):)/lib:/usr/lib
 LIBCURL_CONF_OPTS += --with-openssl=$(STAGING_DIR)/usr \
 	--with-ca-path=/etc/ssl/certs
 else
Signature · 6 lines
2.40.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot