selftests/bpf: fix pkg-config call building sign-file
Subsystems (3)
PATCH 1/1 selftests/bpf: fix pkg-config call building sign-file
When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between pkg-config and --cflags:
$(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)
Removing the redirection of stderr, we see:
$ make -C tools/testing/selftests/bpf sign-file
make: Entering directory '[...]/tools/testing/selftests/bpf'
make: pkg-config--cflags: No such file or directory
SIGN-FILE sign-file
make: Leaving directory '[...]/tools/testing/selftests/bpf'Add the missing space.
--- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $(call msg,SIGN-FILE,,$@) - $(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \ + $(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \ $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
Signature · 1 line
2.39.2
Quoted 13 lines · Jeremy Sowden
When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between
pkg-configand--cflags:$(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)Removing the redirection of stderr, we see:
$ make -C tools/testing/selftests/bpf sign-file make: Entering directory '[...]/tools/testing/selftests/bpf' make: pkg-config--cflags: No such file or directory SIGN-FILE sign-file make: Leaving directory '[...]/tools/testing/selftests/bpf'
Quoted 4 lines
Add the missing space.
Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")Signed-off-by Jeremy Sowden <[email protected]>
Thanks.
Roberto
Quoted 17 lines
--- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/Makefile +1
-1@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $(call msg,SIGN-FILE,,$@) - $(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \ + $(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \ $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
Quoted 16 lines · Roberto Sassu
Quoted 15 lines · Jeremy Sowden
When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between
pkg-configand--cflags:$(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)Removing the redirection of stderr, we see:
$ make -C tools/testing/selftests/bpf sign-file make: Entering directory '[...]/tools/testing/selftests/bpf' make: pkg-config--cflags: No such file or directory SIGN-FILE sign-file make: Leaving directory '[...]/tools/testing/selftests/bpf'Add the missing space.
Quoted 8 lines
Quoted 2 lines
Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")Signed-off-by Jeremy Sowden <[email protected]>Thanks.
Reviewed-by Roberto Sassu <[email protected]>Roberto
Thanks. I was having e-mail problems yesterday when I sent the original message with the patch in it, and it didn't reach some of the recipients. I'll send it again with your Reviewed-by: attached.
J.
Quoted 17 lines
Quoted 17 lines
--- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/Makefile +1
-1@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $(call msg,SIGN-FILE,,$@) - $(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \ + $(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \ $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
Daniel Borkmann
maintainerQuoted 22 lines · Jeremy Sowden
Quoted 21 lines · Roberto Sassu
Quoted 13 lines · Jeremy Sowden
When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between
pkg-configand--cflags:$(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)Removing the redirection of stderr, we see:
$ make -C tools/testing/selftests/bpf sign-file make: Entering directory '[...]/tools/testing/selftests/bpf' make: pkg-config--cflags: No such file or directory SIGN-FILE sign-file make: Leaving directory '[...]/tools/testing/selftests/bpf'Quoted 4 lines
Add the missing space.
Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")Signed-off-by Jeremy Sowden <[email protected]>Thanks.
Quoted 7 lines
Quoted 3 lines
Reviewed-by Roberto Sassu <[email protected]>Roberto
Thanks. I was having e-mail problems yesterday when I sent the original message with the patch in it, and it didn't reach some of the recipients. I'll send it again with your
Reviewed-by:attached.
No need, already took it, thanks. Looks like patchbot did not reply. :/