Skip to contentSkip to conversation

selftests/bpf: fix pkg-config call building sign-file

PATCH In review Jeremy Sowden 3 participants 4 messages Apr 26, 2023 – Apr 27, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: fix pkg-config call building sign-file

When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between pkg-config and --cflags:

  $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)

Removing the redirection of stderr, we see:

  $ make -C tools/testing/selftests/bpf sign-file
  make: Entering directory '[...]/tools/testing/selftests/bpf'
  make: pkg-config--cflags: No such file or directory
    SIGN-FILE sign-file
  make: Leaving directory '[...]/tools/testing/selftests/bpf'

Add the missing space.

Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
index b677dcd0b77a..ad01c9e1ff12 100644
@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r
 
 $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
 	$(call msg,SIGN-FILE,,$@)
-	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \
+	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \
 		  $< -o $@ \
 		  $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Jeremy Sowden

When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between pkg-config and --cflags:

  $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)

Removing the redirection of stderr, we see:

  $ make -C tools/testing/selftests/bpf sign-file
  make: Entering directory '[...]/tools/testing/selftests/bpf'
  make: pkg-config--cflags: No such file or directory
    SIGN-FILE sign-file
  make: Leaving directory '[...]/tools/testing/selftests/bpf'
Quoted 4 lines

Add the missing space.

Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")

Thanks.

Roberto

Quoted 17 lines
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
index b677dcd0b77a..ad01c9e1ff12 100644
@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r
 
 $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
 	$(call msg,SIGN-FILE,,$@)
-	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \
+	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \
 		  $< -o $@ \
 		  $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
 
#2 lore raw
Quoted 16 lines · Roberto Sassu
Quoted 15 lines · Jeremy Sowden

When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between pkg-config and --cflags:

  $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)

Removing the redirection of stderr, we see:

  $ make -C tools/testing/selftests/bpf sign-file
  make: Entering directory '[...]/tools/testing/selftests/bpf'
  make: pkg-config--cflags: No such file or directory
    SIGN-FILE sign-file
  make: Leaving directory '[...]/tools/testing/selftests/bpf'

Add the missing space.

Quoted 8 lines
Quoted 2 lines
Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")

Thanks.

Roberto

Thanks. I was having e-mail problems yesterday when I sent the original message with the patch in it, and it didn't reach some of the recipients. I'll send it again with your Reviewed-by: attached.

J.

Quoted 17 lines
Quoted 17 lines
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
index b677dcd0b77a..ad01c9e1ff12 100644
@@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r
 
 $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
 	$(call msg,SIGN-FILE,,$@)
-	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \
+	$(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \
 		  $< -o $@ \
 		  $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
 
maintainer
#3 lore raw
Quoted 22 lines · Jeremy Sowden
Quoted 21 lines · Roberto Sassu
Quoted 13 lines · Jeremy Sowden

When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between pkg-config and --cflags:

   $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)

Removing the redirection of stderr, we see:

   $ make -C tools/testing/selftests/bpf sign-file
   make: Entering directory '[...]/tools/testing/selftests/bpf'
   make: pkg-config--cflags: No such file or directory
     SIGN-FILE sign-file
   make: Leaving directory '[...]/tools/testing/selftests/bpf'
Quoted 4 lines

Add the missing space.

Fixes fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")

Thanks.

Quoted 7 lines
Quoted 3 lines

Roberto

Thanks. I was having e-mail problems yesterday when I sent the original message with the patch in it, and it didn't reach some of the recipients. I'll send it again with your Reviewed-by: attached.

No need, already took it, thanks. Looks like patchbot did not reply. :/

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=415d7a49cd796a11cfbeaa360b13721bba5117bb