Skip to contentSkip to conversation

package/sunxi-tools: fix build dependencies

PATCH In review Maksim Kiselev 3 participants 3 messages Apr 27, 2023 – May 1, 2023 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sunxi-tools: fix build dependencies

This patch fixes the dependency on libfdt for host-sunxi-tools. Also it fixes the dependency on zlib for sunxi-tools.

Fix the following host build failure raised since commit 2e330dff6a7ce7965ceb0dccdc9dcbcb329167bb

fit_image.c:19:10: fatal error: libfdt.h: No such file or directory
19 | #include <libfdt.h>

      |          ^~~~~~~~~~

compilation terminated.

---
 package/sunxi-tools/Config.in      | 1 +
 package/sunxi-tools/Config.in.host | 1 +
 package/sunxi-tools/sunxi-tools.mk | 7 ++++---
 3 files changed, 6 insertions(+), 3 deletions(-)
package/sunxi-tools/Config.in +1 -0
index e748637c72..14f7da5bf2 100644
@@ -27,6 +27,7 @@ config BR2_PACKAGE_SUNXI_TOOLS_FEL
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
 	select BR2_PACKAGE_DTC
 	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_ZLIB
 	help
 	  The sunxi-fel command can interact with a sunxi device in
 	  fel mode. This allows do download code to memory and execute
package/sunxi-tools/Config.in.host +1 -0
index 51f13cf623..f7c60b37a9 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_HOST_SUNXI_TOOLS
 	bool "host sunxi-tools"
 	depends on BR2_arm
 	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-libusb
+	select BR2_PACKAGE_HOST_DTC
 	help
 	  Tools for Allwinner A10 (aka sun4i) and A13 (aka sun5i)
 	  based devices. This includes fex2bin which can be used to
package/sunxi-tools/sunxi-tools.mk +4 -3
index a9569f2910..97863efc13 100644
@@ -8,7 +8,7 @@ SUNXI_TOOLS_VERSION = 1.4.2-168-ged3039cdbeeb28fc0011c3585d8f7dfb91038292
 SUNXI_TOOLS_SITE = $(call github,linux-sunxi,sunxi-tools,v$(SUNXI_TOOLS_VERSION))
 SUNXI_TOOLS_LICENSE = GPL-2.0+
 SUNXI_TOOLS_LICENSE_FILES = LICENSE.md
-HOST_SUNXI_TOOLS_DEPENDENCIES = host-libusb host-pkgconf
+HOST_SUNXI_TOOLS_DEPENDENCIES = host-dtc host-libzlib host-libusb host-pkgconf
 FEX2BIN = $(HOST_DIR)/bin/fex2bin
 
 SUNXI_TOOLS_TARGETS_$(BR2_PACKAGE_SUNXI_TOOLS_FEXC) += sunxi-fexc
@@ -26,13 +26,14 @@ SUNXI_TOOLS_FEXC_LINKS += fex2bin bin2fex
 endif
 
 ifeq ($(BR2_PACKAGE_SUNXI_TOOLS_FEL),y)
-SUNXI_TOOLS_DEPENDENCIES += dtc libusb host-pkgconf
+SUNXI_TOOLS_DEPENDENCIES += dtc libusb zlib host-pkgconf
 endif
 
 define HOST_SUNXI_TOOLS_BUILD_CMDS
 	$(HOST_MAKE_ENV) $(MAKE) CROSS_COMPILE="" CC="$(HOSTCC)" \
 		PREFIX=$(HOST_DIR) EXTRA_CFLAGS="$(HOST_CFLAGS)" \
-		LDFLAGS="$(HOST_LDFLAGS)" -C $(@D) tools misc
+		LDFLAGS="$(HOST_LDFLAGS) -I$(HOST_DIR)/include/libfdt" \
+		-C $(@D) tools misc
 endef
 
 define HOST_SUNXI_TOOLS_INSTALL_CMDS
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Tested-by on v1 1/1
#1 lore raw

Hi Maksim,

Quoted 6 lines · Maksim Kiselev

This patch fixes the dependency on libfdt for host-sunxi-tools. Also it fixes the dependency on zlib for sunxi-tools.

Fix the following host build failure raised since commit 2e330dff6a7ce7965ceb0dccdc9dcbcb329167bb

Quoted 7 lines

fit_image.c:19:10: fatal error: libfdt.h: No such file or directory

    19 | #include <libfdt.h>
       |          ^~~~~~~~~~

compilation terminated.

thank you for the patch, it looks good:

Best regards

Signature · 1 line
CEO/CTO@Benetti Engineering sas
Quoted 50 lines
---
  package/sunxi-tools/Config.in      | 1 +
  package/sunxi-tools/Config.in.host | 1 +
  package/sunxi-tools/sunxi-tools.mk | 7 ++++---
  3 files changed, 6 insertions(+), 3 deletions(-)
package/sunxi-tools/Config.in +1 -0
index e748637c72..14f7da5bf2 100644
@@ -27,6 +27,7 @@ config BR2_PACKAGE_SUNXI_TOOLS_FEL
  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
  	select BR2_PACKAGE_DTC
  	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_ZLIB
  	help
  	  The sunxi-fel command can interact with a sunxi device in
  	  fel mode. This allows do download code to memory and execute
package/sunxi-tools/Config.in.host +1 -0
index 51f13cf623..f7c60b37a9 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_HOST_SUNXI_TOOLS
  	bool "host sunxi-tools"
  	depends on BR2_arm
  	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-libusb
+	select BR2_PACKAGE_HOST_DTC
  	help
  	  Tools for Allwinner A10 (aka sun4i) and A13 (aka sun5i)
  	  based devices. This includes fex2bin which can be used to
package/sunxi-tools/sunxi-tools.mk +2 -2
index a9569f2910..97863efc13 100644
@@ -8,7 +8,7 @@ SUNXI_TOOLS_VERSION = 1.4.2-168-ged3039cdbeeb28fc0011c3585d8f7dfb91038292
  SUNXI_TOOLS_SITE = $(call github,linux-sunxi,sunxi-tools,v$(SUNXI_TOOLS_VERSION))
  SUNXI_TOOLS_LICENSE = GPL-2.0+
  SUNXI_TOOLS_LICENSE_FILES = LICENSE.md
-HOST_SUNXI_TOOLS_DEPENDENCIES = host-libusb host-pkgconf
+HOST_SUNXI_TOOLS_DEPENDENCIES = host-dtc host-libzlib host-libusb host-pkgconf
  FEX2BIN = $(HOST_DIR)/bin/fex2bin
 
  SUNXI_TOOLS_TARGETS_$(BR2_PACKAGE_SUNXI_TOOLS_FEXC) += sunxi-fexc
@@ -26,13 +26,14 @@ SUNXI_TOOLS_FEXC_LINKS += fex2bin bin2fex
  endif
 
  ifeq ($(BR2_PACKAGE_SUNXI_TOOLS_FEL),y)
-SUNXI_TOOLS_DEPENDENCIES += dtc libusb host-pkgconf
+SUNXI_TOOLS_DEPENDENCIES += dtc libusb zlib host-pkgconf
  endif

package/sunxi-tools/sunxi-tools.mk SUNXI_TOOLS_FEXC_LINKS += fex2bin bin2fex · line 39

Quoted 10 lines
package/sunxi-tools/sunxi-tools.mk +2 -1
 
  define HOST_SUNXI_TOOLS_BUILD_CMDS
  	$(HOST_MAKE_ENV) $(MAKE) CROSS_COMPILE="" CC="$(HOSTCC)" \
  		PREFIX=$(HOST_DIR) EXTRA_CFLAGS="$(HOST_CFLAGS)" \
-		LDFLAGS="$(HOST_LDFLAGS)" -C $(@D) tools misc
+		LDFLAGS="$(HOST_LDFLAGS) -I$(HOST_DIR)/include/libfdt" \
+		-C $(@D) tools misc
  endef
 
  define HOST_SUNXI_TOOLS_INSTALL_CMDS

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Maksim Kiselev
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maksim" == Maksim Kiselev <[email protected]> writes:

This patch fixes the dependency on libfdt for host-sunxi-tools. Also it fixes the dependency on zlib for sunxi-tools.

Fix the following host build failure raised since commit 2e330dff6a7ce7965ceb0dccdc9dcbcb329167bb

Quoted 7 lines

fit_image.c:19:10: fatal error: libfdt.h: No such file or directory
19 | #include <libfdt.h>

      |          ^~~~~~~~~~

compilation terminated.

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot