mm: change per-VMA lock statistics to be disabled by default
Subsystems (2)
Suren Baghdasaryan
reviewerPATCH 1/1 mm: change per-VMA lock statistics to be disabled by default
Change CONFIG_PER_VMA_LOCK_STATS to be disabled by default, as most users don't need it. Add configuration help to clarify its usage.
Fixes 52f238653e45 ("mm: introduce per-VMA lock statistics")
Suggested-by Linus Torvalds <[email protected]>
Signed-off-by Suren Baghdasaryan <[email protected]>
--- mm/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
mm/Kconfig.debug +8 -2
@@ -274,6 +274,12 @@ config DEBUG_KMEMLEAK_AUTO_SCAN config PER_VMA_LOCK_STATS bool "Statistics for per-vma locks" depends on PER_VMA_LOCK - default y help - Statistics for per-vma locks. + Say Y here to enable success, retry and failure counters of page + faults handled under protection of per-vma locks. When enabled, the + counters are exposed in /proc/vmstat. This information is useful for + kernel developers to evaluate effectiveness of per-vma locks and to + identify pathological cases. Counting these events introduces a small + overhead in the page fault path. + + If in doubt, say N.
Signature · 1 line
2.40.1.495.gc816e09b53d-goog
Quoted 30 lines · Suren Baghdasaryan
Change
CONFIG_PER_VMA_LOCK_STATSto be disabled by default, as most users don't need it. Add configuration help to clarify its usage.Fixes 52f238653e45 ("mm: introduce per-VMA lock statistics")Suggested-by Linus Torvalds <[email protected]>Signed-off-by Suren Baghdasaryan <[email protected]>--- mm/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)mm/Kconfig.debug +8
-3@@ -274,6 +274,12 @@ config DEBUG_KMEMLEAK_AUTO_SCAN config PER_VMA_LOCK_STATS bool "Statistics for per-vma locks" depends on PER_VMA_LOCK - default y help - Statistics for per-vma locks. + Say Y here to enable success, retry and failure counters of page + faults handled under protection of per-vma locks. When enabled, the + counters are exposed in /proc/vmstat. This information is useful for + kernel developers to evaluate effectiveness of per-vma locks and to + identify pathological cases. Counting these events introduces a small + overhead in the page fault path. + + If in doubt, say N. --
Quoted 2 lines
2.40.1.495.gc816e09b53d-goog
Reviewed-by Lorenzo Stoakes <[email protected]>
Quoted 6 lines · Suren Baghdasaryan
Change
CONFIG_PER_VMA_LOCK_STATSto be disabled by default, as most users don't need it. Add configuration help to clarify its usage.Fixes 52f238653e45 ("mm: introduce per-VMA lock statistics")Suggested-by Linus Torvalds <[email protected]>Signed-off-by Suren Baghdasaryan <[email protected]>
Acked-by Vlastimil Babka <[email protected]>
Quoted 23 lines
--- mm/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)mm/Kconfig.debug +8
-2@@ -274,6 +274,12 @@ config DEBUG_KMEMLEAK_AUTO_SCAN config PER_VMA_LOCK_STATS bool "Statistics for per-vma locks" depends on PER_VMA_LOCK - default y help - Statistics for per-vma locks. + Say Y here to enable success, retry and failure counters of page + faults handled under protection of per-vma locks. When enabled, the + counters are exposed in /proc/vmstat. This information is useful for + kernel developers to evaluate effectiveness of per-vma locks and to + identify pathological cases. Counting these events introduces a small + overhead in the page fault path. + + If in doubt, say N.
Quoted 19 lines · Suren Baghdasaryan
Change
CONFIG_PER_VMA_LOCK_STATSto be disabled by default, as most users don't need it. Add configuration help to clarify its usage.Fixes 52f238653e45 ("mm: introduce per-VMA lock statistics")Suggested-by Linus Torvalds <[email protected]>Signed-off-by Suren Baghdasaryan <[email protected]>--- mm/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)mm/Kconfig.debug +0
-1@@ -274,6 +274,12 @@ config DEBUG_KMEMLEAK_AUTO_SCAN config PER_VMA_LOCK_STATS bool "Statistics for per-vma locks" depends on PER_VMA_LOCK - default y
mm/Kconfig.debug config DEBUG_KMEMLEAK_AUTO_SCAN · line 285
Quoted 10 lines
mm/Kconfig.debug +8
-1help - Statistics for per-vma locks. + Say Y here to enable success, retry and failure counters of page + faults handled under protection of per-vma locks. When enabled, the + counters are exposed in /proc/vmstat. This information is useful for + kernel developers to evaluate effectiveness of per-vma locks and to + identify pathological cases. Counting these events introduces a small + overhead in the page fault path. + + If in doubt, say N.
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb