Skip to contentSkip to conversation

btrfs-progs: doc: fix the indent on the ORPHAN_OBJECTID

PATCH In review Qu Wenruo 2 participants 3 messages May 1, 2023 – May 2, 2023

Subsystems (2)
lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/2 btrfs-progs: doc: fix the indent on the ORPHAN_OBJECTID

When compiling the documents, we have the following warning:

~/btrfs-progs/Documentation/dev/On-disk-format.rst:369: WARNING: Bullet list ends without a blank line; unexpected unindent.

It's caused by a mismatched indent, just fix it.

---
 Documentation/dev/On-disk-format.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/dev/On-disk-format.rst +2 -2
index 8cbbaf37..9e8a9f7e 100644
@@ -366,8 +366,8 @@ is located in the ``ROOT_TREE`` and is of the following form.
 +-----------------------------------+
 
 -  There is no item body associated with this key. All required information is
-  contained within the key itself and the ``ROOT_ITEM`` associated with the
-  objectid contained in ``offset``
+   contained within the key itself and the ``ROOT_ITEM`` associated with the
+   objectid contained in ``offset``
 
 When the file system is mounted again after failure, the ``ROOT_TREE`` is
 searched for all orphan keys and the process is resumed for each one using the
Signature · 1 line
2.39.0
author
#1 lore raw

PATCH 2/2 btrfs-progs: tests: mkfs/021: update to use -O instead of deprecated -R

-R option is deprecated since commit 4dbe66ca2f21 ("btrfs-progs: mkfs: make -R|--runtime-features option deprecated"), migrate the test case to follow the change.

---
 tests/mkfs-tests/021-rfeatures-quota-rootdir/test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/mkfs-tests/021-rfeatures-quota-rootdir/test.sh +2 -2
index ec45c1d9..b03e3f61 100755
@@ -1,5 +1,5 @@
 #!/bin/bash
-# Check if mkfs runtime feature quota can handle --rootdir
+# Check if mkfs feature quota can handle --rootdir
 
 source "$TEST_TOP/common" || exit
 
@@ -38,7 +38,7 @@ run_check dd if=/dev/zero bs=2K count=1 of="$tmp/2K"
 run_check dd if=/dev/zero bs=4K count=1 of="$tmp/4K"
 run_check dd if=/dev/zero bs=8K count=1 of="$tmp/8K"
 
-run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f --rootdir "$tmp" -R quota "$TEST_DEV"
+run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f --rootdir "$tmp" -O quota "$TEST_DEV"
 
 rm -rf -- "$tmp"
 
Signature · 1 line
2.39.0
#2 lore raw
In reply to Qu Wenruo
Quoted 7 lines · Qu Wenruo

When compiling the documents, we have the following warning:

~/btrfs-progs/Documentation/dev/On-disk-format.rst:369: WARNING: Bullet list ends without a blank line; unexpected unindent.

It's caused by a mismatched indent, just fix it.

Patches added to devel, thanks.