Skip to contentSkip to conversation

dt-bindings: tegra: Document compatible for IGX

PATCH In review Shubhi Garg 3 participants 4 messages May 2, 2023 – May 3, 2023

Subsystems (2)
Device tree bindings Tegra architecture support
lore
Share & tools
lore

Shubhi Garg

author
#0 lore raw

PATCH 1/2 dt-bindings: tegra: Document compatible for IGX

Document the compatible strings used for Nvidia IGX Orin Development kit which uses P3701 SKU8 and P3740 carrier board.

Signed-off-by Shubhi Garg <[email protected]>
---
 Documentation/devicetree/bindings/arm/tegra.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/tegra.yaml +6 -0
index 0df41f5b7e2a..6a5e303fba08 100644
@@ -176,5 +176,11 @@ properties:
           - const: nvidia,p3768-0000+p3767-0000
           - const: nvidia,p3767-0000
           - const: nvidia,tegra234
+      - description: NVIDIA IGX Orin Development Kit
+        items:
+          - const: nvidia,p3740-0002+p3701-0008
+          - const: nvidia,p3740-0002
+          - const: nvidia,p3701-0008
+          - const: nvidia,tegra234
 
 additionalProperties: true
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 arm64: tegra: Add support for IGX Orin

Add support for the NVIDIA IGX Orin development kit having P3701 module with P3740 carrier board.

Signed-off-by Shubhi Garg <[email protected]>
---
 arch/arm64/boot/dts/nvidia/Makefile           |   2 +
 .../boot/dts/nvidia/tegra234-p3701-0008.dtsi  | 111 +++++++++++++
 .../nvidia/tegra234-p3740-0002+p3701-0008.dts | 156 ++++++++++++++++++
 .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  | 137 +++++++++++++++
 4 files changed, 406 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3701-0008.dtsi
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
arch/arm64/boot/dts/nvidia/Makefile +2 -0
index 1406d5d40b8f..2ea0058979d3 100644
@@ -9,6 +9,7 @@ DTC_FLAGS_tegra194-p2972-0000 := -@
 DTC_FLAGS_tegra194-p3509-0000+p3668-0000 := -@
 DTC_FLAGS_tegra194-p3509-0000+p3668-0001 := -@
 DTC_FLAGS_tegra234-p3737-0000+p3701-0000 := -@
+DTC_FLAGS_tegra234-p3740-0002+p3701-0008 := -@
 DTC_FLAGS_tegra234-p3768-0000+p3767-0000 := -@
 
 dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb

@@ -25,4 +26,5 @@ dtb-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra194-p3509-0000+p3668-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra194-p3509-0000+p3668-0001.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-sim-vdk.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3737-0000+p3701-0000.dtb
+dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3740-0002+p3701-0008.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3768-0000+p3767-0000.dtb
arch/arm64/boot/dts/nvidia/tegra234-p3701-0008.dtsi new file +111 -0

111 lines not on this page · raw message

arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts new file +156 -0

156 lines not on this page · raw message

arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi new file +137 -0

137 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw
In reply to Shubhi Garg
Quoted 13 lines · Shubhi Garg

Document the compatible strings used for Nvidia IGX Orin Development kit which uses P3701 SKU8 and P3740 carrier board.

Signed-off-by Shubhi Garg <[email protected]>
---
 Documentation/devicetree/bindings/arm/tegra.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/tegra.yaml +0 -0
index 0df41f5b7e2a..6a5e303fba08 100644

Documentation/devicetree/bindings/arm/tegra.yaml properties: · line 182

Quoted 7 lines
Documentation/devicetree/bindings/arm/tegra.yaml +4 -0
@@ -176,5 +176,11 @@ properties:
           - const: nvidia,p3768-0000+p3767-0000
           - const: nvidia,p3767-0000
           - const: nvidia,tegra234
+      - description: NVIDIA IGX Orin Development Kit
+        items:
+          - const: nvidia,p3740-0002+p3701-0008
+          - const: nvidia,p3740-0002

We don't usually list the carrier board here. The reasoning is that we first list the most specific combination (carrier + module) that the device tree describes, then the module (which theoretically the same device tree should also be able to run on) and finally the SoC. The OS wouldn't know what to do with just the SoC, but we list it to make it clear what SoC family this is.

The carrier board, on the other hand, is not something that the OS can run on standalone because it doesn't have a CPU, so we omit that from the list of compatible strings.

Thierry

#3 lore raw
In reply to Shubhi Garg
Quoted 7 lines · Shubhi Garg

Document the compatible strings used for Nvidia IGX Orin Development kit which uses P3701 SKU8 and P3740 carrier board.

Signed-off-by Shubhi Garg <[email protected]>
---
 Documentation/devicetree/bindings/arm/tegra.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

I just saw it and reviewed it, so both are v1?

use proper versioning and add missing changelogs to the patches.

Best regards,
Krzysztof