Skip to contentSkip to conversation

Correct fallback compatible for rtl8821cs bluetooth

PATCH Applied Chris Morgan 4 participants 7 messages May 8, 2023 – Jun 8, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Correct fallback compatible for rtl8821cs bluetooth

From: Chris Morgan <[email protected]>

The realtek 8821cs bluetooth module is functionally very similar to the 8822cs and 8723bs modules, however unlike the 8822 module it seems to struggle when power management features are enabled. By switching the fallback string from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt we can instruct the driver to not enable advanced power management features that cause the issues.

Chris Morgan (2):
dt-bindings: net: realtek-bluetooth: Fix RTL8821CS binding
arm64: dts: rockchip: Fix compatible for Bluetooth

 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 dt-bindings: net: realtek-bluetooth: Fix RTL8821CS binding

From: Chris Morgan <[email protected]>

Update the fallback string for the RTL8821CS from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt. The difference between these two strings is that the 8822cs enables power saving features that the 8723bs does not, and in testing the 8821cs seems to have issues with these power saving modes enabled.

Fixes 95ee3a93239e ("dt-bindings: net: realtek-bluetooth: Add RTL8821CS")
---
 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +1 -1
index 8cc2b9924680..506ea9b17668 100644
@@ -27,7 +27,7 @@ properties:
       - items:
           - enum:
               - realtek,rtl8821cs-bt
-          - const: realtek,rtl8822cs-bt
+          - const: realtek,rtl8723bs-bt
 
   device-wake-gpios:
     maxItems: 1
Signature · 1 line
2.34.1
#5 lore raw

PATCH 2/2 arm64: dts: rockchip: Fix compatible for Bluetooth

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

The realtek Bluetooth module uses the same driver as the realtek,rtl8822cs-bt and the realtek,rtl8723bs-bt, however by selecting the 8723bs advanced power saving features are disabled that appear to interfere with normal operation of the bluetooth module. This change switches the compatible string to disable power saving. Without this patch evtest of a paired bluetooth controller fails, with this patch the controller operates as expected.

Fixes b6986b7920bb ("arm64: dts: rockchip: Update compatible for bluetooth")
---
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi +1 -1
index 8fadd8afb190..ad43fa199ca5 100644
@@ -716,7 +716,7 @@ &uart1 {
 	status = "okay";
 
 	bluetooth {
-		compatible = "realtek,rtl8821cs-bt", "realtek,rtl8822cs-bt";
+		compatible = "realtek,rtl8821cs-bt", "realtek,rtl8723bs-bt";
 		device-wake-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
 		enable-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>;
 		host-wake-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.34.1
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: net: realtek-bluetooth: Fix RTL8821CS binding

In reply to Chris Morgan
Quoted 10 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Update the fallback string for the RTL8821CS from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt. The difference between these two strings is that the 8822cs enables power saving features that the 8723bs does not, and in testing the 8821cs seems to have issues with these power saving modes enabled.

Fixes 95ee3a93239e ("dt-bindings: net: realtek-bluetooth: Add RTL8821CS")

Best regards,
Krzysztof

maintainer Acked-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] dt-bindings: net: realtek-bluetooth: Fix RTL8821CS binding

In reply to Chris Morgan

Am Montag, 8. Mai 2023, 18:08:10 CEST schrieb Chris Morgan:

Quoted 10 lines

From: Chris Morgan <[email protected]>

Update the fallback string for the RTL8821CS from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt. The difference between these two strings is that the 8822cs enables power saving features that the 8723bs does not, and in testing the 8821cs seems to have issues with these power saving modes enabled.

Fixes 95ee3a93239e ("dt-bindings: net: realtek-bluetooth: Add RTL8821CS")
maintainer Applied
#4 lore raw

Re: [PATCH 1/2] dt-bindings: net: realtek-bluetooth: Fix RTL8821CS binding

In reply to Chris Morgan
Quoted 8 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Update the fallback string for the RTL8821CS from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt. The difference between these two strings is that the 8822cs enables power saving features that the 8723bs does not, and in testing the 8821cs seems to have issues with these power saving modes enabled.

Quoted 6 lines
Fixes 95ee3a93239e ("dt-bindings: net: realtek-bluetooth: Add RTL8821CS")
---
 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

maintainer Applied
#6 lore raw

Re: (subset) [PATCH 0/2] Correct fallback compatible for rtl8821cs bluetooth

In reply to Chris Morgan
Quoted 10 lines · Chris Morgan

From: Chris Morgan <[email protected]>

The realtek 8821cs bluetooth module is functionally very similar to the 8822cs and 8723bs modules, however unlike the 8822 module it seems to struggle when power management features are enabled. By switching the fallback string from realtek,rtl8822cs-bt to realtek,rtl8723bs-bt we can instruct the driver to not enable advanced power management features that cause the issues.

[...]

Applied, thanks!

[2/2] arm64: dts: rockchip: Fix compatible for Bluetooth

      commit: a325956fa7048906e26a4535ac2e87e111788fe8

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip