Skip to contentSkip to conversation

sched: Fix KCSAN noinstr violation

PATCH New Sasha Levin 1 participant 2 messages May 9, 2023 Stable branch

lore
Share & tools
lore

Sasha Levin

author maintainer
#0 lore raw

PATCH 1/2 sched: Fix KCSAN noinstr violation

From: Josh Poimboeuf <[email protected]>

[ Upstream commit e0b081d17a9f4e5c0cbb0e5fbeb1abe3de0f7e4e ]

With KCSAN enabled, end_of_stack() can get out-of-lined. Force it inline.

Fixes the following warnings:

vmlinux.o: warning: objtool: check_stackleak_irqoff+0x2b: call to end_of_stack() leaves .noinstr.text section

Signed-off-by Josh Poimboeuf <[email protected]>
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Link https://lore.kernel.org/r/cc1b4d73d3a428a00d206242a68fdf99a934ca7b.1681320026.git.jpoimboe@kernel.org open here
Signed-off-by Sasha Levin <[email protected]>
---
 include/linux/sched/task_stack.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sched/task_stack.h +1 -1
index 3461beb89b040..62d1cd4db27af 100644
@@ -23,7 +23,7 @@ static inline void *task_stack_page(const struct task_struct *task)
 
 #define setup_thread_stack(new,old)	do { } while(0)
 
-static inline unsigned long *end_of_stack(const struct task_struct *task)
+static __always_inline unsigned long *end_of_stack(const struct task_struct *task)
 {
 #ifdef CONFIG_STACK_GROWSUP
 	return (unsigned long *)((unsigned long)task->stack + THREAD_SIZE) - 1;
Signature · 1 line
2.39.2
author maintainer
#1 lore raw

PATCH 2/2 recordmcount: Fix memory leaks in the uwrite function

From: Hao Zeng <[email protected]>

[ Upstream commit fa359d068574d29e7d2f0fdd0ebe4c6a12b5cfb9 ]

Common realloc mistake: 'file_append' nulled but not freed upon failure

Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Hao Zeng <[email protected]>
Suggested-by Steven Rostedt <[email protected]>
Signed-off-by Steven Rostedt (Google) <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
---
 scripts/recordmcount.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
scripts/recordmcount.c +5 -1
index 9012e33ae22f8..731600de03893 100644
@@ -146,6 +146,7 @@ uwrite(int const fd, void const *const buf, size_t const count)
 {
 	size_t cnt = count;
 	off_t idx = 0;
+	void *p = NULL;
 
 	file_updated = 1;
 

@@ -153,7 +154,10 @@ uwrite(int const fd, void const *const buf, size_t const count)
 		off_t aoffset = (file_ptr + count) - file_end;
 
 		if (aoffset > file_append_size) {
-			file_append = realloc(file_append, aoffset);
+			p = realloc(file_append, aoffset);
+			if (!p)
+				free(file_append);
+			file_append = p;
 			file_append_size = aoffset;
 		}
 		if (!file_append) {
Signature · 1 line
2.39.2