Skip to contentSkip to conversation

rockchip: Add Anbernic RG353PS

PATCH Applied Chris Morgan 3 participants 5 messages May 12, 2023 – May 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover rockchip: Add Anbernic RG353PS

From: Chris Morgan <[email protected]>

Add support for the Anbernic RG353PS, which is a cheaper variant of the Anbernic RG353P.

Chris Morgan (2):
dt-bindings: arm: rockchip: add Anbernic RG353PS
arm64: dts: rockchip: add Anbernic RG353PS

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../dts/rockchip/rk3566-anbernic-rg353ps.dts  | 116 ++++++++++++++++++
 3 files changed, 122 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353ps.dts
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 dt-bindings: arm: rockchip: add Anbernic RG353PS

From: Chris Morgan <[email protected]>

Add devicetree binding for Anbernic RG353PS. This device is identical to the RG353P, except it does not have a touchscreen, does not have an eMMC, only includes 1GB of RAM, and ships with only the 2nd revision panel based on a Sitronix ST7703 controller. Support for the panel has been added in a separate commit.

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index ec141c937b8b..362df3f2a037 100644
@@ -40,6 +40,11 @@ properties:
           - const: anbernic,rg353p
           - const: rockchip,rk3566
 
+      - description: Anbernic RG353PS
+        items:
+          - const: anbernic,rg353ps
+          - const: rockchip,rk3566
+
       - description: Anbernic RG353V
         items:
           - const: anbernic,rg353v
Signature · 1 line
2.34.1
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: arm: rockchip: add Anbernic RG353PS

Quoted 9 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add devicetree binding for Anbernic RG353PS. This device is identical to the RG353P, except it does not have a touchscreen, does not have an eMMC, only includes 1GB of RAM, and ships with only the 2nd revision panel based on a Sitronix ST7703 controller. Support for the panel has been added in a separate commit.

The see-through case looks kinda cool actually.

Thanks,
Conor.

Quoted 23 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index ec141c937b8b..362df3f2a037 100644
@@ -40,6 +40,11 @@ properties:
           - const: anbernic,rg353p
           - const: rockchip,rk3566
 
+      - description: Anbernic RG353PS
+        items:
+          - const: anbernic,rg353ps
+          - const: rockchip,rk3566
+
       - description: Anbernic RG353V
         items:
           - const: anbernic,rg353v
Signature · 1 line
2.34.1
#3 lore raw

PATCH 2/2 arm64: dts: rockchip: add Anbernic RG353PS

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add support for the Anbernic RG353PS. This device is identical in form factor to the RG353P and has the following hardware differences:
- No touchscreen is present on i2c2 (or at all).
- Only contains 1GB of RAM.
- Has no eMMC.
- Only appears to ship with the 2nd revision of the display panel.

Note that the display panel has been added to the st7703 panel driver in a separate commit series.

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../dts/rockchip/rk3566-anbernic-rg353ps.dts  | 116 ++++++++++++++++++
 2 files changed, 117 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353ps.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 2d585bbb8f3a..b6f7158c4552 100644
@@ -69,6 +69,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353p.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353ps.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353v.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353vs.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg503.dtb
arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353ps.dts new file +116 -0

116 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer Applied
#4 lore raw
In reply to Chris Morgan
Quoted 10 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add support for the Anbernic RG353PS, which is a cheaper variant of the Anbernic RG353P.

Chris Morgan (2):
dt-bindings: arm: rockchip: add Anbernic RG353PS
arm64: dts: rockchip: add Anbernic RG353PS

[...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: add Anbernic RG353PS

      commit: 4e959380ba823cdf4e643ff247b8359e1bcbf683
[2/2] arm64: dts: rockchip: add Anbernic RG353PS
      commit: 4d83538aab4ccb59abdbf7f39568761a8b7d7ea1

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>