efi/esrt: Allow ESRT access without CAP_SYS_ADMIN
PATCH 1/1 efi/esrt: Allow ESRT access without CAP_SYS_ADMIN
Access to the files in /sys/firmware/efi/esrt has been restricted to CAP_SYS_ADMIN since support for ESRT was added, but this seems overly restrictive given that the files are read-only and just provide information about UEFI firmware updates.
Remove the CAP_SYS_ADMIN restriction so that a non-root process can read the files, provided a suitably-privileged process changes the file ownership first. The files are still read-only and still owned by root by default.
--- drivers/firmware/efi/esrt.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/firmware/efi/esrt.c +0 -4
@@ -95,10 +95,6 @@ static ssize_t esre_attr_show(struct kobject *kobj,struct esre_entry *entry =to_entry (kobj);struct esre_attribute *attr =to_attr (_attr); -/* Don't tell normal users what firmware versions we've got... */ -if (!capable (CAP_SYS_ADMIN )) -return -EACCES ; -return attr->show (entry, buf); }
Signature · 1 line
2.40.1.606.ga4b1b128d6-goog
Ard Biesheuvel
maintainerQuoted 6 lines · Nicholas Bishop
Access to the files in
/sys/firmware/efi/esrthas been restricted toCAP_SYS_ADMINsince support for ESRT was added, but this seems overly restrictive given that the files are read-only and just provide information about UEFI firmware updates.
Quoted 6 lines
Remove the
CAP_SYS_ADMINrestriction so that a non-root process can read the files, provided a suitably-privileged process changes the file ownership first. The files are still read-only and still owned by root by default.Signed-off-by Nicholas Bishop <[email protected]>
Seems reasonable to me. Peter?
Quoted 22 lines
--- drivers/firmware/efi/esrt.c | 4 ---- 1 file changed, 4 deletions(-)drivers/firmware/efi/esrt.c +0
-5@@ -95,10 +95,6 @@ static ssize_t esre_attr_show(struct kobject *kobj,struct esre_entry *entry =to_entry (kobj);struct esre_attribute *attr =to_attr (_attr); -/* Don't tell normal users what firmware versions we've got... */ -if (!capable (CAP_SYS_ADMIN )) -return -EACCES ; -return attr->show (entry, buf); } --2.40.1.606.ga4b1b128d6-goog
Ard Biesheuvel
maintainerQuoted 8 lines · Ard Biesheuvel
Quoted 6 lines · Nicholas Bishop
Access to the files in
/sys/firmware/efi/esrthas been restricted toCAP_SYS_ADMINsince support for ESRT was added, but this seems overly restrictive given that the files are read-only and just provide information about UEFI firmware updates.
Quoted 9 lines
Quoted 6 lines
Remove the
CAP_SYS_ADMINrestriction so that a non-root process can read the files, provided a suitably-privileged process changes the file ownership first. The files are still read-only and still owned by root by default.Signed-off-by Nicholas Bishop <[email protected]>Seems reasonable to me. Peter?
I've queued this up now.
Quoted 22 lines
Quoted 22 lines
--- drivers/firmware/efi/esrt.c | 4 ---- 1 file changed, 4 deletions(-)drivers/firmware/efi/esrt.c +0
-5@@ -95,10 +95,6 @@ static ssize_t esre_attr_show(struct kobject *kobj,struct esre_entry *entry =to_entry (kobj);struct esre_attribute *attr =to_attr (_attr); -/* Don't tell normal users what firmware versions we've got... */ -if (!capable (CAP_SYS_ADMIN )) -return -EACCES ; -return attr->show (entry, buf); } --2.40.1.606.ga4b1b128d6-goog
Quoted 8 lines · Ard Biesheuvel
Quoted 6 lines · Nicholas Bishop
Access to the files in
/sys/firmware/efi/esrthas been restricted toCAP_SYS_ADMINsince support for ESRT was added, but this seems overly restrictive given that the files are read-only and just provide information about UEFI firmware updates.
Quoted 8 lines
Quoted 6 lines
Remove the
CAP_SYS_ADMINrestriction so that a non-root process can read the files, provided a suitably-privileged process changes the file ownership first. The files are still read-only and still owned by root by default.Signed-off-by Nicholas Bishop <[email protected]>Seems reasonable to me. Peter?
Yeah, I don't think we had any specific reason to limit it.
-- Peter