Skip to contentSkip to conversation

sunxi: Fix typo in include guard

PATCH Applied Sam Edwards 2 participants 4 messages May 13, 2023 – Jun 7, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: Fix typo in include guard

---
 arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-sunxi/pmic_bus.h +1 -1
index 3ccfe138f3..5ab9b2809f 100644
@@ -6,7 +6,7 @@
  */
 
 #ifndef _SUNXI_PMIC_BUS_H
-#define _SUNXI_PMIS_BUS_H
+#define _SUNXI_PMIC_BUS_H
 
 int pmic_bus_init(void);
 int pmic_bus_read(u8 reg, u8 *data);
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw

On Fri, 12 May 2023 15:22:14 -0600
Sam Edwards <[email protected]> wrote:

Hi Sam,

Good catch! It's not the first time we see misspelled preprocessor symbols, although that typically happens with Kconfig names.

How did you find this? Just by accident? I was wondering if we could check the tree automatically for those accidents.

Quoted 1 line

Cheers,
Andre

Quoted 17 lines
---
 arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-sunxi/pmic_bus.h +1 -1
index 3ccfe138f3..5ab9b2809f 100644
@@ -6,7 +6,7 @@
  */
 
 #ifndef _SUNXI_PMIC_BUS_H
-#define _SUNXI_PMIS_BUS_H
+#define _SUNXI_PMIC_BUS_H
 
 int pmic_bus_init(void);
 int pmic_bus_read(u8 reg, u8 *data);
#2 lore raw

On 5/15/23 03:48, Andre Przywara wrote:

Ahoy, Andre!

Quoted 2 lines

How did you find this? Just by accident? I was wondering if we could check the tree automatically for those accidents.

I found it both automatically and by accident. :)

My cross-compiler of choice is Clang (as I don't have to rebuild/reinstall it for each target) and its enabled-by-default -Wheader-guard diagnostic flagged that for me.

Regards,
Sam

#3 lore raw
In reply to Sam Edwards
Quoted 1 line · On Fri, 12 May 2023 15:22:14 -0600 Sam Edwards <[email protected]> wrote:

Applied to sunxi/master.

Thanks,
Andre

Quoted 17 lines
---
 arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-sunxi/pmic_bus.h +1 -1
index 3ccfe138f3..5ab9b2809f 100644
@@ -6,7 +6,7 @@
  */
 
 #ifndef _SUNXI_PMIC_BUS_H
-#define _SUNXI_PMIS_BUS_H
+#define _SUNXI_PMIC_BUS_H
 
 int pmic_bus_init(void);
 int pmic_bus_read(u8 reg, u8 *data);