Skip to contentSkip to conversation

dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus

PATCH Superseded Tianling Shen 2 participants 4 messages May 13, 2023

Subsystems (2)
Device tree bindings Arm Rockchip

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tianling Shen

author
#0 lore raw

PATCH 1/2 dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus

Add devicetree binding documentation for the NanoPi R2C Plus.

Signed-off-by Tianling Shen <[email protected]>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -0
index b1d271778179..6f4d966744a5 100644
@@ -189,6 +189,7 @@ properties:
         items:
           - enum:
               - friendlyarm,nanopi-r2c
+              - friendlyarm,nanopi-r2c-plus
               - friendlyarm,nanopi-r2s
           - const: rockchip,rk3328
Signature · 1 line
2.40.1
author
#1 lore raw

PATCH 2/2 arm64: dts: rockchip: Add FriendlyARM NanoPi R2C Plus

The NanoPi R2C Plus is a small variant of NanoPi R2C with a on-board eMMC flash (8G) included.

Signed-off-by Tianling Shen <[email protected]>
---
 arch/arm64/boot/dts/rockchip/Makefile         |  1 +
 .../dts/rockchip/rk3328-nanopi-r2c-plus.dts   | 33 +++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 1cf105d7407f..794da4d41f14 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go3.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-a1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2c.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2c-plus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus-lts.dtb
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dts new file +33 -0
new file mode 100644
index 000000000000..16a1958e4572
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2021 FriendlyElec Computer Tech. Co., Ltd.
+ * (http://www.friendlyarm.com)
+ *
+ * Copyright (c) 2023 Tianling Shen <[email protected]>
+ */
+
+/dts-v1/;
+#include "rk3328-nanopi-r2c.dts"
+
+/ {
+	model = "FriendlyElec NanoPi R2C Plus";
+	compatible = "friendlyarm,nanopi-r2c-plus", "rockchip,rk3328";
+
+	aliases {
+		mmc1 = &emmc;
+	};
+};
+
+&emmc {
+	bus-width = <8>;
+	cap-mmc-highspeed;
+	max-frequency = <150000000>;
+	mmc-ddr-1_8v;
+	mmc-hs200-1_8v;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
+	vmmc-supply = <&vcc_io_33>;
+	vqmmc-supply = <&vcc18_emmc>;
+	status = "okay";
+};
Signature · 1 line
2.40.1
Acked-by on v1 1/2
#2 lore raw
In reply to Tianling Shen
Quoted 3 lines · Tianling Shen

Add devicetree binding documentation for the NanoPi R2C Plus.

Signed-off-by Tianling Shen <[email protected]>

subject: missing prefixes (arm: rockchip:)

Drop "doc for"

Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is already stating that these are bindings and it is documentation.

Quoted 2 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

author
#3 lore raw

Hi Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Tianling Shen

Add devicetree binding documentation for the NanoPi R2C Plus.

Quoted 8 lines
Quoted 1 line
Signed-off-by Tianling Shen <[email protected]>

subject: missing prefixes (arm: rockchip:)

Drop "doc for"

Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is already stating that these are bindings and it is documentation.

Thanks for the suggestion! Will send v2 for it.

Regards,
Tianling.

Quoted 9 lines
Quoted 2 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof