Skip to contentSkip to conversation

Staging: rts5208 :rtsx : fixed a brace coding style issue

PATCH In review Deepanshu Kartikey 3 participants 3 messages May 14, 2023 – May 15, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208 :rtsx : fixed a brace coding style issue

Fixed a coding style issue

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..0ab9355873f7 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			//we've got a command, let's do it!
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · Deepanshu Kartikey

Fixed a coding style issue

And you added another one when doing so :(

Please be specific about what you are fixing, and look at your use of spaces in the subject and in the changelog text to verify it all makes sense.

Please fix up and submit a new version of this change.

thanks,

greg k-h

#2 lore raw
In reply to Deepanshu Kartikey
Quoted 12 lines · Deepanshu Kartikey

Fixed a coding style issue

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +0 -0
index 2284a96abcff..0ab9355873f7 100644

drivers/staging/rts5208/rtsx.c static int rtsx_control_thread(void *__dev) · line 403

Quoted 9 lines
drivers/staging/rts5208/rtsx.c +2 -4
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			//we've got a command, let's do it!

Don't change the comment style for no reason. Try to be consistent with the rest of the file.

regards,
dan carpenter