usb: typec: qcom: set pm8150b_typec_res storage-class-specifier to static
PATCH 1/1 usb: typec: qcom: set pm8150b_typec_res storage-class-specifier to static
smatch reports drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
'pm8150b_typec_res' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
--- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +1 -1
@@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };
Signature · 1 line
2.27.0
Quoted 16 lines · Tom Rix
smatch reports
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
'pm8150b_typec_res' was not declared. Should it be static?This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>--- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +0
-0
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c static struct pmic_typec_port_resources pm8150b_port_res = { · line 326
Quoted 8 lines
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +1
-1@@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };
Quoted 7 lines · Tom Rix
smatch reports
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
'pm8150b_typec_res' was not declared. Should it be static?This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>
Quoted 17 lines
--- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +1
-1@@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };
Signature · 1 line
heikki
Quoted 7 lines · Tom Rix
smatch reports
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
'pm8150b_typec_res' was not declared. Should it be static?This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>
Guenter
Quoted 20 lines
--- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +1
-1@@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };Signature · 1 line
2.27.0