Skip to contentSkip to conversation

ASoC: dt-bindings: nau8810: Convert to dtschema

PATCH In review David Lin 3 participants 4 messages May 16, 2023 – May 17, 2023

Subsystems (2)
Device tree bindings ASoC
lore
Share & tools
lore

David Lin

author
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: nau8810: Convert to dtschema

Convert the NAU8810 audio CODEC bindings to DT schema.

Signed-off-by David Lin <[email protected]>
---
 .../devicetree/bindings/sound/nau8810.txt     | 17 -------
 .../bindings/sound/nuvoton,nau8810.yaml       | 45 +++++++++++++++++++
 2 files changed, 45 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nau8810.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml
Documentation/devicetree/bindings/sound/nau8810.txt deleted +0 -17
deleted file mode 100644
index 7deaa452b200..000000000000
@@ -1,17 +0,0 @@
-NAU8810/NAU8812/NAU8814 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-  - compatible : One of "nuvoton,nau8810" or "nuvoton,nau8812" or
-	"nuvoton,nau8814"
-
-  - reg : the I2C address of the device.
-
-Example:
-
-codec: nau8810@1a {
-	compatible = "nuvoton,nau8810";
-	reg = <0x1a>;
-};
Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · David Lin

Convert the NAU8810 audio CODEC bindings to DT schema.

Signed-off-by David Lin <[email protected]>

---

Thank you for your patch. There is something to discuss/improve.

Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml line 41

Quoted 10 lines
Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml new file +10 -0
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            #sound-dai-cells = <0>;

Please put sound-dai-cells at the end. In DTS convention is to have compatible first, reg second.

With this:

Reviewed-by Krzysztof Kozlowski <[email protected]>

Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml line 45

Quoted 4 lines
Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml new file +4 -0
+            compatible = "nuvoton,nau8810";
+            reg = <0x1a>;
+        };
+    };

Best regards,
Krzysztof

author
#2 lore raw
Quoted 22 lines · Krzysztof Kozlowski
Quoted 4 lines · David Lin

Convert the NAU8810 audio CODEC bindings to DT schema.

Signed-off-by David Lin <[email protected]>

---

Thank you for your patch. There is something to discuss/improve.

Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml line 41

Quoted 10 lines
Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml new file +10 -0
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            #sound-dai-cells = <0>;

Please put sound-dai-cells at the end. In DTS convention is to have compatible first, reg second.

With this:

Quoted 8 lines
Reviewed-by Krzysztof Kozlowski <[email protected]>

Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml line 45

Quoted 4 lines
Documentation/devicetree/bindings/sound/nuvoton,nau8810.yaml new file +4 -0
+            compatible = "nuvoton,nau8810";
+            reg = <0x1a>;
+        };
+    };

Best regards,
Krzysztof

From your description, my understanding is since I set required items sequentially, one is compatible, the other is reg.

So the required properties should be filled in first, and the follow up properties are these optional properties.

________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

maintainer
#3 lore raw
In reply to David Lin
Quoted 3 lines · David Lin

Convert the NAU8810 audio CODEC bindings to DT schema.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: nau8810: Convert to dtschema

      commit: bc8c537bd68c6fa99f81609d912115e0a6499fb5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark