irq_work: consolidate arch_irq_work_raise prototypes
Subsystems (7)
PATCH 1/1 irq_work: consolidate arch_irq_work_raise prototypes
From: Arnd Bergmann <[email protected]>
The prototype was hidden on x86, which causes a warning:
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]
Fix this by providing it in only one place that is always visible.
--- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-)
arch/arm/include/asm/irq_work.h +0 -2
@@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) return is_smp(); } -extern void arch_irq_work_raise (void ); -#endif /* _ASM_ARM_IRQ_WORK_H */
arch/arm64/include/asm/irq_work.h +0 -2
@@ -2,8 +2,6 @@#ifndef __ASM_IRQ_WORK_H#define __ASM_IRQ_WORK_H -extern void arch_irq_work_raise (void ); -static inline bool arch_irq_work_has_interrupt (void ) {return true;
arch/csky/include/asm/irq_work.h +1 -1
@@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void ); +#endif /* __ASM_CSKY_IRQ_WORK_H */
arch/powerpc/include/asm/irq_work.h +0 -1
@@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void );#endif /* _ASM_POWERPC_IRQ_WORK_H */
arch/riscv/include/asm/irq_work.h +1 -1
@@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return IS_ENABLED (CONFIG_SMP ); } -extern void arch_irq_work_raise (void ); +#endif /* _ASM_RISCV_IRQ_WORK_H */
arch/s390/include/asm/irq_work.h +0 -2
@@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise (void ); -#endif /* _ASM_S390_IRQ_WORK_H */
arch/x86/include/asm/irq_work.h +0 -1
@@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) {return boot_cpu_has (X86_FEATURE_APIC ); } -extern void arch_irq_work_raise (void );#else static inline bool arch_irq_work_has_interrupt (void ) {
include/linux/irq_work.h +3 -0
@@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work);void irq_work_run (void );bool irq_work_needs_cpu (void );void irq_work_single (void *arg); + +void arch_irq_work_raise (void ); +#else static inline bool irq_work_needs_cpu (void ) {return false; }static inline void irq_work_run (void ) { }
Signature · 1 line
2.39.2
Quoted 8 lines · On Tue, 16 May 2023 13:02:31 PDT (-0700), [email protected] wrote:
From: Arnd Bergmann <[email protected]>
The prototype was hidden on x86, which causes a warning:
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]Fix this by providing it in only one place that is always visible.
Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +-
Quoted 90 lines
arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-)arch/arm/include/asm/irq_work.h +0
-2@@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) return is_smp(); } -extern void arch_irq_work_raise (void ); -#endif /* _ASM_ARM_IRQ_WORK_H */ arch/arm64/include/asm/irq_work.h +0
-2@@ -2,8 +2,6 @@#ifndef __ASM_IRQ_WORK_H#define __ASM_IRQ_WORK_H -extern void arch_irq_work_raise (void ); -static inline bool arch_irq_work_has_interrupt (void ) {return true;arch/csky/include/asm/irq_work.h +1
-1@@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void ); +#endif /* __ASM_CSKY_IRQ_WORK_H */ arch/powerpc/include/asm/irq_work.h +0
-1@@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void );#endif /* _ASM_POWERPC_IRQ_WORK_H */ arch/riscv/include/asm/irq_work.h +1
-1@@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return IS_ENABLED (CONFIG_SMP ); } -extern void arch_irq_work_raise (void ); +#endif /* _ASM_RISCV_IRQ_WORK_H */ arch/s390/include/asm/irq_work.h +0
-2@@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise (void ); -#endif /* _ASM_S390_IRQ_WORK_H */ arch/x86/include/asm/irq_work.h +0
-1@@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) {return boot_cpu_has (X86_FEATURE_APIC ); } -extern void arch_irq_work_raise (void );#else static inline bool arch_irq_work_has_interrupt (void ) {include/linux/irq_work.h +0
-0
include/linux/irq_work.h void irq_work_sync(struct irq_work *work); · line 74
Quoted 9 lines
include/linux/irq_work.h +3
-0@@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work);void irq_work_run (void );bool irq_work_needs_cpu (void );void irq_work_single (void *arg); + +void arch_irq_work_raise (void ); +#else static inline bool irq_work_needs_cpu (void ) {return false; }static inline void irq_work_run (void ) { }
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 19 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The prototype was hidden on x86, which causes a warning:
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]Fix this by providing it in only one place that is always visible.
Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-)
...
Quoted 11 lines
arch/s390/include/asm/irq_work.h +0
-2@@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise (void ); -#endif /* _ASM_S390_IRQ_WORK_H */
...
Quoted 5 lines
include/linux/irq_work.h +0
-0
include/linux/irq_work.h void irq_work_sync(struct irq_work *work); · line 74
Quoted 9 lines
include/linux/irq_work.h +3
-0@@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work);void irq_work_run (void );bool irq_work_needs_cpu (void );void irq_work_single (void *arg); + +void arch_irq_work_raise (void ); +#else static inline bool irq_work_needs_cpu (void ) {return false; }static inline void irq_work_run (void ) { }
For s390:
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 50 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The prototype was hidden on x86, which causes a warning:
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]Fix this by providing it in only one place that is always visible.
Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-)arch/arm/include/asm/irq_work.h +0
-2@@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) return is_smp(); } -extern void arch_irq_work_raise (void ); -#endif /* _ASM_ARM_IRQ_WORK_H */ arch/arm64/include/asm/irq_work.h +0
-2@@ -2,8 +2,6 @@#ifndef __ASM_IRQ_WORK_H#define __ASM_IRQ_WORK_H -extern void arch_irq_work_raise (void ); -static inline bool arch_irq_work_has_interrupt (void ) {return true;arch/csky/include/asm/irq_work.h +0
-0
arch/csky/include/asm/irq_work.h static inline bool arch_irq_work_has_interrupt(void) · line 10
Quoted 5 lines
arch/csky/include/asm/irq_work.h +1
-1@@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void ); +
Quoted 63 lines
arch/csky/include/asm/irq_work.h +0
-0#endif /* __ASM_CSKY_IRQ_WORK_H */ arch/powerpc/include/asm/irq_work.h +0
-1@@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return true; } -extern void arch_irq_work_raise (void );#endif /* _ASM_POWERPC_IRQ_WORK_H */ arch/riscv/include/asm/irq_work.h +1
-1@@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) {return IS_ENABLED (CONFIG_SMP ); } -extern void arch_irq_work_raise (void ); +#endif /* _ASM_RISCV_IRQ_WORK_H */ arch/s390/include/asm/irq_work.h +0
-2@@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise (void ); -#endif /* _ASM_S390_IRQ_WORK_H */ arch/x86/include/asm/irq_work.h +0
-1@@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) {return boot_cpu_has (X86_FEATURE_APIC ); } -extern void arch_irq_work_raise (void );#else static inline bool arch_irq_work_has_interrupt (void ) {include/linux/irq_work.h +3
-1@@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work);void irq_work_run (void );bool irq_work_needs_cpu (void );void irq_work_single (void *arg); + +void arch_irq_work_raise (void ); +#else static inline bool irq_work_needs_cpu (void ) {return false; }static inline void irq_work_run (void ) { } --2.39.2
Signature · 2 lines
Best Regards Guo Ren
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The prototype was hidden on x86, which causes a warning:
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]Fix this by providing it in only one place that is always visible.
Signed-off-by Arnd Bergmann <[email protected]>