hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.
PATCH 1/1 hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.
From: llyyr <[email protected]>
This value was found on a MSI Z690-A PRO DDR5 with NCT6687D.
--- drivers/hwmon/nct6683.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/hwmon/nct6683.c +3 -0
@@ -173,6 +173,7 @@ superio_exit(int ioreg)#define NCT6683_CUSTOMER_ID_INTEL 0x805#define NCT6683_CUSTOMER_ID_MITAC 0xa0e#define NCT6683_CUSTOMER_ID_MSI 0x201 +#define NCT6683_CUSTOMER_ID_MSI2 0x200#define NCT6683_CUSTOMER_ID_ASROCK 0xe2c#define NCT6683_CUSTOMER_ID_ASROCK2 0xe1b
@@ -1220,6 +1221,8 @@ static int nct6683_probe(struct platform_device *pdev)break ;case NCT6683_CUSTOMER_ID_MSI :break ; +case NCT6683_CUSTOMER_ID_MSI2 : +break ;case NCT6683_CUSTOMER_ID_ASROCK :break ;case NCT6683_CUSTOMER_ID_ASROCK2 :
Signature · 1 line
2.40.1
Quoted 2 lines · Gopal Prasad
From: llyyr <[email protected]>
The above is still wrong. Never mind, I fixed that.
Quoted 3 lines
This value was found on a MSI Z690-A PRO DDR5 with NCT6687D.
Signed-off-by Gopal Prasad <[email protected]>
Applied. In the future, please version your patches and provide change logs.
Thanks,
Guenter
Quoted 5 lines · Guenter Roeck
Quoted 2 lines · Gopal Prasad
From: llyyr <[email protected]>
The above is still wrong. Never mind, I fixed that.
I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are allowed [1]. Is the problem here that my online handle not have a first name and a last name part?
Guenter Roeck
maintainerQuoted 5 lines · llyyr
Quoted 4 lines · Guenter Roeck
Quoted 2 lines · Gopal Prasad
From: llyyr <[email protected]>
Quoted 8 lines
Quoted 1 line
The above is still wrong. Never mind, I fixed that.
I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are allowed [1]. Is the problem here that my online handle not have a first name and a last name part?
"... using a known identity (sorry, no anonymous contributions.) "
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Are you making that up ?
Guenter
Quoted 15 lines · Guenter Roeck
Quoted 5 lines · llyyr
Quoted 4 lines · Guenter Roeck
Quoted 2 lines · Gopal Prasad
From: llyyr <[email protected]>
Quoted 8 lines
Quoted 1 line
The above is still wrong. Never mind, I fixed that.
I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are allowed [1]. Is the problem here that my online handle not have a first name and a last name part?
Quoted 6 lines
"... using a known identity (sorry, no anonymous contributions.)"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Are you making that up ?
Guenter
An online handle is not an anonymous contribution. Pseudonyms were explicitly mentioned in a previous version but removed later [1].
Besides, there are plenty of linux contributors commiting under pseudonyms like Asahi Lina.
Quoted 15 lines · Guenter Roeck
Quoted 5 lines · llyyr
Quoted 4 lines · Guenter Roeck
Quoted 2 lines · Gopal Prasad
From: llyyr <[email protected]>
Quoted 8 lines
Quoted 1 line
The above is still wrong. Never mind, I fixed that.
I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are allowed [1]. Is the problem here that my online handle not have a first name and a last name part?
Quoted 6 lines
"... using a known identity (sorry, no anonymous contributions.)"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Are you making that up ?
Guenter
Please see commit d4563201f33a022fc0353033d9dfeb1606a88330 [1] and DCO Guidelines [2]
Quoted 1 line
And despite the language, we've always accepted nicknames and
that language was never meant to be any kind of exclusionary wording.
Quoted 1 line
A real name does not require a legal name, nor a birth name, nor any name that appears on an official ID (e.g. a passport). Your real name is the name you convey to people in the community for them to use to identify you as you. The key concern is that your identification is sufficient enough to contact you if an issue were to arise in the future about your contribution.
* https://github.com/torvalds/linux/commit/d4563201f33a022fc0353033d9dfeb1606a88330
* https://github.com/cncf/foundation/blob/main/dco-guidelines.md