Skip to contentSkip to conversation

ARM64: dts: rk3399: Fix USB dwc3 nodes unit names

PATCH New UtsavBalar1231 1 participant 2 messages May 17, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM64: dts: rk3399: Fix USB dwc3 nodes unit names

Not every parent node is required to have register addresses, but if a parent node includes the register address in its node name without specifying a "reg" property in its body,
it will result in the generation of following warning messages:

Warning (unit_address_vs_reg): Node /usb@fe800000 has a unit name, but no reg property Warning (unit_address_vs_reg): Node /usb@fe900000 has a unit name, but no reg property

Fixes 7144224f2c2b ("arm64: dts: rockchip: support dwc3 USB for rk3399")
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399.dtsi +2 -2
index 928948e7c7bb..bae257fa957a 100644
@@ -430,7 +430,7 @@ debug@fe710000 {
 		cpu = <&cpu_b1>;
 	};
 
-	usbdrd3_0: usb@fe800000 {
+	usbdrd3_0: usbdrd3-0 {
 		compatible = "rockchip,rk3399-dwc3";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -466,7 +466,7 @@ usbdrd_dwc3_0: usb@fe800000 {
 		};
 	};
 
-	usbdrd3_1: usb@fe900000 {
+	usbdrd3_1: usbdrd3-1 {
 		compatible = "rockchip,rk3399-dwc3";
 		#address-cells = <2>;
 		#size-cells = <2>;
Signature · 7 lines
2.39.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

PATCH 2/2 ARM64: dts: rk3399: Fix missing PCI reg property warning

DTC complains about missing PCI reg property on the rk3399 PCIe interrupt-controller.

This fixes following warning:
Warning (pci_device_reg): Node /pcie@f8000000/interrupt-controller missing PCI reg property

Fixes 85aaa5745952 ("arm64: dts: rockchip: add the PCIe controller support for RK3399")
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3399.dtsi +1 -0
index bae257fa957a..14273aee42a8 100644
@@ -237,6 +237,7 @@ pcie0: pcie@f8000000 {
 			     <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH 0>,
 			     <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH 0>;
 		interrupt-names = "sys", "legacy", "client";
+		interrupt-parent = <&gic>;
 		interrupt-map-mask = <0 0 0 7>;
 		interrupt-map = <0 0 0 1 &pcie0_intc 0>,
 				<0 0 0 2 &pcie0_intc 1>,
Signature · 7 lines
2.39.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip