Skip to contentSkip to conversation

ACPI: video: Add 2 new backlight=native DMI quirks

PATCH In review Hans de Goede 2 participants 4 messages May 17, 2023 – May 18, 2023 ACPI

lore
Share & tools
lore
#0 lore raw

cover ACPI: video: Add 2 new backlight=native DMI quirks

Hi Rafael,

Here is a series adding 2 new backlight=native DMI quirks to video_detect.c note the first patch is a resend for a patch which seems to have fallen through the cracks. I've included that here again since patch 2/2 will show a conflict if 1/2 is nor merged first.

Regards,

Hans

p.s.

Talking about unmerged patches, FYI I also have the following series + 2 separate patches still pending:

https://lore.kernel.org/linux-acpi/[email protected]/
https://lore.kernel.org/linux-acpi/[email protected]/
https://lore.kernel.org/linux-acpi/[email protected]/

Hans de Goede (2):
ACPI: video: Add backlight=native DMI quirk for Apple iMac11,3
ACPI: video: Add backlight=native DMI quirk for Lenovo ThinkPad X131e

    (3371 AMD version)
 drivers/acpi/video_detect.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Signature · 1 line
2.40.1
#1 lore raw

PATCH 1/2 ACPI: video: Add backlight=native DMI quirk for Apple iMac11,3

Linux defaults to picking the non-working ACPI video backlight interface on the Apple iMac11,3 .

Add a DMI quirk to pick the working native radeon_bl0 interface instead.

---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video_detect.c +8 -0
index bcc25d457581..61586caebb01 100644
@@ -470,6 +470,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
 		},
 	},
+	{
+	 .callback = video_detect_force_native,
+	 /* Apple iMac11,3 */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "iMac11,3"),
+		},
+	},
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
 	 .callback = video_detect_force_native,
Signature · 1 line
2.40.1
#2 lore raw

PATCH 2/2 ACPI: video: Add backlight=native DMI quirk for Lenovo ThinkPad X131e (3371 AMD version)

In reply to Hans de Goede

Linux defaults to picking the non-working ACPI video backlight interface on the Lenovo ThinkPad X131e (3371 AMD version).

Add a DMI quirk to pick the working native radeon_bl0 interface instead.

---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video_detect.c +8 -0
index 61586caebb01..b87783c5872d 100644
@@ -470,6 +470,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
 		},
 	},
+	{
+	 .callback = video_detect_force_native,
+	 /* Lenovo ThinkPad X131e (3371 AMD version) */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "3371"),
+		},
+	},
 	{
 	 .callback = video_detect_force_native,
 	 /* Apple iMac11,3 */
Signature · 1 line
2.40.1
#3 lore raw
In reply to Hans de Goede

Hi Hans,

Quoted 6 lines · Hans de Goede

Hi Rafael,

Here is a series adding 2 new backlight=native DMI quirks to video_detect.c note the first patch is a resend for a patch which seems to have fallen through the cracks.

It hasn't, but my queue processing speed is not fantastic ATM.

Quoted 2 lines

I've included that here again since patch 2/2 will show a conflict if 1/2 is nor merged first.

Both applied as 6.5 material, thanks!

Quoted 8 lines

p.s.

Talking about unmerged patches, FYI I also have the following series + 2 separate patches still pending:

https://lore.kernel.org/linux-acpi/[email protected]/
https://lore.kernel.org/linux-acpi/[email protected]/
https://lore.kernel.org/linux-acpi/[email protected]/

I'll get to these.