net: rtl8169: add depends on PCI
PATCH 1/1 net: rtl8169: add depends on PCI
The rtl8169 driver uses calls to dm_pci_bus_to_phys, which are compiled under CONFIG_PCI.
Without CONFIG_PCI, this happens:
drivers/net/rtl8169.o: in function `rtl_recv_common':drivers/net/rtl8169.c:555: undefined reference to `dm_pci_bus_to_phys'
It is only natural that this driver depends on CONFIG_PCI then. The device does not work connected in another way anyway, and the driver does not assume anything else at this moment.
--- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
@@ -633,6 +633,7 @@ config RTL8139 config RTL8169 bool "Realtek 8169 series Ethernet controller driver" + depends on PCI help This driver supports Realtek 8169 series gigabit ethernet family of PCI/PCIe chipsets/adapters.
Signature · 1 line
2.34.1
Quoted 31 lines · Eugen Hristev
The rtl8169 driver uses calls to
dm_pci_bus_to_phys, which are compiled underCONFIG_PCI.Without
CONFIG_PCI, this happens:
drivers/net/rtl8169.o: in function `rtl_recv_common':drivers/net/rtl8169.c:555: undefined reference to `dm_pci_bus_to_phys'It is only natural that this driver depends on
CONFIG_PCIthen. The device does not work connected in another way anyway, and the driver does not assume anything else at this moment.Signed-off-by Eugen Hristev <[email protected]>--- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/net/Kconfig +1
-1@@ -633,6 +633,7 @@ config RTL8139 config RTL8169 bool "Realtek 8169 series Ethernet controller driver" + depends on PCI help This driver supports Realtek 8169 series gigabit ethernet family of PCI/PCIe chipsets/adapters. --
Quoted 2 lines
2.34.1
Quoted 8 lines · Eugen Hristev
The rtl8169 driver uses calls to
dm_pci_bus_to_phys, which are compiled underCONFIG_PCI.Without
CONFIG_PCI, this happens:
drivers/net/rtl8169.o: in function `rtl_recv_common':drivers/net/rtl8169.c:555: undefined reference to `dm_pci_bus_to_phys'
Quoted 6 lines
It is only natural that this driver depends on
CONFIG_PCIthen. The device does not work connected in another way anyway, and the driver does not assume anything else at this moment.Signed-off-by Eugen Hristev <[email protected]>Reviewed-by Ramon Fried <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom