dax: fix missing-prototype warnings
PATCH 1/1 dax: fix missing-prototype warnings
From: Arnd Bergmann <[email protected]>
dev_dax_probe declaration for this function was removed with the only caller outside of device.c. Mark it static to avoid a W=1 warning:drivers/dax/device.c:399:5: error: no previous prototype for 'dev_dax_probe'
Similarly, run_dax() causes a warning, but this one is because the declaration needs to be included:
drivers/dax/super.c:337:6: error: no previous prototype for 'run_dax'
--- drivers/dax/device.c | 3 +-- drivers/dax/super.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/dax/device.c +1 -2
@@ -396,7 +396,7 @@ static void dev_dax_kill(void *dev_dax)kill_dev_dax (dev_dax); } -int dev_dax_probe (struct dev_dax *dev_dax) +static int dev_dax_probe (struct dev_dax *dev_dax) {struct dax_device *dax_dev = dev_dax->dax_dev;struct device *dev = &dev_dax->dev;
@@ -471,7 +471,6 @@ int dev_dax_probe(struct dev_dax *dev_dax)run_dax (dax_dev);return devm_add_action_or_reset (dev, dev_dax_kill, dev_dax); } -EXPORT_SYMBOL_GPL (dev_dax_probe);static struct dax_device_driver device_dax_driver = { .probe = dev_dax_probe,
drivers/dax/super.c +1 -0
@@ -14,6 +14,7 @@#include <linux/dax.h> #include <linux/fs.h> #include "dax-private.h" +#include "bus.h" /** * struct dax_device - anchor object for dax services
Signature · 1 line
2.39.2
Quoted 34 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
dev_dax_probedeclaration for this function was removed with the only caller outside ofdevice.c. Mark it static to avoid a W=1 warning:drivers/dax/device.c:399:5: error: no previous prototype for 'dev_dax_probe'Similarly,
run_dax()causes a warning, but this one is because the declaration needs to be included:
drivers/dax/super.c:337:6: error: no previous prototype for 'run_dax'Fixes 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/dax/device.c | 3 +-- drivers/dax/super.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-)drivers/dax/device.c +1
-1@@ -396,7 +396,7 @@ static void dev_dax_kill(void *dev_dax)kill_dev_dax (dev_dax); } -int dev_dax_probe (struct dev_dax *dev_dax) +static int dev_dax_probe (struct dev_dax *dev_dax) {struct dax_device *dax_dev = dev_dax->dax_dev;struct device *dev = &dev_dax->dev;
drivers/dax/device.c int dev_dax_probe(struct dev_dax *dev_dax) · line 476
Quoted 7 lines
drivers/dax/device.c +0
-1@@ -471,7 +471,6 @@ int dev_dax_probe(struct dev_dax *dev_dax)run_dax (dax_dev);return devm_add_action_or_reset (dev, dev_dax_kill, dev_dax); } -EXPORT_SYMBOL_GPL (dev_dax_probe);static struct dax_device_driver device_dax_driver = { .probe = dev_dax_probe,
This hunk looks good.
drivers/dax/super.c line 17
Quoted 9 lines
drivers/dax/super.c +1
-0@@ -14,6 +14,7 @@#include <linux/dax.h> #include <linux/fs.h> #include "dax-private.h" +#include "bus.h"
This one came up before, and IIRC last time I said lets just move the run_dax() prototype to dax-private.h.
https://lore.kernel.org/all/YiqF1a9VNiSWI5j0@iweiny-desk3
I can fix that up when applying.