Skip to contentSkip to conversation

mm/page_owner: set page_owner_* storage-class-specifier to static

PATCH New Tom Rix 1 participant 1 message May 18, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 mm/page_owner: set page_owner_* storage-class-specifier to static

smatch reports
mm/page_owner.c:739:30: warning: symbol
'page_owner_stack_operations' was not declared. Should it be static?
mm/page_owner.c:748:5: warning: symbol
'page_owner_threshold_get' was not declared. Should it be static?
mm/page_owner.c:754:5: warning: symbol
'page_owner_threshold_set' was not declared. Should it be static?

This variable and functions are only used in their defining file, so it should be static

---
 mm/page_owner.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/page_owner.c +3 -3
index 28c519fc9372..f37c0b722b51 100644
@@ -736,7 +736,7 @@ static int page_owner_stack_open(struct inode *inode, struct file *file)
 				sizeof(unsigned long));
 }
 
-const struct file_operations page_owner_stack_operations = {
+static const struct file_operations page_owner_stack_operations = {
 	.open           = page_owner_stack_open,
 	.read           = seq_read,
 	.llseek         = seq_lseek,
@@ -745,13 +745,13 @@ const struct file_operations page_owner_stack_operations = {
 
 unsigned long page_owner_stack_threshold;
 
-int page_owner_threshold_get(void *data, u64 *val)
+static int page_owner_threshold_get(void *data, u64 *val)
 {
 	*val = page_owner_stack_threshold;
 	return 0;
 }
 
-int page_owner_threshold_set(void *data, u64 val)
+static int page_owner_threshold_set(void *data, u64 val)
 {
 	page_owner_stack_threshold = val;
 	return 0;
Signature · 1 line
2.27.0