Skip to contentSkip to conversation

Staging: rts5208: rtsx: Moved else statement to same line with else if

PATCH New Deepanshu Kartikey 1 participant 2 messages May 19, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208: rtsx: Moved else statement to same line with else if

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..47dacef0aaf8 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 Staging: rts5208: rtsx: Moved else statement to same line with else if

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..47dacef0aaf8 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1