Skip to contentSkip to conversation

Staging: rts5208: rtsx: Moved else statement to same line with else if

PATCH New Deepanshu Kartikey 2 participants 4 messages May 19, 2023 – May 27, 2023 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208: rtsx: Moved else statement to same line with else if

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

---
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..47dacef0aaf8 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 Staging: rts5208: rtsx: Moved else statement to same line with else if

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

---
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..47dacef0aaf8 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1

A message that is not in the archive (sent off-list or not yet received): CADhLXY6HuOZK3atwP8FBXU2Yxojkx9SKL87L3dg_SBfrPVN-Cg@mail.gmail.com

maintainer
#3 lore raw
Quoted 3 lines · Deepanshu Kartikey

Hi Greg,

Any update ?

Please do not top post.

Quoted 2 lines

On Fri, May 19, 2023 at 3:50 PM Deepanshu Kartikey <[email protected]> wrote:

This was one day later, please realize that coding style cleanups are usually at the bottom of my review lists (for obvious reasons). You only need to resend if I haven't responded within 2 weeks.

Take the time to do other work, like review other patch submissions, making my (and other maintainers), lives easier. Don't just ask others to do work for you :)

thanks,

greg k-h

maintainer
#4 lore raw
In reply to Deepanshu Kartikey
Quoted 9 lines · Deepanshu Kartikey

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

---
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

I have 2 v2 patches in my mailbox, which are different, so obviously one of them is lying. Please fix up and send a v4.

thanks,

greg k-h