Skip to contentSkip to conversation

crypto/Kconfig: warn about performance overhead of CRYPTO_STATS

PATCH In review Eric Biggers 3 participants 3 messages May 20, 2023 – May 24, 2023 Crypto API

lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 crypto/Kconfig: warn about performance overhead of CRYPTO_STATS

From: Eric Biggers <[email protected]>

Make the help text for CRYPTO_STATS explicitly mention that it reduces the performance of the crypto API.

Signed-off-by Eric Biggers <[email protected]>
---
 crypto/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
crypto/Kconfig +3 -0
index 42751d63cd4d9..fdf3742f1106b 100644
@@ -1393,6 +1393,9 @@ config CRYPTO_STATS
 	help
 	  Enable the gathering of crypto stats.
 
+	  Enabling this option reduces the performance of the crypto API.  It
+	  should only be enabled when there is actually a use case for it.
+
 	  This collects data sizes, numbers of requests, and numbers
 	  of errors processed by:
 	  - AEAD ciphers (encrypt, decrypt)

base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c

Signature · 1 line
2.40.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Make the help text for CRYPTO_STATS explicitly mention that it reduces the performance of the crypto API.

Signed-off-by Eric Biggers <[email protected]>
Acked-by Ard Biesheuvel <[email protected]>
Quoted 23 lines
---
 crypto/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
crypto/Kconfig +3 -0
index 42751d63cd4d9..fdf3742f1106b 100644
@@ -1393,6 +1393,9 @@ config CRYPTO_STATS
        help
          Enable the gathering of crypto stats.
 
+         Enabling this option reduces the performance of the crypto API.  It
+         should only be enabled when there is actually a use case for it.
+
          This collects data sizes, numbers of requests, and numbers
          of errors processed by:
          - AEAD ciphers (encrypt, decrypt)

base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c --
2.40.1

maintainer
#2 lore raw
In reply to Eric Biggers
Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Make the help text for CRYPTO_STATS explicitly mention that it reduces the performance of the crypto API.

Signed-off-by Eric Biggers <[email protected]>

---
crypto/Kconfig | 3 +++

1 file changed, 3 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt