PCI: imx6: Use a more specific i.MX6SX GPR compatible
Subsystems (8)
Fabio Estevam
reviewerPATCH v6 1/5 PCI: imx6: Use a more specific i.MX6SX GPR compatible
From: Fabio Estevam <[email protected]>
On the i.MX6SX case, the more specific GPR (General Purpose Register) compatible, "fsl,imx6sx-iomuxc-gpr", can be used instead of the more generic "fsl,imx6q-iomuxc-gpr" one.
Switch to using the more specific i.MX6SX GPR compatible.
The motivation for this change is to allow the introduction of i.MX6SX GPR driver that will be used to control the i.MX6SX LDB bridge.
Old DTBs are unaffected by this change.
---
Changes since v5:
- Newly introduced.
drivers/pci/controller/dwc/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/pci-imx6.c +1 -1
@@ -1460,7 +1460,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { .flags = IMX6_PCIE_FLAG_IMX6_PHY |IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE | IMX6_PCIE_FLAG_SUPPORTS_SUSPEND, - .gpr = "fsl,imx6q-iomuxc-gpr", + .gpr = "fsl,imx6sx-iomuxc-gpr", }, [IMX6QP] = { .variant = IMX6QP,
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH v6 2/5 dt-bindings: display: bridge: ldb: Adjust imx6sx entries
From: Fabio Estevam <[email protected]>
On the i.MX6SX there is a single entry for 'reg', so add some logic to reflect that.
---
Dependency: This depends on bd60d98a11da ("dt-bindings: display: bridge: ldb: Adjust imx6sx entries"), which is available on linux-next.
Changes since v5:
- Dropped reg-names for imx6sx (Marek).
- Indicated the dependency to avoid error when Rob's robot runs.
.../bindings/display/bridge/fsl,ldb.yaml | 24 ++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml +21 -3
@@ -28,12 +28,11 @@ properties: const: ldb reg: + minItems: 1 maxItems: 2 reg-names: - items: - - const: ldb - - const: lvds + maxItems: 2 ports: $ref: /schemas/graph.yaml#/properties/ports
@@ -57,6 +56,7 @@ properties: required: - compatible + - reg - clocks - ports
@@ -74,6 +74,24 @@ allOf: properties: port@2: false + - if: + properties: + compatible: + contains: + const: fsl,imx6sx-ldb + then: + properties: + reg: + maxItems: 1 + else: + properties: + reg: + minItems: 2 + reg-names: + items: + - const: ldb + - const: lvds + additionalProperties: false examples:
Signature · 1 line
2.34.1
Re: [PATCH v6 2/5] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX there is a single entry for 'reg', so add some logic to reflect that.
Signed-off-by Fabio Estevam <[email protected]>
Thanks,
Conor.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v6 2/5] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
In reply to Fabio EstevamQuoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX there is a single entry for 'reg', so add some logic to reflect that.
Signed-off-by Fabio Estevam <[email protected]>
Fabio Estevam
reviewerPATCH v6 3/5 dt-bindings: soc: Add i.MX6SX General Purpose Register
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
The i.MX6SX General Purpose Registers is a set of register that serves various different purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18, can be used to configure the LDB block.
---
Changes since v5:
- Dropped "fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek).
.../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 82 +++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml new file +82 -0
@@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX6SX General Purpose Register + +maintainers: + - Fabio Estevam <[email protected]> + +description: + The i.MX6SX General Purpose Registers is a set of register that serves + for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18, + can be used to configure the LDB block. + +properties: + compatible: + items: + - const: fsl,imx6sx-iomuxc-gpr + - const: syscon + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + + bridge@18: + type: object + $ref: /schemas/display/bridge/fsl,ldb.yaml# + unevaluatedProperties: false + +required: + - compatible + - reg + - '#address-cells' + - '#size-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx6sx-clock.h> + + syscon@20e4000 { + compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + reg = <0x020e4000 0x4000>; + #address-cells = <1>; + #size-cells = <1>; + + bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + ldb_from_lcdif1: endpoint { + remote-endpoint = <&lcdif1_to_ldb>; + }; + }; + + port@1 { + reg = <1>; + + ldb_lvds_ch0: endpoint { + }; + }; + }; + }; + }; +...
Signature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The i.MX6SX General Purpose Registers is a set of register that serves various different purposes and in particular,
IOMUXC_GPR_GPR6, at offset0x18, can be used to configure the LDB block.
Quoted 9 lines
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v5:
- Dropped "fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek)..../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 82 +++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Fabio Estevam
reviewerRe: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
Quoted 8 lines · Rob Herring
My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
Same comment as in 2/5 applies here too:
Dependency: This depends on bd60d98a11da ("dt-bindings: display:
bridge: ldb: Adjust imx6sx entries"),
which is available on linux-next.
I missed adding such a comment here.
Rob Herring
maintainerRe: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
Quoted 11 lines · Fabio Estevam
Quoted 8 lines · Rob Herring
My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
Quoted 5 lines
Same comment as in 2/5 applies here too:
Dependency: This depends on
bd60d98a11da("dt-bindings: display:
bridge: ldb: Adjust imx6sx entries"),
which is available on linux-next.
No such commit hash nor is Documentation/bindings/display/bridge/fsl,ldb.yaml a file in next.
Rob
Fabio Estevam
reviewerRe: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
Quoted 2 lines · Rob Herring
No such commit hash nor is
Documentation/bindings/display/bridge/fsl,ldb.yamla file in next.
Correct has in linux-next is f85f2ce57783913a23f21b9d3d03a27357c07c3a:
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
In reply to Fabio EstevamQuoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The i.MX6SX General Purpose Registers is a set of register that serves various different purposes and in particular,
IOMUXC_GPR_GPR6, at offset0x18, can be used to configure the LDB block.Signed-off-by Fabio Estevam <[email protected]>---
Changes since v5:
- Dropped "fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek).
Please, especially when sending more than one version in a day, keep the changelogs from all of the versions in here.
What you have seems grand,
Thanks,
Conor.
Re: [PATCH v6 3/5] dt-bindings: soc: Add i.MX6SX General Purpose Register
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The i.MX6SX General Purpose Registers is a set of register that serves various different purposes and in particular,
IOMUXC_GPR_GPR6, at offset0x18, can be used to configure the LDB block.Signed-off-by Fabio Estevam <[email protected]>
Fabio Estevam
reviewerPATCH v6 4/5 ARM: dts: imx6sx: Add LDB support
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
i.MX6SX has an LVDS controller that is connected to the eLCDIF.
Add support for it.
---
Changes since v5:
- Dropped fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek).
arch/arm/boot/dts/imx6sx.dtsi | 43 ++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx6sx.dtsi +40 -3
@@ -841,10 +841,39 @@ iomuxc: pinctrl@20e0000 { reg = <0x020e0000 0x4000>; }; - gpr: iomuxc-gpr@20e4000 { - compatible = "fsl,imx6sx-iomuxc-gpr", - "fsl,imx6q-iomuxc-gpr", "syscon"; + gpr: syscon@20e4000 { + compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + #address-cells = <1>; + #size-cells = <1>; reg = <0x020e4000 0x4000>; + + lvds_bridge: bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb"; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + ldb_from_lcdif1: endpoint { + remote-endpoint = <&lcdif1_to_ldb>; + }; + }; + + port@1 { + reg = <1>; + + ldb_lvds_ch0: endpoint { + }; + }; + }; + }; }; sdma: dma-controller@20ec000 {
@@ -1278,6 +1307,14 @@ lcdif1: lcdif@2220000 { clock-names = "pix", "axi", "disp_axi"; power-domains = <&pd_disp>; status = "disabled"; + + ports { + port { + lcdif1_to_ldb: endpoint { + remote-endpoint = <&ldb_from_lcdif1>; + }; + }; + }; }; lcdif2: lcdif@2224000 {
Signature · 1 line
2.34.1
Re: [PATCH v6 4/5] ARM: dts: imx6sx: Add LDB support
Quoted 26 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
i.MX6SX has an LVDS controller that is connected to the eLCDIF.
Add support for it.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v5:
- Dropped fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek).arch/arm/boot/dts/imx6sx.dtsi | 43 ++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-)arch/arm/boot/dts/imx6sx.dtsi +1
-3@@ -841,10 +841,39 @@ iomuxc: pinctrl@20e0000 { reg = <0x020e0000 0x4000>; }; - gpr: iomuxc-gpr@20e4000 { - compatible = "fsl,imx6sx-iomuxc-gpr", - "fsl,imx6q-iomuxc-gpr", "syscon"; + gpr: syscon@20e4000 {
arch/arm/boot/dts/imx6sx.dtsi iomuxc: pinctrl@20e0000 { · line 854
Quoted 10 lines
arch/arm/boot/dts/imx6sx.dtsi +9
-0+ compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + #address-cells = <1>; + #size-cells = <1>; reg = <0x020e4000 0x4000>; + + lvds_bridge: bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb";
Since there is only once clock, is this clock-names even needed ?
Fabio Estevam
reviewerRe: [PATCH v6 4/5] ARM: dts: imx6sx: Add LDB support
Hi Marek,
Quoted 7 lines · Marek Vasut
arch/arm/boot/dts/imx6sx.dtsi iomuxc: pinctrl@20e0000 { · line 854
Quoted 5 lines
arch/arm/boot/dts/imx6sx.dtsi +5
-0+ lvds_bridge: bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb";Since there is only once clock, is this clock-names even needed ?
As of today, clock-names is needed because drivers/gpu/drm/bridge/fsl-ldb.c retrieves the ldb clock like this:
fsl_ldb->clk = devm_clk_get(dev, "ldb")
If you want, I can change it to fsl_ldb->clk = devm_clk_get(dev, NULL) and also remove clock-names from
fsl,ldb.yaml and from imx8mp.dtsi.
Or this cleanup can also be a follow-up patch. Just let me know what you prefer.
Re: [PATCH v6 4/5] ARM: dts: imx6sx: Add LDB support
Quoted 15 lines · Fabio Estevam
Hi Marek,
Quoted 7 lines · Marek Vasut
arch/arm/boot/dts/imx6sx.dtsi iomuxc: pinctrl@20e0000 { · line 854
Quoted 5 lines
arch/arm/boot/dts/imx6sx.dtsi +5
-0+ lvds_bridge: bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb";Since there is only once clock, is this clock-names even needed ?
As of today, clock-names is needed because
drivers/gpu/drm/bridge/fsl-ldb.cretrieves the ldb clock like this:
Quoted 7 lines
fsl_ldb->clk=devm_clk_get(dev, "ldb")If you want, I can change it to
fsl_ldb->clk=devm_clk_get(dev, NULL)and also remove clock-names from
fsl,ldb.yaml and fromimx8mp.dtsi.Or this cleanup can also be a follow-up patch. Just let me know what you prefer.
I think a follow up patch would be perfectly fine , let's not grow the series unnecessarily .
Fabio Estevam
reviewerPATCH v6 5/5 soc: imx: imx6sx-gpr: Introduce a GPR driver
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
The motivation for this imx6sx-gpr driver is to allow describing the LVDS LDB bridge as a GPR subnode.
---
Changes since v5:
- None.
drivers/soc/imx/Makefile | 1 + drivers/soc/imx/imx6sx-gpr.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 drivers/soc/imx/imx6sx-gpr.c
drivers/soc/imx/Makefile +1 -0
@@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o endif obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o +obj-$(CONFIG_SOC_IMX6SX) += imx6sx-gpr.o obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8m-blk-ctrl.o obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8mp-blk-ctrl.o
drivers/soc/imx/imx6sx-gpr.c new file +29 -0
@@ -0,0 +1,29 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include <linux/module.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> + +static int imx6sx_gpr_probe (struct platform_device *pdev) +{ +return devm_of_platform_populate (&pdev->dev); +} + +static const struct of_device_id imx6sx_gpr_ids[] = { + { .compatible ="fsl,imx6sx-iomuxc-gpr" }, + { } +}; +MODULE_DEVICE_TABLE (of, imx6sx_gpr_ids); + +static struct platform_driver imx6sx_gpr_driver = { + .driver = { + .name ="imx6sx_gpr" , + .of_match_table = imx6sx_gpr_ids, + }, + .probe = imx6sx_gpr_probe, +}; +module_platform_driver (imx6sx_gpr_driver); + +MODULE_AUTHOR ("Fabio Estevam <[email protected]>" ); +MODULE_DESCRIPTION ("NXP i.MX6SX GPR driver" ); +MODULE_LICENSE ("GPL" );
Signature · 1 line
2.34.1
Re: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Quoted 48 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The motivation for this imx6sx-gpr driver is to allow describing the LVDS LDB bridge as a GPR subnode.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v5:
- None.drivers/soc/imx/Makefile | 1 + drivers/soc/imx/imx6sx-gpr.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+)create mode 100644
drivers/soc/imx/imx6sx-gpr.cdrivers/soc/imx/Makefile +1
-0@@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o endif obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o +obj-$(CONFIG_SOC_IMX6SX) += imx6sx-gpr.o obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8m-blk-ctrl.o obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8mp-blk-ctrl.odrivers/soc/imx/imx6sx-gpr.c new file +15
-0@@ -0,0 +1,29 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include <linux/module.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> + +static int imx6sx_gpr_probe (struct platform_device *pdev) +{ +return devm_of_platform_populate (&pdev->dev); +} + +static const struct of_device_id imx6sx_gpr_ids[] = { + { .compatible ="fsl,imx6sx-iomuxc-gpr" }, + { } +};
drivers/soc/imx/imx6sx-gpr.c line 25
Quoted 10 lines
drivers/soc/imx/imx6sx-gpr.c new file +10
-0+MODULE_DEVICE_TABLE (of, imx6sx_gpr_ids); + +static struct platform_driver imx6sx_gpr_driver = { + .driver = { + .name ="imx6sx_gpr" , + .of_match_table = imx6sx_gpr_ids, + }, + .probe = imx6sx_gpr_probe, +}; +module_platform_driver (imx6sx_gpr_driver);
I feel inclined to ask -- do you think this could be something which could be added to core code ? It seems very generic.
Thoughts ?
Fabio Estevam
reviewerRe: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Quoted 4 lines · Marek Vasut
I feel inclined to ask -- do you think this could be something which could be added to core code ? It seems very generic.
Thoughts ?
Yes, I think I can work on a more generic solution after this series gets in.
Just wanted to avoid it as a hard requirement right now, if you agree.
Re: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Quoted 10 lines · Fabio Estevam
Quoted 4 lines · Marek Vasut
I feel inclined to ask -- do you think this could be something which could be added to core code ? It seems very generic.
Thoughts ?
Yes, I think I can work on a more generic solution after this series gets in.
Just wanted to avoid it as a hard requirement right now, if you agree.
It might be simple to add this functionality to the core, could you please take a quick look ?
Also, I might be wrong, so let's see what others think too.
Fabio Estevam
reviewerRe: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Hi Marek,
Quoted 2 lines · Marek Vasut
It might be simple to add this functionality to the core, could you please take a quick look ?
If I do the following change:
arch/arm/boot/dts/imx6sx.dtsi +1 -1
@@ -842,7 +842,7 @@ iomuxc: pinctrl@20e0000 { }; gpr: syscon@20e4000 { - compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + compatible = "fsl,imx6sx-iomuxc-gpr",
"syscon", "simple-mfd";
#address-cells = <1>;
#size-cells = <1>;
reg = <0x020e4000 0x4000>;Then I can get rid of this drivers/soc/imx/imx6sx-gpr.c completely.
Would you agree with this approach?
Re: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Quoted 1 line · Fabio Estevam
Hi Marek,
Hi,
Quoted 20 lines · Marek Vasut
Quoted 3 lines
It might be simple to add this functionality to the core, could you please take a quick look ?
If I do the following change:
arch/arm/boot/dts/imx6sx.dtsi +1
-1@@ -842,7 +842,7 @@ iomuxc: pinctrl@20e0000 { }; gpr: syscon@20e4000 { - compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + compatible = "fsl,imx6sx-iomuxc-gpr", "syscon", "simple-mfd"; #address-cells = <1>; #size-cells = <1>;reg = <0x020e4000 0x4000>;
Quoted 3 lines
Then I can get rid of this
drivers/soc/imx/imx6sx-gpr.ccompletely.Would you agree with this approach?
Wasn't this already rejected by Krzysztof ?
Fabio Estevam
reviewerRe: [PATCH v6 5/5] soc: imx: imx6sx-gpr: Introduce a GPR driver
Quoted 1 line · Marek Vasut
Wasn't this already rejected by Krzysztof ?
No, it was 'simple-bus' that was rejected.
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX6SX case, the more specific GPR (General Purpose Register) compatible, "fsl,imx6sx-iomuxc-gpr", can be used instead of the more generic "fsl,imx6q-iomuxc-gpr" one.
Switch to using the more specific i.MX6SX GPR compatible.
Quoted 7 lines
The motivation for this change is to allow the introduction of i.MX6SX GPR driver that will be used to control the i.MX6SX LDB bridge.
Old DTBs are unaffected by this change.
Suggested-by Marek Vasut <[email protected]>Signed-off-by Fabio Estevam <[email protected]>