Skip to contentSkip to conversation

Some fixes for the rockchip dw_mipi_dsi driver

PATCH In review [email protected] 4 participants 19 messages May 22, 2023 – Jul 25, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Some fixes for the rockchip dw_mipi_dsi driver

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

Please take a look.

Thank you and regards,
Ondrej Jirman

Ondrej Jirman (8):
video: rockchip: vop: Fix whitespace
video: dw_mipi_dsi: Fix hsync/vsync settings
video: rockchip: dw_mipi_dsi: Fix external phy existnece check
video: rockchip: dw_mipi_dsi: Fix error path checks in probe function
video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success
video: rockchip: dw_mipi_dsi: Fix best_rate calculation
video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle
video: rockchip: dw_mipi_dsi: Fix GRF access

 drivers/video/dw_mipi_dsi.c                   |  4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 38 +++++++++++--------
 drivers/video/rockchip/rk_vop.c               |  2 +-
 3 files changed, 25 insertions(+), 19 deletions(-)
Signature · 1 line
2.40.1
#1 lore raw

PATCH 1/8 video: rockchip: vop: Fix whitespace

From: Ondrej Jirman <[email protected]>

Fix confusing use of indentation.

---
 drivers/video/rockchip/rk_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk_vop.c +1 -1
index dab9902fda73..c514e2a0e449 100644
@@ -432,7 +432,7 @@ int rk_vop_probe(struct udevice *dev)
 	ret = reset_assert(&ahb_rst);
 	if (ret) {
 		dev_err(dev, "failed to assert ahb reset (ret=%d)\n", ret);
-	return ret;
+		return ret;
 	}
 	udelay(20);
 
Signature · 1 line
2.40.1
Reviewed-by on v1 1/8
#2 lore raw

Re: [PATCH 1/8] video: rockchip: vop: Fix whitespace

Hi Ondrej,

    Thanks for you patches.

Quoted 5 lines · On 2023/5/23 05:47, [email protected] wrote:

From: Ondrej Jirman <[email protected]>

Fix confusing use of indentation.

Thanks,
- Kever

Quoted 17 lines
---
  drivers/video/rockchip/rk_vop.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk_vop.c +1 -1
index dab9902fda73..c514e2a0e449 100644
@@ -432,7 +432,7 @@ int rk_vop_probe(struct udevice *dev)
  	ret = reset_assert(&ahb_rst);
  	if (ret) {
  		dev_err(dev, "failed to assert ahb reset (ret=%d)\n", ret);
-	return ret;
+		return ret;
  	}
  	udelay(20);
 
#3 lore raw

PATCH 2/8 video: dw_mipi_dsi: Fix hsync/vsync settings

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

These must be read from timings->flags, like other DSI HOST drivers do.

And they must not be inverted either. Low means low.

Without this fix, panel drivers that set *SYNC_LOW produce corrupted output on screen (shifted horizobnntally and vertivally by back porch distance).

---
 drivers/video/dw_mipi_dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/dw_mipi_dsi.c +2 -2
index 92e388ac1e42..22fef7e8825f 100644
@@ -538,9 +538,9 @@ static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi,
 		break;
 	}
 
-	if (device->mode_flags & DISPLAY_FLAGS_VSYNC_HIGH)
+	if (timings->flags & DISPLAY_FLAGS_VSYNC_LOW)
 		val |= VSYNC_ACTIVE_LOW;
-	if (device->mode_flags & DISPLAY_FLAGS_HSYNC_HIGH)
+	if (timings->flags & DISPLAY_FLAGS_HSYNC_LOW)
 		val |= HSYNC_ACTIVE_LOW;
 
 	dsi_write(dsi, DSI_DPI_VCID, DPI_VCID(dsi->channel));
Signature · 1 line
2.40.1
#4 lore raw

PATCH 3/8 video: rockchip: dw_mipi_dsi: Fix external phy existnece check

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

&priv->phy is always true. Compiler warns about this loudly.

Use a propper check for phy device allocation. Without this fix using this driver with SoC that doesn't use external phy (eg. RK3399) doesn't work.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +3 -3
index ca548a60b750..b1b5328595e0 100644
@@ -344,7 +344,7 @@ static int dsi_phy_init(void *priv_data)
 	struct dw_rockchip_dsi_priv *dsi = dev_get_priv(dev);
 	int ret, i, vco;
 
-	if (&dsi->phy) {
+	if (dsi->phy.dev) {
 		ret = generic_phy_configure(&dsi->phy, &dsi->phy_opts);
 		if (ret) {
 			dev_err(dsi->dsi_host,
@@ -527,7 +527,7 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, struct display_timing *timings,
 	}
 
 	/* for external phy only the mipi_dphy_config is necessary */
-	if (&dsi->phy) {
+	if (dsi->phy.dev) {
 		phy_mipi_dphy_get_default_config(timings->pixelclock.typ  * 10 / 8,
 						 bpp, lanes,
 						 &dsi->phy_opts);
@@ -827,7 +827,7 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 	}
 
 	/* Get a ref clock only if not using an external phy. */
-	if (&priv->phy) {
+	if (priv->phy.dev) {
 		dev_dbg(dev, "setting priv->ref to NULL\n");
 		priv->ref = NULL;
 
Signature · 1 line
2.40.1
#5 lore raw

PATCH 4/8 video: rockchip: dw_mipi_dsi: Fix error path checks in probe function

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

Wrong return codes were checked in several places. Check the proper ones.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +5 -2
index b1b5328595e0..b7d6b51703c0 100644
@@ -822,6 +822,7 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 
 	priv->pclk = devm_clk_get(dev, "pclk");
 	if (IS_ERR(priv->pclk)) {
+		ret = PTR_ERR(priv->pclk);
 		dev_err(dev, "peripheral clock get error %d\n", ret);
 		return ret;
 	}
@@ -833,7 +834,8 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 
 	} else {
 		priv->ref = devm_clk_get(dev, "ref");
-		if (ret) {
+		if (IS_ERR(priv->ref)) {
+			ret = PTR_ERR(priv->ref);
 			dev_err(dev, "pll reference clock get error %d\n", ret);
 			return ret;
 		}
@@ -841,7 +843,8 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 
 	priv->rst = devm_reset_control_get_by_index(device->dev, 0);
 	if (IS_ERR(priv->rst)) {
-		dev_err(dev, "missing dsi hardware reset\n");
+		ret = PTR_ERR(priv->rst);
+		dev_err(dev, "missing dsi hardware reset %d\n", ret);
 		return ret;
 	}
 
Signature · 1 line
2.40.1
#6 lore raw

PATCH 5/8 video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

ret is undefined if external phy is not used resulting in bogus error being returned in that scenario.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +1 -1
index b7d6b51703c0..5e8db6bd2e63 100644
@@ -460,7 +460,7 @@ static int dsi_phy_init(void *priv_data)
 	dw_mipi_dsi_phy_write(dsi, HS_TX_DATA_LANE_EXIT_STATE_TIME_CONTROL,
 			      BIT(5) | ns2bc(dsi, 100));
 
-	return ret;
+	return 0;
 }
 
 static void dsi_phy_post_set_mode(void *priv_data, unsigned long mode_flags)
Signature · 1 line
2.40.1
#7 lore raw

PATCH 6/8 video: rockchip: dw_mipi_dsi: Fix best_rate calculation

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

pllref_clk is unused after being retrieved. fin needs to be set to dsi->ref clock's rate for the following calculation to work. Otherwise fin is undefined, and calculation return bogus number based on undefined variable.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +1 -2
index 5e8db6bd2e63..6d8b1e6f541a 100644
@@ -505,7 +505,6 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, struct display_timing *timings,
 	unsigned int _prediv, best_prediv;
 	unsigned long _fbdiv, best_fbdiv;
 	unsigned long min_delta = ULONG_MAX;
-	unsigned int pllref_clk;
 
 	bpp = mipi_dsi_pixel_format_to_bpp(format);
 	if (bpp < 0) {
@@ -537,7 +536,7 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, struct display_timing *timings,
 		return 0;
 	}
 
-	pllref_clk = clk_get_rate(dsi->ref);
+	fin = clk_get_rate(dsi->ref);
 	fout = target_mbps * USEC_PER_SEC;
 
 	/* constraint: 5Mhz <= Fref / N <= 40MHz */
Signature · 1 line
2.40.1
#8 lore raw

PATCH 7/8 video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

If phy is not defined in DT (eg. on rk3399), generic_phy_get_by_name will return -ENODATA. Handle that case correctly.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +2 -2
index 6d8b1e6f541a..fd885ac8ccb6 100644
@@ -814,9 +814,9 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 	 * NULL if it's not initialized.
 	 */
 	ret = generic_phy_get_by_name(dev, "dphy", &priv->phy);
-	if ((ret) && (ret != -ENODEV)) {
+	if (ret && ret != -ENODATA) {
 		dev_err(dev, "failed to get mipi dphy: %d\n", ret);
-		return -EINVAL;
+		return ret;
 	}
 
 	priv->pclk = devm_clk_get(dev, "pclk");
Signature · 1 line
2.40.1
#9 lore raw

PATCH 8/8 video: rockchip: dw_mipi_dsi: Fix GRF access

In reply to [email protected]

From: Ondrej Jirman <[email protected]>

Use proper register base and access method to access GRF registers. GRF registers start at a completely different base, and need special access method, that sets the change mask in the 16 MSBs.

---
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/video/rockchip/dw_mipi_dsi_rockchip.c +10 -6
index fd885ac8ccb6..117c3db21ac1 100644
@@ -18,6 +18,7 @@
 #include <panel.h>
 #include <phy-mipi-dphy.h>
 #include <reset.h>
+#include <syscon.h>
 #include <video_bridge.h>
 #include <dm/device_compat.h>
 #include <dm/lists.h>
@@ -30,6 +31,9 @@
 #include <dm/device-internal.h>
 #include <linux/bitops.h>
 
+#include <asm/arch-rockchip/clock.h>
+#include <asm/arch-rockchip/hardware.h>
+
 #define USEC_PER_SEC	1000000L
 
 /*
@@ -197,6 +201,7 @@ struct dw_rockchip_dsi_priv {
 	struct mipi_dsi_device device;
 	void __iomem *base;
 	struct udevice *panel;
+	void __iomem *grf;
 
 	/* Optional external dphy */
 	struct phy phy;
@@ -752,16 +757,13 @@ static int dw_mipi_dsi_rockchip_set_bl(struct udevice *dev, int percent)
 static void dw_mipi_dsi_rockchip_config(struct dw_rockchip_dsi_priv *dsi)
 {
 	if (dsi->cdata->lanecfg1_grf_reg)
-		dsi_write(dsi, dsi->cdata->lanecfg1_grf_reg,
-			  dsi->cdata->lanecfg1);
+		rk_setreg(dsi->grf + dsi->cdata->lanecfg1_grf_reg, dsi->cdata->lanecfg1);
 
 	if (dsi->cdata->lanecfg2_grf_reg)
-		dsi_write(dsi, dsi->cdata->lanecfg2_grf_reg,
-			  dsi->cdata->lanecfg2);
+		rk_setreg(dsi->grf + dsi->cdata->lanecfg2_grf_reg, dsi->cdata->lanecfg2);
 
 	if (dsi->cdata->enable_grf_reg)
-		dsi_write(dsi, dsi->cdata->enable_grf_reg,
-			  dsi->cdata->enable);
+		rk_setreg(dsi->grf + dsi->cdata->enable_grf_reg, dsi->cdata->enable);
 }
 
 static int dw_mipi_dsi_rockchip_bind(struct udevice *dev)
@@ -794,6 +796,8 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)
 		return -EINVAL;
 	}
 
+	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
+
 	i = 0;
 	while (cdata[i].reg) {
 		if (cdata[i].reg == (fdt_addr_t)priv->base) {
Signature · 1 line
2.40.1
#10 lore raw
In reply to [email protected]

Hi,

Quoted 6 lines · megi xff

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

regards,
Ondrej

Quoted 23 lines

Please take a look.

Thank you and regards,
Ondrej Jirman

Ondrej Jirman (8):
video: rockchip: vop: Fix whitespace
video: dw_mipi_dsi: Fix hsync/vsync settings
video: rockchip: dw_mipi_dsi: Fix external phy existnece check
video: rockchip: dw_mipi_dsi: Fix error path checks in probe function
video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success
video: rockchip: dw_mipi_dsi: Fix best_rate calculation
video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle
video: rockchip: dw_mipi_dsi: Fix GRF access

 drivers/video/dw_mipi_dsi.c                   |  4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 38 +++++++++++--------
 drivers/video/rockchip/rk_vop.c               |  2 +-
 3 files changed, 25 insertions(+), 19 deletions(-)
Signature · 1 line
2.40.1
#11 lore raw
Quoted 7 lines · On Thu, 13 Jul 2023 16:51:36 +0200 Ondřej Jirman [email protected] wrote:

Hi,

Quoted 4 lines · megi xff

From: Ondrej Jirman <[email protected]>

Quoted 7 lines
Quoted 2 lines

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

I hoped to get a Tested-by for this series to make sure it does not break current users.

--
Anatolij

#12 lore raw
Quoted 14 lines · Anatolij Gustschin
Quoted 10 lines · On Thu, 13 Jul 2023 16:51:36 +0200 Ondřej Jirman [email protected] wrote:

Hi,

Quoted 6 lines · megi xff

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

Quoted 7 lines
Quoted 4 lines

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

I hoped to get a Tested-by for this series to make sure it does not break current users.

It's a miracle it even works for the current users, given the wrong way the current code writes to GRF registers, which makes it to have no intended effect, etc.

Anyway, is there some upper limit to wait for Tested-by? 2 months seems excessive. Just so I can remind myself sooner next time. :)

I can understand a few weeks, but 2 months just deters contributions.

kind regards,

	o.
Quoted 2 lines

--
Anatolij

#13 lore raw
Quoted 23 lines · On Thu, 13 Jul 2023 18:03:48 +0200 Ondřej Jirman [email protected] wrote:
Quoted 14 lines · Anatolij Gustschin
Quoted 10 lines · On Thu, 13 Jul 2023 16:51:36 +0200 Ondřej Jirman [email protected] wrote:

Hi,

Quoted 6 lines · megi xff

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

Quoted 7 lines
Quoted 4 lines

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

I hoped to get a Tested-by for this series to make sure it does not break current users.

Quoted 8 lines

It's a miracle it even works for the current users, given the wrong way the current code writes to GRF registers, which makes it to have no intended effect, etc.

Anyway, is there some upper limit to wait for Tested-by? 2 months seems excessive. Just so I can remind myself sooner next time. :)

I can understand a few weeks, but 2 months just deters contributions.

I usually apply new patches during the merge window (we have three months release cycle) and this patch series was sent when the merge window was closed. If patches are bug fixes (like in this case) I prefer to get them tested by someone who has the actual hardware. When there is an Acked-by or Tested-by, then I apply the fixes for -rcX. We already had several cases in the past where simple and obvious timing fixes in the driver broke display support for in tree boards, therefore I'm somewhat reluctant to apply fixes for -rcX without Tested-by.

--
Anatolij

#14 lore raw
Quoted 36 lines · Anatolij Gustschin
Quoted 23 lines · On Thu, 13 Jul 2023 18:03:48 +0200 Ondřej Jirman [email protected] wrote:
Quoted 14 lines · Anatolij Gustschin
Quoted 10 lines · On Thu, 13 Jul 2023 16:51:36 +0200 Ondřej Jirman [email protected] wrote:

Hi,

Quoted 6 lines · megi xff

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

Quoted 7 lines
Quoted 4 lines

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

I hoped to get a Tested-by for this series to make sure it does not break current users.

Quoted 8 lines

It's a miracle it even works for the current users, given the wrong way the current code writes to GRF registers, which makes it to have no intended effect, etc.

Anyway, is there some upper limit to wait for Tested-by? 2 months seems excessive. Just so I can remind myself sooner next time. :)

I can understand a few weeks, but 2 months just deters contributions.

Quoted 8 lines

I usually apply new patches during the merge window (we have three months release cycle) and this patch series was sent when the merge window was closed. If patches are bug fixes (like in this case) I prefer to get them tested by someone who has the actual hardware. When there is an Acked-by or Tested-by, then I apply the fixes for -rcX. We already had several cases in the past where simple and obvious timing fixes in the driver broke display support for in tree boards, therefore I'm somewhat reluctant to apply fixes for -rcX without Tested-by.

Thanks for explanation and for applying the patches.

kind regards,
Ondrej

Quoted 2 lines

--
Anatolij

#15 lore raw
In reply to Anatolij Gustschin

I’ve been on holiday and not able to add my Tested-By yet, I do apologize. It will probably be another week and a half before I can, but I will check these out and if they cause problems I’ll let you know/start work on a fix.

Thank you.

Quoted 48 lines · Anatolij Gustschin

On Thu, 13 Jul 2023 18:03:48 +0200

Quoted 23 lines · Ondřej Jirman [email protected] wrote:
Quoted 15 lines · Anatolij Gustschin
Quoted 10 lines · On Thu, 13 Jul 2023 16:51:36 +0200 Ondřej Jirman [email protected] wrote:

Hi,

Quoted 6 lines · megi xff

From: Ondrej Jirman <[email protected]>

These are just random fixes for bugs I found while eyeballing the code and porting it to work with RK3399.

Quoted 7 lines
Quoted 4 lines

It would be nice if somebody merged this. I'd like to add display support for a few boards, and these patches are just fairly obvious bugfixes in new code added in 2023.07 that I hoped would get merged in the bugfix part of the merge window.

I hoped to get a Tested-by for this series to make sure it does not break current users.

Quoted 8 lines

It's a miracle it even works for the current users, given the wrong way the current code writes to GRF registers, which makes it to have no intended effect, etc.

Anyway, is there some upper limit to wait for Tested-by? 2 months seems excessive. Just so I can remind myself sooner next time. :)

I can understand a few weeks, but 2 months just deters contributions.

I usually apply new patches during the merge window (we have three months release cycle) and this patch series was sent when the merge window was closed. If patches are bug fixes (like in this case) I prefer to get them tested by someone who has the actual hardware. When there is an Acked-by or Tested-by, then I apply the fixes for -rcX. We already had several cases in the past where simple and obvious timing fixes in the driver broke display support for in tree boards, therefore I'm somewhat reluctant to apply fixes for -rcX without Tested-by.

--
Anatolij

#16 lore raw
In reply to [email protected]

On Mon, 22 May 2023 23:47:00 +0200
[email protected] [email protected] wrote:
...

Quoted 10 lines

Ondrej Jirman (8):
video: rockchip: vop: Fix whitespace
video: dw_mipi_dsi: Fix hsync/vsync settings
video: rockchip: dw_mipi_dsi: Fix external phy existnece check
video: rockchip: dw_mipi_dsi: Fix error path checks in probe function
video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success
video: rockchip: dw_mipi_dsi: Fix best_rate calculation
video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle
video: rockchip: dw_mipi_dsi: Fix GRF access

Quoted 4 lines
 drivers/video/dw_mipi_dsi.c                   |  4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 38 +++++++++++--------
 drivers/video/rockchip/rk_vop.c               |  2 +-
 3 files changed, 25 insertions(+), 19 deletions(-

Series applied to u-boot-video/master, thanks!

--
Anatolij

Tested-by
#17 lore raw
Quoted 13 lines · Anatolij Gustschin

On Mon, 22 May 2023 23:47:00 +0200
[email protected] [email protected] wrote:
...

Quoted 10 lines

Ondrej Jirman (8):
video: rockchip: vop: Fix whitespace
video: dw_mipi_dsi: Fix hsync/vsync settings
video: rockchip: dw_mipi_dsi: Fix external phy existnece check
video: rockchip: dw_mipi_dsi: Fix error path checks in probe function
video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success
video: rockchip: dw_mipi_dsi: Fix best_rate calculation
video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle
video: rockchip: dw_mipi_dsi: Fix GRF access

Quoted 6 lines
Quoted 4 lines
 drivers/video/dw_mipi_dsi.c                   |  4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 38 +++++++++++--------
 drivers/video/rockchip/rk_vop.c               |  2 +-
 3 files changed, 25 insertions(+), 19 deletions(-

Series applied to u-boot-video/master, thanks!

Too late for this to actually MATTER (I was out of town, sorry), but for what it's worth...

Thank you.

Quoted 3 lines

--
Anatolij

#18 lore raw
Quoted 20 lines · Chris Morgan
Quoted 18 lines · Anatolij Gustschin

On Mon, 22 May 2023 23:47:00 +0200
[email protected] [email protected] wrote:
...

Quoted 14 lines

Ondrej Jirman (8):
video: rockchip: vop: Fix whitespace
video: dw_mipi_dsi: Fix hsync/vsync settings
video: rockchip: dw_mipi_dsi: Fix external phy existnece check
video: rockchip: dw_mipi_dsi: Fix error path checks in probe function
video: rockchip: dw_mipi_dsi: Return 0 from dsi_phy_init on success
video: rockchip: dw_mipi_dsi: Fix best_rate calculation
video: rockchip: dw_mipi_dsi: Correct check for lacking phy phandle
video: rockchip: dw_mipi_dsi: Fix GRF access

 drivers/video/dw_mipi_dsi.c                   |  4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 38 +++++++++++--------
 drivers/video/rockchip/rk_vop.c               |  2 +-
 3 files changed, 25 insertions(+), 19 deletions(-
Quoted 8 lines
Quoted 1 line

Series applied to u-boot-video/master, thanks!

Too late for this to actually MATTER (I was out of town, sorry), but for what it's worth...

Thank you.

Great, thanks. :) Good to know I did not break your use case.

kind regards,

	o.
Quoted 3 lines
Quoted 3 lines

--
Anatolij